tkluck / inplace.jl Goto Github PK

I assume you didn't know about MutableArithmetics.jl when you created this package? It makes InPlace.jl redundant.

It might be easy to make this package just a thin wrapper around MA. Or maybe just point point people to MA in the README, deprecate and archive.

Some methods like this:
inplace!(::typeof(+), a::BigInt, b::BigInt, c::Integer) = inplace!(+,a,b,convert(BigInt,c))
should be calling add_ui! if the argument is a builtin signed or unsigned int. Converting to a BigInt is expensive.

I suppose there are a few other functions in GMP.MPZ that have not yet been supported.