tkhq / ecr-proxy Goto Github PK

For debugging and tracing it would be nice if this project supported opentelemetry; in particular reporting of tracing spans.
@drGrove you may be able to help here?

It's not trivial to use a non-HTTPS registry.

To allow use of this project with a TLS terminating load balancer in front, it should be able to listen on HTTPS (and take key+certificate files to use)

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update golang:1.21-bullseye docker digest to 447afe7
• chore(deps): update golang docker tag to v1.22
• fix(deps): update aws-sdk-go-v2 (github.com/aws/aws-sdk-go-v2, github.com/aws/aws-sdk-go-v2/config, github.com/aws/aws-sdk-go-v2/service/ecr)
• fix(deps): update module go.uber.org/zap to v1.27.0
• chore(deps): update github artifact actions to v4 (major) (actions/download-artifact, actions/upload-artifact)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

As a static go build we should already have reproducibility out of the box for the binary, so it's probably just going to be removing some timestamps from docker manifests?

Probably need SOURCE_DATE_EPOCH in the build-and-push job?

• https://docs.docker.com/build/release-notes/#0100
• https://github.com/moby/buildkit/blob/master/docs/build-repro.md#source_date_epoch

May also need something in/around the docker metadata job as I think it adds a timestamp to labels https://github.com/docker/metadata-action/blob/818d4b7b91585d195f67373fd9cb0332e31a7175/src/meta.ts#L464. As an easy solution, I'd be fine with just not using the labels at all.

Currently pressing Ctrl+c doesn't exit ecr-proxy.
Add some sort of SIGINT handling to exit when Ctrl+c is pressed.

Currently ecr-proxy takes a single ECR repo to proxy via a command line argument.

This means to access different ECR registries a user needs to run multiple instances of ecr-proxy.

Instead, could you proxy to different accounts/registries based on e.g. a Host header?