titstewan / tirea-material-lesson-blog Goto Github PK

?p=lessons with no &l throws warning message: Missing argument 1 for navi_lesson(). We should fix that because the page should render withouth the &l argument.

An empty line prevents cookie to be sent...

I'll try this evening to lurk to add some code to make this blog international by integrating some kind of text strings.

automated rss feed, i think.

Clicking on a link that contain l=01g-german for example loads only stuff that was stored in the cookie like english or any other language.
A possible fix ould be to let update the cookie lang value also by requesting a specific language lesson.

I want to find an elegant way to let include the lessons...

By reorganizing the html code of the Sound page, I apparently broke a javascript code. Not enterly sure what happened...

Steps to reproduce:

1. Use an invalid language choice in the URL
2. See blank page or Error 500

To fix the 500, until cookie value and URL var are validated:

1. Use a legitimate value of a language that is actually supported, such as: this
2. Page now loads as expected, using English.

I recommend the following to fix this bug:

Force the setting of only acceptable values to the cookie. This way, the value can never be invalid no matter how hard user tries. Also, because of this, we would not need to check validity of the var in every single file of function where it's used.

Well, it's not really broken, but if one try to choose custom variable, it won't work, everything else works fine.

Now that the RSS is automatic, Feed Validator seems to hate the new atom self-link.

For some reason our feed is invalid.

http://www.feedvalidator.org/check.cgi?url=http%3A%2F%2Ftirea.learnnavi.org%2Ftest%2Findex.php%3Fp%3Drss%26lang%3Denglish

Adding / not adding?
https://github.com/Titstewan/DictionaryGenerator

if we can automate the cookie verification AND the lang menu, one only need to add a new lesson and stuff will do the work without editing the php files.

This bug exists on both Firefox and Chrome.

Steps to reproduce:

1. Clear all cookies in the browser
2. Visit the Test Site
3. Check Cookies in Firebug. You will see one cookie already, default set by index.php:

lang        english        .tirea.learnnavi.org  11 B        /  <expire date> 

notice the dot before $domain (HOW TF does that get there?)

4. Switch language to any language using the language menu (Esperanto, z.B.)
5. Check the Cookies in Firebug again. Now there are two:

lang        esperanto   tirea.learnnavi.org  11 B         /  <expire date> 
lang        english        .tirea.learnnavi.org  11 B        /  <expire date> 

6. Switch language again to something else and check cookies again:

lang        german       tirea.learnnavi.org  11 B         /  <expire date> 
lang        english        .tirea.learnnavi.org  11 B        /  <expire date>

Result: Language Switcher does not work. Stays in English the entire time.

Hack-fix:

1. Use http://tirea.learnnavi.org/test/index.php?lang=esperanto z.B. to actually have target language load.
2. Checking cookies again, we see (if just now following these steps right after step 6 above):

lang        esperanto      .tirea.learnnavi.org  11 B         /  <expire date> 
lang        german           tirea.learnnavi.org  11 B        /  <expire date>

3. Switch language again using URL: index.php?lang=dutch z.B.
4. Check again:

lang        dutch        .tirea.learnnavi.org  11 B        /  <expire date>
lang        german     tirea.learnnavi.org  11 B         /  <expire date> 

Interesting indeed. What on Pandora is causing this? the Flux Vortex? This wasn't happening before...
I have checked and All functions in our PHP that calls setcookie() use $domain var from settings.php which on the server is set $domain = 'tirea.learnnavi.org'; (with no dot at beginning)

I have no idea how this is happening or how to fix this. O__o