Rather than bundle the MSBuild runtime with the language server, investigate using MSBuildLocator instead.

See https://docs.microsoft.com/en-us/visualstudio/msbuild/updating-an-existing-application?view=vs-2019 for details.

Is there a reason why local nuget packagesources are discarded?

Context:

#54 (comment)

CC: @DoctorKrolic

The main idea of a language server protocol is to provide intellisense in as client-independent way as possible. In practice, however, language servers do often contain client-dependent elements. One of such cases is using enviroment variables. I'm not saying here, that we should get rid of them all together. Even official C# extension from MS uses enviroment variables for configuring some aspects of a language server. However, it's in our interest to maintain this LSP as client-independent as possible, so it can be used outside of our own VS Code extension (see #33). Thus, IMO, we should reconsider usage of enviroment variables and avoid them as much as possible. Ideally, enviroment variables should only be used to configure options, that must be present on server startup.

For instance, we use MSBUILD_PROJECT_TOOLS_DIR variable as a base path task cache storage. Why do we need it if we can just use relative path for that?

Another example is MSBUILD_PROJECT_TOOLS_VERBOSE_LOGGING. Do we really need to know this information on server startup or we can use standard configuration endpoint? I think the latter is sufficient for our needs.

In the end, we should question every variable we use with this model of thinking. Those variables, that can be avoided, should be deleted

Whether I change one setting or ten, msbuildProjectTools seems to always inject the full settings in VS Code. even those I didn't modify.

BTW... What a great extension. Can't life wihtou it.

I've been frequently noticing dotnet build and similar operations complaining about "access denied" and "The process cannot access the file .../obj/project.assets.json because it is being used by another process."

Searching for handles with System Informer results in the relevant files only being opened by the dotnet.exe process hosting this extension.

Can't build .csproj file due to the following error:

[project.csproj] The imported project "c:\Users\myuser.vscode\extensions\tintoy.msbuild-project-tools-0.2.39\out\language-server\Microsoft\VisualStudio\v12.0\WebApplications\Microsoft.WebApplication.targets" was not found. Confirm that the path in the declaration is correct, and that the file exists on disk.

Failing line:

<Import Project="$(VSToolsPath)\WebApplications\Microsoft.WebApplication.targets" Condition="'$(VSToolsPath)' != ''" />

This issue has me completely vexxed...
I had copied the 8.0 preview sdk files to my dotnet folder /opt/dotnet/, and saw this extension no longer giving me autocompletion.
For a sanity-check, I:

1. Installed vscode-insiders (instead of vscode-oss) (still failed)
2. Futzed with the permissions which should've been fine (though I learned chmod using o+rX or o=rX would set 'x' permission on files too if 'u' also had 'x') (still failed)
3. Moved the dotnet folder and replaced it with only the 8.0 preview (instead of 6.0, 7.0, 8.0 preview) (this worked)
4. Copying 7.0 and 8.0 preview back in (still failed)
5. Rm'ing all 7.0 related files ($ find /opt/dotnet -name "*7.0*") from the dotnet path (but NOT removing 7.0 references found in the 8.0 sdk) (this worked)

So it's like there's some conflict having 7.0 and 8.0 sdks together which makes no sense.

MSBuild Language Server
Failing:

Result was "System.Threading.Tasks.Task`1[[OmniSharp.Extensions.LanguageServer.Protocol.Models.InitializeResult, OmniSharp.Extensions.LanguageProtocol, Version=0.7.9.0, Culture=neutral, PublicKeyToken=null]]"
Response value was "OmniSharp.Extensions.LanguageServer.Protocol.Models.InitializeResult"
Finished: Routing Request (0) "initialize" in 39ms
Finding descriptor for "initialized"
Finding descriptor for "workspace/didChangeConfiguration"
Starting: Routing Notification "initialized"
Finished: Routing Notification "initialized" in 8ms
Starting: Routing Notification "workspace/didChangeConfiguration"
Converting params for Notification "workspace/didChangeConfiguration" to "MSBuildProjectTools.LanguageServer.CustomProtocol.DidChangeConfigurationObjectParams"
Finished: Routing Notification "workspace/didChangeConfiguration" in 56ms
Finding descriptor for "textDocument/didOpen"
Created attribute "xml::file:///<pathTo>.csproj"
Looking for handler for method ["OmniSharp.Extensions.LanguageServer.Server.HandlerDescriptor"]
Checking handler ["OmniSharp.Extensions.LanguageServer.Server.HandlerDescriptor"]:"MSBuildProjectTools.LanguageServer.Handlers.DocumentSyncHandler"
Registration options "OmniSharp.Extensions.LanguageServer.Protocol.Models.TextDocumentRegistrationOptions"
Document Selector "[msbuild, file, **/*.*], [xml, file, **/*.*proj], [xml, file, **/*.props], [xml, file, **/*.targets]"
Starting: Routing Notification "textDocument/didOpen"
Converting params for Notification "textDocument/didOpen" to "OmniSharp.Extensions.LanguageServer.Protocol.Models.DidOpenTextDocumentParams"
[Info  - 5:48:52 PM] Using MSBuild engine v8.0.100 from "/opt/dotnet/sdk/8.0.100-preview.7.23376.3/".
Language server initialised by client.
Finding descriptor for "textDocument/documentSymbol"
Found attributes 1, ["msbuild::file:///<pathTo>.csproj"]
Looking for handler for method ["OmniSharp.Extensions.LanguageServer.Server.HandlerDescriptor"]
Checking handler ["OmniSharp.Extensions.LanguageServer.Server.HandlerDescriptor"]:"MSBuildProjectTools.LanguageServer.Handlers.DocumentSymbolHandler"
Registration options "OmniSharp.Extensions.LanguageServer.Protocol.Models.TextDocumentRegistrationOptions"
Document Selector "[msbuild, file, **/*.*], [xml, file, **/*.*proj], [xml, file, **/*.props], [xml, file, **/*.targets]"
[Error - 5:48:52 PM] Unexpected error loading file "/<pathTo>.csproj".
System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at async Task MSBuildProjectTools.LanguageServer.Documents.ProjectDocument.Load(CancellationToken cancellationToken)
   at void System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start<TStateMachine>(ref TStateMachine stateMachine)
   at Task MSBuildProjectTools.LanguageServer.Documents.ProjectDocument.Load(CancellationToken cancellationToken)
   at Task MSBuildProjectTools.LanguageServer.Documents.MasterProjectDocument.<>n__0(?)
   at async Task MSBuildProjectTools.LanguageServer.Documents.MasterProjectDocument.Load(CancellationToken cancellationToken) in /<pathTo>/D:\Development\github\tintoy\msbuild-project-tools-vscode\lib\server\src\LanguageServer.Engine\Documents\MasterProjectDocument.cs:line 131
   at async Task<ProjectDocument> MSBuildProjectTools.LanguageServer.Documents.Workspace.GetProjectDocument(Uri documentUri, bool reload) in /<pathTo>/D:\Development\github\tintoy\msbuild-project-tools-vscode\lib\server\src\LanguageServer.Engine\Documents\Workspace.cs:line 226

Working:

Result was "System.Threading.Tasks.Task`1[[OmniSharp.Extensions.LanguageServer.Protocol.Models.InitializeResult, OmniSharp.Extensions.LanguageProtocol, Version=0.7.9.0, Culture=neutral, PublicKeyToken=null]]"
Response value was "OmniSharp.Extensions.LanguageServer.Protocol.Models.InitializeResult"
Finished: Routing Request (0) "initialize" in 38ms
Finding descriptor for "initialized"
Finding descriptor for "workspace/didChangeConfiguration"
Starting: Routing Notification "initialized"
Finished: Routing Notification "initialized" in 3ms
Starting: Routing Notification "workspace/didChangeConfiguration"
Converting params for Notification "workspace/didChangeConfiguration" to "MSBuildProjectTools.LanguageServer.CustomProtocol.DidChangeConfigurationObjectParams"
Finished: Routing Notification "workspace/didChangeConfiguration" in 42ms
Finding descriptor for "textDocument/didOpen"
Created attribute "xml::file:///<pathTo>.csproj"
Looking for handler for method ["OmniSharp.Extensions.LanguageServer.Server.HandlerDescriptor"]
Checking handler ["OmniSharp.Extensions.LanguageServer.Server.HandlerDescriptor"]:"MSBuildProjectTools.LanguageServer.Handlers.DocumentSyncHandler"
Registration options "OmniSharp.Extensions.LanguageServer.Protocol.Models.TextDocumentRegistrationOptions"
Document Selector "[msbuild, file, **/*.*], [xml, file, **/*.*proj], [xml, file, **/*.props], [xml, file, **/*.targets]"
Starting: Routing Notification "textDocument/didOpen"
Converting params for Notification "textDocument/didOpen" to "OmniSharp.Extensions.LanguageServer.Protocol.Models.DidOpenTextDocumentParams"
Language server initialised by client.
Finding descriptor for "textDocument/documentSymbol"
[Info  - 6:10:36 PM] Using MSBuild engine v8.0.100 from "/opt/dotnet/sdk/8.0.100-preview.7.23376.3/".
Found attributes 1, ["msbuild::file:///<pathTo>.csproj"]
Looking for handler for method ["OmniSharp.Extensions.LanguageServer.Server.HandlerDescriptor"]
Checking handler ["OmniSharp.Extensions.LanguageServer.Server.HandlerDescriptor"]:"MSBuildProjectTools.LanguageServer.Handlers.DocumentSymbolHandler"
Registration options "OmniSharp.Extensions.LanguageServer.Protocol.Models.TextDocumentRegistrationOptions"
Document Selector "[msbuild, file, **/*.*], [xml, file, **/*.*proj], [xml, file, **/*.props], [xml, file, **/*.targets]"
[Info  - 6:10:38 PM] 1 package sources configured for project "/<pathTo>.csproj".
[Info  - 6:10:38 PM]   Locally-configured package source "nuget.org" (v3) => https://api.nuget.org/v3/index.json

I'm doing a lot of MSBuild Sdk projects, I was using Qub's MSBuild Tools when I was first beginning to use VSCode, and then I found your's after some time. I was using them both until now.

Here are few feature suggestions for your extension that relates to language server:

1. For Conditions, Please show the detailed Evaluated result.

E.g:

<Individual Properties/Expression>: <value>
Evaluated: <Evaluated Exp>
Result: <true/false>

2. Let us set a context project to which against the props/targets for both Sdk-style and regular projects will be Evaluated!

E.g: When working on set of targets/props either separately or through Sdk pattern, the opened props/targets are evaluated as if they are used directly so, most of the properties would turn up empty or undefined which leads to serious Item issue, where a code fragment like this one:

https://github.com/nirin/msbuild-sdks/blob/feature/sdks/Source/MSBuild.NET.Extras.Sdk/Build/MSBuild.NET.Extras.Items.props#L39-L55

3. Qub's tools link docs to the known MSBuild xml element and attributes, so if possible please add this feature too!

P.S.: I'm willing to help, but I'm new at MSBuild, right now I'm learning MSBuild authoring so that I can use it in my own projects. Yours and Qub's extension really helped me a lot!

When inserting an element (e.g. user types <), the project file contents become invalid XML and so a diagnostic is published indicating the location of the error. This makes the UX a bit unpleasant because the focus of their attention is the element being inserted and this element is underlined with red squiggles.

If possible, find a way to detect start / end of completion activity (from memory, LSP has the ability to make completions as requiring a separate "resolve" step which might suit our purposes) and then publish diagnostic(s) once the completion activity has ended.

Hello! Thank you for your awesome project! I'm trying to use it on neovim. For the most part, everything works out of the box... other than completion.

Completion won't work for any well-known tasks/properties or any imports. I see some errors about the plugin ignoring my repositories from work because they don't support the NuGet V3 API, but no other logs, even when I run on Debug log level. I'll keep messing with the server and update here if I figure things out. I'm guessing there might be some other pipe over which the server is sending completion information.

I'm trying to use this on a system with .NET5, but I saw that this isn't supported. So I installed the 3.1 runtime.

Now the extension loads, but I get an error:

Error loading MSBuild project '"/foo/bar/myproject/src/Directory.Build.props"'.
System.IO.FileNotFoundException: Could not load file or assembly 'System.Collections.Immutable, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

There is no problem with my config, as it works when I use dotnet build, dotnet run, etc.

What could this be?

5.0 is not an LTS release, but the MSBuild / .NET SDK treadmill is kinda forcing my hand here :-)

Continues the work from #20.

Some enhancements to the work started in #84:

• Only offer PackageVersion element completion if the MSBuild project's ManagePackageVersionsCentrally property is set to true (or True).
• Consider also hiding Version attribute completion on PackageReference elements if ManagePackageVersionsCentrally is set (might want to make this configurable though, if we choose to do it at all).
• Rename HandlePackageReferenceElementCompletion and HandlePackageReferenceAttributeCompletion to HandleElementCompletion and HandleAttributeCompletion since the handler now deals with multiple item types.

Hey! Awesome job on making a language server for msbuild! I have no clue why this isn't just part of .NET...

I was wondering if you would be interested in adding file support for raw nuspec files. Most of the functionality works just by including the schema (xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd") but there are some features that I would love:

• The ability to update dependencies with autocomplete:
• Autocomplete for replacement tokens

VSCode 1.44 allows language servers to provide semantic highlighting. It would be nice if this extension did this as well for things like Conditions or other expressions. See for example DeltaXML/vscode-xslt-tokenizer, which does this for XSLT.

This is better to show than explain:

For some reason the first letter isn't a part of completion session.

However, if you first manually trigger completions and then start typing, everything is working fine:

Extend the configuration schema to support specifying overrides for MSBuild global properties:

{
  "msbuildProjectTools": {
    "msbuild": {
      "globalProperties": [
        {
          "name": "MSBuildSdksPath",
          "value": "C:\\Foo\\Bar"
        },
        {
          "name": "AnotherProperty",
          "value": "HelloWorld"
        }
      ]
    }
   }
}

If these properties conflict with any existing definitions that would otherwise be supplied by the language service, then these properties will win.

Relates to tintoy/msbuild-project-tools-vscode#35 and Relates to #5

Hey there, I was thinking about trying to make a Visual Studio 2022 LSP extension for this project since our team uses VS as well as VS Code. I was wondering if there is a public nuget feed where you publish the packages? I noticed that they get published to https://ci.appveyor.com/nuget/tintoy but that appears to be a private/protected feed.

Thanks! :)

Using VS Code examples from C#9 and .NET 5 book. After installing MSBuild project tools 0.3.11, I get the following error and setup. Any ideas what might be causing the error? I'm new, so let me know if I need to provide additional details. Thanks.

PS C:\Users\jmurphy\Documents\VSCode\PracticalApps\NorthwindEntitiesLib> dotnet --list-sdks
5.0.102 [C:\Program Files\dotnet\sdk]
PS C:\Users\jmurphy\Documents\VSCode\PracticalApps\NorthwindEntitiesLib> dotnet --list-runtimes
Microsoft.AspNetCore.App 5.0.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.11 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
PS C:\Users\jmurphy\Documents\VSCode\PracticalApps\NorthwindEntitiesLib>

[Info - 2:29:04 PM] 1 package sources configured for project "c:\Users\jmurphy\Documents\VSCode\PracticalApps\NorthwindContextLib\NorthwindContextLib.csproj".
[Info - 2:29:04 PM] Locally-configured package source "nuget.org" (v3) => https://api.nuget.org/v3/index.json
[Error - 2:29:04 PM] Error loading MSBuild project '"c:\Users\jmurphy\Documents\VSCode\PracticalApps\NorthwindContextLib\NorthwindContextLib.csproj"'.
System.IO.FileNotFoundException: Could not load file or assembly 'System.Collections.Immutable, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
File name: 'System.Collections.Immutable, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
at new Microsoft.Build.Evaluation.Context.EvaluationContext(SharingPolicy policy, IFileSystem fileSystem)
at EvaluationContext Microsoft.Build.Evaluation.Context.EvaluationContext.Create(SharingPolicy policy, MSBuildFileSystemBase fileSystem)
at void Microsoft.Build.Evaluation.Project+ProjectImpl.Reevaluate(ILoggingService loggingServiceForEvaluation, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
at void Microsoft.Build.Evaluation.Project+ProjectImpl.ReevaluateIfNecessary(ILoggingService loggingServiceForEvaluation, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
at void Microsoft.Build.Evaluation.Project+ProjectImpl.ReevaluateIfNecessary(ILoggingService loggingServiceForEvaluation, EvaluationContext evaluationContext)
at void Microsoft.Build.Evaluation.Project+ProjectImpl.ReevaluateIfNecessary(EvaluationContext evaluationContext)
at void Microsoft.Build.Evaluation.Project+ProjectImpl.Initialize(IDictionary<string, string> globalProperties, string toolsVersion, string subToolsetVersion, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
at new Microsoft.Build.Evaluation.Project(string projectFile, IDictionary<string, string> globalProperties, string toolsVersion, string subToolsetVersion, ProjectCollection projectCollection, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
at Project Microsoft.Build.Evaluation.ProjectCollection.LoadProject(string fileName, IDictionary<string, string> globalProperties, string toolsVersion)
at Project Microsoft.Build.Evaluation.ProjectCollection.LoadProject(string fileName, string toolsVersion)
at Project Microsoft.Build.Evaluation.ProjectCollection.LoadProject(string fileName)
at bool MSBuildProjectTools.LanguageServer.Documents.MasterProjectDocument.TryLoadMSBuildProject() in C:\Development\github\tintoy\msbuild-project-tools-vscode\lib\server\src\LanguageServer.Engine\Documents\MasterProjectDocument.cs:line 173

[Info - 2:32:02 PM] 1 package sources configured for project "c:\Users\jmurphy\Documents\VSCode\PracticalApps\NorthwindEntitiesLib\NorthwindEntitiesLib.csproj".
[Info - 2:32:02 PM] Locally-configured package source "nuget.org" (v3) => https://api.nuget.org/v3/index.json
[Error - 2:32:02 PM] Error loading MSBuild project '"c:\Users\jmurphy\Documents\VSCode\PracticalApps\NorthwindEntitiesLib\NorthwindEntitiesLib.csproj"'.
System.InvalidOperationException: Parent project does not have an MSBuild project.
at bool MSBuildProjectTools.LanguageServer.Documents.SubProjectDocument.TryLoadMSBuildProject() in C:\Development\github\tintoy\msbuild-project-tools-vscode\lib\server\src\LanguageServer.Engine\Documents\SubProjectDocument.cs:line 86

Now that 3.0 is out, we should upgrade the language server to target netcoreapp3.0.

This means consumers will need either the 3.0 SDK or the 3.0 runtime if they don’t want to upgrade to the 3.0 SDK yet.

May need to be careful about verifying that this doesn’t affect behaviour of the MSBuild engine at runtime.

This is basically just a reappearance of the bug from msbuild-project-tools-vscode#46 but since I don't have 3.x installed, it might be a little different.

Opening a .csproj file on Fedora 29 with .NET Core 2.2.203 installed results in a syntax error being reported in the csproj with the following message:

The imported project "/usr/share/dotnet/sdk/2.2.203/15.0/Microsoft.Common.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. /tmp/test/test.csproj(MSB4019)

At least on my machine, the Microsoft.Common.props file is actually in /usr/share/dotnet/sdk/2.2.203/Current/Microsoft.Common.props rather than the 15.0 the extension looks for in any version below 3.x.

Is this perhaps a change in 2.2.x?

I just tried a fresh .NET Core 2.2.203 install into an Ubuntu 18.10 container and it was also installed into /usr/share/dotnet/sdk/2.2.203/Current, not 15.0.

I'm guessing this is a change in 2.2.x, but I don't have a Windows machine handy to check.

Let me know if you need more info or testing.

System.ArgumentException: An item with the same key has already been added.
System.InvalidOperationException: Parent project does not have an MSBuild project.

My ZipPublishDir Target defines a Destination property. Then it conditionally appends to the value.

<RepoRoot>$([System.IO.Path]::GetDirectoryName($([MSBuild]::GetPathOfFileAbove('.gitignore', '$(MSBuildProjectDirectory)'))))</RepoRoot>
<Destination>$(RepoRoot)/publish/$(AssemblyName).$(Version)$(PART_RuntimeIdentifier)</Destination>
<Destination Condition="'$(RuntimeIdentifier)' != '' ">$(Destination).$(RuntimeIdentifier)</Destination>

MSBuild reassigns the value to the existing property–or redefines it–as expected.
msbuild-project-tools-server cannot handle reassignments. Instead, it throws System.ArgumentException. Consequently, it cannot load any project importing a file containing this usage.

When adding a key that already exists, msbuild-project-tools-server should

• A: Assign the new key's value to the existing key. All instances of that property will have the same evaluated value.
• B: Keep both, but rename duplicates in the order they're discovered. This allows all instances to evaluate to independent values e.g. if the first definition is Destination, then the second definition's key would be Destination>1 and so on.
  • The use of the > character should prevent naming collisions. It cannot be used in a property name—even as >.

error caused by ZipPublishDir

[Error - 5:23:01 AM] Unhandled exception in OnHover.
System.ArgumentException: An item with the same key has already been added. Key: file:///c%3A/Repos/BinToss/GroupBox.Avalonia/node_modules/%40halospv3/hce.shared-config/dotnet/ZipPublishDir.targets
   at bool System.Collections.Generic.Dictionary<TKey, TValue>.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at Task<ProjectDocument> MSBuildProjectTools.LanguageServer.Documents.Workspace.GetProjectDocument(Uri documentUri, bool reload)+(Uri _) => { }
   at async Task<ProjectDocument> MSBuildProjectTools.LanguageServer.Documents.Workspace.GetProjectDocument(Uri documentUri, bool reload)
   at async Task<Hover> MSBuildProjectTools.LanguageServer.Handlers.HoverHandler.OnHover(TextDocumentPositionParams parameters, CancellationToken cancellationToken)
   at async Task<Hover> MSBuildProjectTools.LanguageServer.Handlers.HoverHandler.OmniSharp.Extensions.JsonRpc.IRequestHandler<OmniSharp.Extensions.LanguageServer.Protocol.Models.TextDocumentPositionParams,OmniSharp.Extensions.LanguageServer.Protocol.Models.Hover>.Handle(?)

ZipPublishDir

<Project>
  <!-- https://learn.microsoft.com/en-us/visualstudio/msbuild/zipdirectory-task?view=vs-2022 -->
  <Target Name="ZipPublishDir" AfterTargets="Publish">
    <PropertyGroup>
      <RepoRoot>$([System.IO.Path]::GetDirectoryName($([MSBuild]::GetPathOfFileAbove('.gitignore', '$(MSBuildProjectDirectory)'))))</RepoRoot>
      <Destination>$(RepoRoot)/publish/$(AssemblyName).$(Version)$(PART_RuntimeIdentifier)</Destination>
      <Destination Condition="'$(RuntimeIdentifier)' != '' ">$(Destination).$(RuntimeIdentifier)</Destination>
    </PropertyGroup>

    <ZipDirectory
      SourceDirectory="$(PublishDir)"
      DestinationFile="$(Destination).zip"
      Overwrite="true" />
  </Target>
</Project>

error in project importing ZipPublishDir

[Error - 5:36:55 AM] Error loading MSBuild project '"c:\Repos\BinToss\GroupBox.Avalonia\GroupBox.Avalonia.Sample\GroupBox.Avalonia.Sample.csproj"'.
System.InvalidOperationException: Parent project does not have an MSBuild project.
   at bool MSBuildProjectTools.LanguageServer.Documents.SubProjectDocument.TryLoadMSBuildProject()
[Warn  - 5:36:55 AM] Reloaded project file "c:\Repos\BinToss\GroupBox.Avalonia\GroupBox.Avalonia.Sample\GroupBox.Avalonia.Sample.csproj" (XML is valid, but MSBuild project is not).

More specifically, Invalid static method invocation syntax error: "[MSBuild]::IsRunningFromVisualStudio()".

To fix this, we need to upgrade MSBuild packages to v15.5.x (see dotnet/msbuild#2775 for details).

Hi there.

Given <PackageReference Include="AngleSharp" Version="[0.9.11]" />, when I click on "NuGet Package: AngleSharp" link, I get error 404 because it includes square brackets in the URL.

Offending code here:

Needs latest (v5) NuGet.Client libraries and configuration for NuGet's ICredentialService.

Relates to tintoy/msbuild-project-tools-vscode#39 and #11.

3.1 is the LTS release and should be good until December 2022.

See official support policy:

https://dotnet.microsoft.com/platform/support/policy/dotnet-core

Add completion for well-known properties in project items.
Documentation

Missing

• GlobalPropertiesToRemove
• SetConfiguration
• SetPlatform
• SetTargetFramework
• SkipGetTargetFrameworkProperties

Because ProjectReference transforms to Reference also missing

• HintPath
• FusionName
• Aliases
• Private

Probably there's other properties that should be inspected

Currently TaksReflection is a separate standalone app, meaning that to get information from it it should be launched via Process class, its output is encoded (in this case as json) and the receiving side must properly decode it. I don't quite get why all this should even happen. We can just make TaskReflection just yet another library and get results directly from it without all this complication and overhead

Hello! What a lovely project this is, great work so far!

I noticed that you had files of completions, and wondered if you'd considered using the XSD provided with MSBuild as the source of truth for perhaps generating those files? The team tries to keep them up to date to help efforts like this.

Includes elements such as Import, ItemGroup, PropertyGroup, etc. Also includes well-known tasks.

Relates to #4

As of now, document symbols are reported as flat array, e.g. for this .csproj:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net7.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <LangVersion>preview</LangVersion>
    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-1.final" />
    <PackageReference Include="Microsoft.EntityFrameworkCore" Version="7.0.7" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="7.0.7" />
  </ItemGroup>

</Project>

... reported symbols look like this:

However, given the tree-like nature of xml and the fact, that LSP protocol supports tree-like symbol structure, it would make a lot more sence to report symbols as following:

Microsoft.NET.Sdk
-- PropertyGroup
---- OutputType
---- TargetFramework
---- ImplicitUsings
---- Nullable
---- LangVersion
---- AllowUnsafeBlocks
-- ItemGroup
---- PackageReference
---- PackageReference
---- PackageReference

Here not only tree structure is implemented, but also this tree represents document structure in a better way by including syntax elements like PropertyGroup or ItemGroup into it

There are 2 CI systems in place in this repo:

1. AppVeyor: https://github.com/tintoy/msbuild-project-tools-server/blob/master/.appveyor.yml
2. Azure pipelines: https://github.com/tintoy/msbuild-project-tools-server/blob/master/azure-pipelines.yml

i would say this isn't a good thing and it's better to move to 1 CI provider, probably azure one. @tintoy What do you think about this?

This line enables "documentation mode" for our source folder:

I am always seeing this error when looking at "older" .csproj files (those not using the new structure that includes <PackageReference>s.

Invalid static method invocation syntax: "[Microsoft.Build.Utilities.ToolLocationHelper]::GetPathToStandardLibraries($(TargetFrameworkIdentifier), $(TargetFrameworkVersion), $(TargetFrameworkProfile), $(PlatformTarget), $(TargetFrameworkRootPath), $(TargetFrameworkFallbackSearchPaths))". Microsoft.Build.Utilities.ToolLocationHelper.GetPathToStandardLibraries Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(a, b)).c:\repo\master\FileSystem\FileSystem.csproj(MSB4186)

Here is an example .csproj file that generates the issue:

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
  <PropertyGroup>
    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
    <Platform Condition=" '$(Platform)' == '' ">x86</Platform>
    <ProjectGuid>{636A7C3E-8D20-4696-A641-1F5180F0440C}</ProjectGuid>
    <OutputType>Library</OutputType>
    <AppDesignerFolder>Properties</AppDesignerFolder>
    <RootNamespace>FileSystem</RootNamespace>
    <AssemblyName>FileSystem</AssemblyName>
    <TargetFrameworkVersion>v4.5.1</TargetFrameworkVersion>
    <FileAlignment>512</FileAlignment>
    <TargetFrameworkProfile />
  </PropertyGroup>
  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
    <DebugSymbols>true</DebugSymbols>
    <OutputPath>bin\x86\Debug\</OutputPath>
    <DefineConstants>DEBUG;TRACE</DefineConstants>
    <DebugType>full</DebugType>
    <PlatformTarget>AnyCPU</PlatformTarget>
    <ErrorReport>prompt</ErrorReport>
    <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
  </PropertyGroup>
  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x86'">
    <OutputPath>bin\x86\Release\</OutputPath>
    <DefineConstants>TRACE</DefineConstants>
    <Optimize>true</Optimize>
    <DebugType>pdbonly</DebugType>
    <PlatformTarget>AnyCPU</PlatformTarget>
    <ErrorReport>prompt</ErrorReport>
    <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
  </PropertyGroup>
  <ItemGroup>
    <Reference Include="log4net, Version=2.0.8.0, Culture=neutral, PublicKeyToken=669e0ddf0bb1aa2a, processorArchitecture=MSIL">
      <HintPath>..\packages\log4net.2.0.8\lib\net45-full\log4net.dll</HintPath>
    </Reference>
    <Reference Include="PresentationCore" />
    <Reference Include="System" />
    <Reference Include="System.Configuration" />
    <Reference Include="System.Core" />
    <Reference Include="System.Drawing" />
    <Reference Include="System.Management" />
    <Reference Include="System.Web" />
    <Reference Include="System.Xml.Linq" />
    <Reference Include="System.Data.DataSetExtensions" />
    <Reference Include="Microsoft.CSharp" />
    <Reference Include="System.Data" />
    <Reference Include="System.Xml" />
    <Reference Include="WindowsBase" />
  </ItemGroup>
  <ItemGroup>
    <Compile Include="DirectoryUtilility.cs" />
    <Compile Include="FileSystemUtility.cs" />
    <Compile Include="NativeMethods.cs" />
    <Compile Include="GroupedProcessUtility.cs" />
    <Compile Include="ImageUtility.cs" />
    <Compile Include="PathConfigurations.cs" />
    <Compile Include="PathConfigurationsSection.cs" />
    <Compile Include="Properties\AssemblyInfo.cs" />
    <Compile Include="UncHelper.cs" />
    <Compile Include="VideoUtility.cs" />
  </ItemGroup>
  <ItemGroup>
    <None Include="packages.config" />
  </ItemGroup>
  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
</Project>

I haven't been able to identify the root cause (I'm unfamiliar with the ToolLocationHelper).

Am I missing an upgrade or dependency somewhere?

I have the following installed:

• Visual Studio 2017 Enterprise 15.9.7
• Visual Studio 2019 Enterprise 16.0.0 Preview 2.1
• Visual Studio Code 1.31.1

And this is the output for dotnet --info:

.NET Core SDK (reflecting any global.json):                                                                  
 Version:   2.2.103                                                                                          
 Commit:    8edbc2570a                                                                                       
                                                                                                             
Runtime Environment:                                                                                         
 OS Name:     Windows                                                                                        
 OS Version:  10.0.17763                                                                                     
 OS Platform: Windows                                                                                        
 RID:         win10-x64                                                                                      
 Base Path:   C:\Program Files\dotnet\sdk\2.2.103\                                                           
                                                                                                             
Host (useful for support):                                                                                   
  Version: 2.2.1                                                                                             
  Commit:  878dd11e62                                                                                        
                                                                                                             
.NET Core SDKs installed:                                                                                    
  1.1.11 [C:\Program Files\dotnet\sdk]                                                                       
  1.1.12 [C:\Program Files\dotnet\sdk]                                                                       
  2.1.4 [C:\Program Files\dotnet\sdk]                                                                        
  2.1.100 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.101 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.104 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.201 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.202 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.301 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.400 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.401 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.402 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.403 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.500 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.502 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.503 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.504 [C:\Program Files\dotnet\sdk]                                                                      
  2.1.600-preview-009426 [C:\Program Files\dotnet\sdk]                                                       
  2.1.600-preview-009472 [C:\Program Files\dotnet\sdk]                                                       
  2.2.102 [C:\Program Files\dotnet\sdk]                                                                      
  2.2.103 [C:\Program Files\dotnet\sdk]                                                                      
                                                                                                             
.NET Core runtimes installed:                                                                                
  Microsoft.AspNetCore.All 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.All 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.All 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.All 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.All 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.All 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.All 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.All 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]                   
  Microsoft.AspNetCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.AspNetCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.AspNetCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.AspNetCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.AspNetCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.AspNetCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.AspNetCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.AspNetCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]                   
  Microsoft.NETCore.App 1.0.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                        
  Microsoft.NETCore.App 1.0.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                        
  Microsoft.NETCore.App 1.1.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                        
  Microsoft.NETCore.App 1.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                        
  Microsoft.NETCore.App 2.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         
  Microsoft.NETCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]                         

The extension suddenly fails to start in my devcontainer. I'm running VSCode 1.70.2 and extension version 0.4.6

Starting MSBuild language service...
Failed to start the MSBuild language server.
Error: Command failed: "/usr/bin/dotnet" "/root/.vscode-server/extensions/tintoy.msbuild-project-tools-0.4.6/out/language-server/MSBuildProjectTools.LanguageServer.Host.dll" --probe
System.ArgumentException: '' is not a valid version string. (Parameter 'value')
   at NuGet.Versioning.SemanticVersion.Parse(String value)
   at MSBuildProjectTools.LanguageServer.Utilities.DotNetRuntimeInfo.ParseDotNetVersionOutput(TextReader dotnetVersionOutput) in D:\Development\github\tintoy\msbuild-project-tools-vscode\lib\server\src\LanguageServer.Common\Utilities\DotNetRuntimeInfo.cs:line 140
   at MSBuildProjectTools.LanguageServer.Utilities.DotNetRuntimeInfo.GetCurrent(String baseDirectory, ILogger logger) in D:\Development\github\tintoy\msbuild-project-tools-vscode\lib\server\src\LanguageServer.Common\Utilities\DotNetRuntimeInfo.cs:line 69
   at MSBuildProjectTools.LanguageServer.Utilities.MSBuildHelper.DiscoverMSBuildEngine(String baseDirectory, ILogger logger) in D:\Development\github\tintoy\msbuild-project-tools-vscode\lib\server\src\LanguageServer.Common\Utilities\MSBuildHelper.cs:line 96
   at MSBuildProjectTools.LanguageServer.Program.Main() in D:\Development\github\tintoy\msbuild-project-tools-vscode\lib\server\src\LanguageServer\Program.cs:line 39

I can retrieve the version in a terminal. Not sure how to properly debug this.

# dotnet --version
6.0.202

Dockerfile:

FROM ubuntu:21.04

RUN apt-get update \
	&& apt-get install -y curl git wget

RUN wget https://packages.microsoft.com/config/ubuntu/21.04/packages-microsoft-prod.deb -O packages-microsoft-prod.deb \
	&& dpkg -i packages-microsoft-prod.deb \
	&& rm packages-microsoft-prod.deb \
	&& apt-get update \
	&& apt-get install -y apt-transport-https \
	&& apt-get update \
	&& apt-get install -y dotnet-sdk-6.0

RUN curl -fsSL https://deb.nodesource.com/setup_17.x | bash - \
	&& apt-get install -y nodejs

RUN apt-get install -y postgresql

ARG USERNAME=vscode
ARG USER_UID=1000
ARG USER_GID=$USER_UID

# Create the user
RUN groupadd --gid $USER_GID $USERNAME \
	&& useradd --uid $USER_UID --gid $USER_GID -m $USERNAME \

devcontainer.json

{
	"build": {
		"dockerfile": "Dockerfile"
	},

	"postStartCommand": "service postgresql start",

	"settings": {
		"terminal.integrated.defaultProfile.linux": "bash"
	},

	"extensions": [
		"ckolkman.vscode-postgres",
		"editorconfig.editorconfig",
		"ms-dotnettools.csharp",
		"redhat.vscode-yaml",
		"tintoy.msbuild-project-tools"
	]
}

I managed to get a consistent repro of #52 (comment)

.csproj with this content is the only MSBuild-related file in the project