timonmasberg / address-formatter Goto Github PK

We should have a benchmark test to compare this with other address formatters

Currently, the test workflow fails due to missing dependencies. Locally, the command works.

go: github.com/cbroglie/[email protected] requires
	github.com/spf13/[email protected]: missing go.sum entry; to add it:
	go mod download github.com/spf13/cobra
Error: Process completed with exit code 1.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update module github.com/stretchr/testify to v1.9.0
• Update actions/checkout action to v4
• Update actions/setup-go action to v5
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Heya,

Looking though the code today I noticed that the calls to regexp.MustCompile() are inline.

Compiling the regular expressions represents a significant cost of a match, this is why the compile and match/replace calls are seperated in Go.

Moving the compile step up into the package scope (so they are run once on init) will result in a performance benefit, especially for functions like getRenderInput which are called often.