Git Product home page Git Product logo

animelabpip's Introduction

animelabpip's People

Contributors

timoliver avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

animelabpip's Issues

Sooo we're previewing PiP as a feature in AnimeLab.com

Hi Tim,

Thanks for your work on AnimeLabPiP.

We're proud to announce we're in a preview stage of PiP on AnimeLab.com. Currently the interface to enable PiP is invisible (but can be found if you hover your mouse over the top left of the controls ring.)

You can also enable/disable PiP using "p" on your keyboard.

Most of the code you wrote for the plugin doesn't work with the exception of the CSS modifications.

Let me know how you go with our implementation.

PS we stripped JWPlayer so ads and episodes now flow continuously without interrupting the PiP!

Continue PiP mode when moving to the next episode

When an episode in PiP finishes and the player moves to the next one, PiP automatically cancels itself.

From the looks of things, AnimeLab's integration of jwplayer will completely tear down the <video> tag and create a new one from scratch for the incoming episode.

You would assume it would be as simple as observing for the new <video> tag and then calling webkitSetPresentationMode() on that one, but for some reason, PiP won't activate when I tried that; it would just fail silently. I even checked the WebKit source code to see what could cause it to fail, but couldn't find anything.

In any case, the easiest solution for this would be for AnimeLab to re-use the same <video> player between episodes.

But if anyone else wants to try and get a 'PiP autorestore' feature working, please feel free to take a crack at it. :D

Disable fullscreen/PiP toggle buttons depending on which is active

At the moment, some strange behaviour occurs if PiP mode is enabled, and then you click the 'fullscreen' button, or vice versa.

Sometimes it works fine, sometimes the entire page dies and needs to be reloaded.

The easiest way to help avoid this issue would be to detect what state the video is playing (Whether fullscreen, or in PiP) and then disable the button for the other mode while it is active.

I don't know when I'll get more time to work on this, so a pull request would be greatly appreciated. :D

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.