Hijack links clicked from within JupyterLab about jupyterlab_iframe HOT 4 CLOSED

I think im going to close this. Its a good thought, but in the "real world" stuff has been way more difficult. As a simple example, id say 99% of jupyterlab users run without ssl, and 99% of the websites they access will run with ssl, meaning 99% of the links we want to hijack will pass through the jupyterlab_iframe proxy which make life super difficult. Same deal for websites not allowing iframe embedding (e.g. google.com), websites with cors issues, etc. The user experience would just be terrible.

from jupyterlab_iframe.

@ian-r-rose @blink1073 you guys have any thoughts about this?

from jupyterlab_iframe.

@timkpaine I think you should be able to create a new IRenderMimeRegistry for the application and provide your own IResolver and ILinkHandler options for it that override the default behavior. In particular, I think you would want to override the IResolver.isLocal function to tell the application to treat your iframe urls as local links, and the ILinkHandler.handleLink function to open your iframe urls with your extension.

from jupyterlab_iframe.

One better, we could make IResolver and ILinkHandler into tokens and have them be optional arguments here:

https://github.com/jupyterlab/jupyterlab/blob/2c57346d4f4d69a26afe79b15df919e3c8fe17dd/packages/rendermime-extension/src/index.ts#L30

Then this plugin could provide those without the user needing to disable the core plugin.

from jupyterlab_iframe.