missing ujson dependency about jupyterlab_iframe HOT 8 CLOSED

the point is if someone is installing one package, they dont necessarily want to install all my specific dependency versions. an older ujson may work perfectly well, im just too lazy to check, and somebody may have a better reason (e.g. I dont enforce pandas versions on my stuff, it changes every version).

from jupyterlab_iframe.

Requirements are here

from jupyterlab_iframe.

Some URLs forbid being displayed in iframe, as you've discovered. The easiest example is www.google.com

from jupyterlab_iframe.

I've never used the requirements.txt mechanism, but it seems that having such a file won't play a role when calling pip install jupyterlab_iframe. This general dependency on ujson should rather be listed in the install_requires in setup.py (cf. https://packaging.python.org/discussions/install-requires-vs-requirements/#install-requires).

from jupyterlab_iframe.

#11

from jupyterlab_iframe.

For dependencies to be installed when installing this module with pip they also need to be in the setup.py.

from jupyterlab_iframe.

this forces satisfaction of those by default (unless you do something like pip install --no-deps). I generally avoid this on all my packages because 1, I dont actually want to look for the minimum compatible version and 2, I dont want to set it to the current version in case people are using older version of packages.

from jupyterlab_iframe.

I'm not sure I follow. When installing a package with pip it does not check the requirements.txt for further dependencies.

As you are distributing this package I would recommend including your dependencies so that the instructions in the README work as expected.

This conversation may be superseded by #22 anyway if you're happy with that change.

from jupyterlab_iframe.