tim-ings / elvui_bettertalentframe Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 1.0 72 KB

Improvements to the World of Warcraft talents interface

Home Page: https://www.curseforge.com/wow/addons/elvui_bettertalentframe

License: GNU General Public License v3.0

Lua 100.00%

wow-addon

elvui_bettertalentframe's People

Contributors

Stargazers

Watchers

Forkers

chr2sn0

elvui_bettertalentframe's Issues

Dropdown Menu

The dropdownmenu is overlapping the "apply" button

Spec tab highlighting is buggy/inconsistent

Make sure to test druid/dh

Drop everything besides talent rework and rename project accordingly

Select last applied talent profile in dropdown

When opening the talent frame, select the last applied talent profile. Will need to save last applied profile to saved variables

Unknown talent placeholders do not cover locked talent rows

3x ...lvUI_BetterTalentFrame\modules/TalentFrameRework.lua:147: attempt to index field 'bg' (a nil value)
[string "@ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua"]:147: in function UpdateTalentsTab' [string "@ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua"]:183: in function <...lvUI_BetterTalentFrame\modules/TalentFrameRework.lua:180> [string "=(tail call)"]: ? [string "=[C]"]: in function PlayerTalentFrame_Update'
[string "@Blizzard_TalentUI\Blizzard_TalentUI.lua"]:429: in function PlayerTalentFrame_Refresh' [string "@Blizzard_TalentUI\Blizzard_TalentUI.lua"]:1018: in function PlayerSpecTab_OnClick'
[string "@Blizzard_TalentUI\Blizzard_TalentUI.lua"]:270: in function <...rfaceBlizzard_TalentUI\Blizzard_TalentUI.lua:257>
[string "=[C]"]: ?
[string "=[C]"]: in function Show' [string "@FrameXML\UIParent.lua"]:2893: in function SetUIPanel'
[string "@FrameXML\UIParent.lua"]:2738: in function ShowUIPanel' [string "@FrameXML\UIParent.lua"]:2606: in function <FrameXML\UIParent.lua:2602> [string "=[C]"]: in function SetAttribute'
[string "@FrameXML\UIParent.lua"]:3457: in function ShowUIPanel' [string "@Blizzard_TalentUI\Blizzard_TalentUI.lua"]:117: in function PlayerTalentFrame_Toggle'
[string "@FrameXML\UIParent.lua"]:851: in function <FrameXML\UIParent.lua:844>
[string "=[C]"]: in function `ToggleTalentFrame'
[string "TOGGLETALENTS"]:1: in function <[string "TOGGLETALENTS"]:1>

Locals:
self =

{
PLAYER_LOGOUT = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:252
SetDefaultModuleLibraries = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:367
UpdateActivateButton = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:82
Enable = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:294
NewModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:235
EnableModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:332
modules =

{
}
GetModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:210
IterateEmbeds = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:442
SecureHookScript = defined @ace3\AceHook-3.0\AceHook-3.0.lua:410
defaultModuleLibraries =

{
}
RawHookScript = defined @ace3\AceHook-3.0\AceHook-3.0.lua:395
PLAYER_ENTERING_WORLD = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:256
UpdateSpecTab = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:92
selectedSpec = 1
PLAYER_SPECIALIZATION_CHANGED = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:248
GetName = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:279
UpdateTalentCache = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:53
baseName = "ElvUI_BetterTalentFrame"
hasRunOneTime = true
name = "ElvUI_BetterTalentsFrame_TalentFrameRework"
Initialize = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:281
IsEnabled = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:451
orderedModules =

{
}
SecureHook = defined @ace3\AceHook-3.0\AceHook-3.0.lua:336
DisableModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:350
InitActivateButton = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:188
GetTalentButtonTexture = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:48
UpdateTalentsTab = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:103
Unhook = defined @ace3\AceHook-3.0\AceHook-3.0.lua:418
RegisterMessage = defined @LibSharedMedia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
HookScript = defined @ace3\AceHook-3.0\AceHook-3.0.lua:366
Update = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:180
GetTalentButtonFrame = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:43
IsHooked = defined @ace3\AceHook-3.0\AceHook-3.0.lua:493
UnregisterMessage = defined @LibSharedMedia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
VerifyDB = defined @ElvUI_BetterTalentFrame\modules/TalentFrameRework.lua:21
IsModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:217
defaultModuleState = true
SetDefaultModuleState = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:387
UnregisterAllEvents = defined @LibSharedMedia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
SendMessage = defined @LibSharedMedia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:59
SetEnabledState = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:424
Hook = <f

Update for 8.2.5

Make talents update when new spec is selected

Disallows using Korthia Item Upgrade

If the addon is enabled, item upgrades won't work in Korthia (Seeker's Respite).

Error when viewing spec that has no talent data

11x ElvUI_BetterTalentFrame\TalentFrameRework.lua:100: Usage: GameTooltip:SetTalent(talentID[, isInspect[, groupIndex]])
[C]: in function `SetTalent'
ElvUI_BetterTalentFrame\TalentFrameRework.lua:100: in function <ElvUI_BetterTalentFrame\TalentFrameRework.lua:98>

Locals:
(*temporary) = GameTooltip {
 0 = <userdata>
 SetCurrencyByID = <function> defined @AllTheThings\AllTheThings.lua:2713
 SetHyperlink = <function> defined =[C]:-1
 SetGuildBankItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetVoidItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetVoidDepositItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetVoidWithdrawalItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 template = "Transparent"
 comparing = false
 TopOverlay = <unnamed> {
 }
 SetUnitDebuff = <function> defined =[C]:-1
 SetLFGDungeonReward = <function> defined @AllTheThings\AllTheThings.lua:2750
 SetQuestItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetCurrencyToken = <function> defined @AllTheThings\AllTheThings.lua:2724
 numMoneyFrames = 2
 SetRecipeResultItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetRecipeReagentItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetBuybackItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 shoppingTooltips = <table> {
 }
 SetMerchantItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetQuestLogItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 Hide = <function> defined =[C]:-1
 SetTradeTargetItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetUnitBuff = <function> defined =[C]:-1
 SetTradePlayerItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetLFGDungeonShortageReward = <function> defined @AllTheThings\AllTheThings.lua:2767
 SetSendMailItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 hasMoney = 1
 updateTooltip = 0.14699999690056
 SetInventoryItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetMerchantCostItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetInboxItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetLootRollItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetUnitAura = <function> defined =[C]:-1
 ignoreUpdates = true
 SetAuctionSellItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetBagItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 needsReset = true
 BottomOverlay = <unnamed> {
 }
 SetLootItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
 SetAuctionItem = <function> defined @TradeSkillMaster\Core\Lib\TooltipLib.lua:93
}
(*temporary) = nil

Make spec tab update when new spec is selected

Activate spec button is disabled on the spec bottom tab

Lua Error 2

Error:

3x ...s\ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:159: attempt to index global 'talentID' (a nil value)
[string "@ElvUI_BetterTalentFrame\modules/TalentProfiles.lua"]:159: in function `ActivateProfile'
[string "@ElvUI_BetterTalentFrame\modules/TalentProfiles.lua"]:308: in function <...s\ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:301>

Locals:
self =

{
GetPvpTalentInfos = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:46
SetDefaultModuleLibraries = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:367
Enable = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:294
NewModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:235
EnableModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:332
modules =

{
}
GetModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:210
IterateEmbeds = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:442
SecureHookScript = defined @ElvUI\Libraries\Ace3\AceHook-3.0\AceHook-3.0.lua:410
defaultModuleLibraries =

{
}
TryDisplay = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:352
playerClass = "MAGE"
SaveProfile = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:173
RawHookScript = defined @ElvUI\Libraries\Ace3\AceHook-3.0\AceHook-3.0.lua:395
baseName = "ElvUI_BetterTalentFrame"
BuildFrame = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:241
UnregisterAllEvents = defined @ElvUI\Libraries\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
PLAYER_SPECIALIZATION_CHANGED = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:372
GetName = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:279
PLAYER_ENTERING_WORLD = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:376
ARWIC_BTF_SPEC_SELECTION_CHANGED = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:368
hasRunOneTime = true
name = "ElvUI_BetterTalentsFrame_TalentProfiles"
Initialize = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:390
IsEnabled = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:451
orderedModules =

{
}
ActivateProfile = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:140
DisableModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:350
GetProfile = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:70
RemoveProfile = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:85
InsertProfile = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:80
GetTalentInfos = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:24
RegisterMessage = defined @ElvUI\Libraries\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
HookScript = defined @ElvUI\Libraries\Ace3\AceHook-3.0\AceHook-3.0.lua:366
Print = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:19
StaticPopupShow_Add = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:135
IsHooked = defined @ElvUI\Libraries\Ace3\AceHook-3.0\AceHook-3.0.lua:493
VerifyDB = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:53
GetAllProfiles = defined @ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:75
IsModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:217
defaultModuleState = true
SetDefaultModuleState = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:387
StaticPopupShow_Remove = defined @ElvUI_BetterTalentFrame

And No2:

1x ...s\ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:159: Usage: LearnTalent(talentID)
[string "=[C]"]: in function LearnPvpTalent' [string "@ElvUI_BetterTalentFrame\modules/TalentProfiles.lua"]:159: in function ActivateProfile'
[string "@ElvUI_BetterTalentFrame\modules/TalentProfiles.lua"]:308: in function <...s\ElvUI_BetterTalentFrame\modules/TalentProfiles.lua:301>

Locals:
(*temporary) = 3586
(*temporary) = 1

Support for BFA honour talents

ADDON_ACTION_BLOCKED

1x [ADDON_ACTION_BLOCKED] AddOn 'ElvUI_BetterTalentFrame' hat versucht die geschützte Funktion 'CompactRaidFrame1:SetAttribute()' aufzurufen.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function SetAttribute' [string "@FrameXML\CompactUnitFrame.lua"]:363: in function CompactUnitFrame_UpdateInVehicle'
[string "@FrameXML\CompactUnitFrame.lua"]:306: in function `CompactUnitFrame_UpdateAll'
[string "@FrameXML\CompactUnitFrame.lua"]:155: in function <FrameXML\CompactUnitFrame.lua:57>

Using with ElvI 12.16. & Shadow&Light 4.17

Attempting to select a new spec tab after logging in causing error (but /reload is fine)

Message: Interface\AddOns\ArwicUIRework\ArwicUIRework.lua:121: attempt to concatenate upvalue 'selectedSpec' (a nil value)
Time: 04/09/17 05:34:08
Count: 1
Stack: [C]: ?
Interface\AddOns\ArwicUIRework\ArwicUIRework.lua:121: in function <Interface\AddOns\ArwicUIRework\ArwicUIRework.lua:119>

Locals:

Make honour talents update when new spec is selected

Possible copy paste job.
Cache honour talents per spec.
Update on tab change.

Remember there is 1 less honour talent row.