dco's People
dco's Issues
Unexpected input 'token', valid inputs are ['commits']
When I use the suggested YAML to configure this I get:
Unexpected input 'token', valid inputs are ['commits']
If I replace:
with:
token: ${{ secrets.GITHUB_TOKEN }}
with instead:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Then I get:
Unexpected end of JSON input
Improve suggestion on what to do if `--signoff` is missing
Currently the user "only" receives
Lines 9 to 12 in f2279e6
when not all commits are signed-off.
That is good information on what the user should do the next time when contributing to the repo. But it doesn't help much to fix the current PR. Since I am only/still a beginner at git I have no good suggestion myself, but had seen
git remote update
git rebase --exec 'git commit --amend --no-edit -n -s' @{upstream}
in this comment. Assuming that this advice is useful, would it be worth to adapt helper.js
accordingly?
Add release/build
Currently the project has node_modules checked in. There should be a build process that produces a release that can be used by projects that npm installs, remove node_modules from the tree.
Needs tests
Let's add some tests!
Make updated releases
First, thank you for your work to create these useful actions!
I wonder if it would be possible to make updated releases for your tim-actions/get-pr-commits
, tim-actions/dco
, and tim-actions/wip-check
GitHub Actions? I prefer to stick to released versions to avoid possible breakages on master (per GitHub guidelines), but would like to get the latest commits (version bumps and such).
Feature: Check (name OR email) rather than (name AND email)
Since DCO check lives in automated processes, it is especially painful when it fails in a situation that it shouldn't have. This can happen when someone changes their github name or their github email. To allow for that change to happen more smoothly, it could be better to check only one or the other. I think it still ticks the box that DCO is trying to tick, but it ticks it in a nicer way that allows for these kinds of changes without triggering unnecessary integration failures.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.