tillkuhn / angkor Goto Github PK

Currently we receive
org.apache.tomcat.util.http.fileupload.impl.FileSizeLimitExceededException: The field file exceeds its maximum permitted size of 1048576 bytes.

According to https://spring.io/guides/gs/uploading-files/ and https://stackoverflow.com/questions/37540028/how-to-set-the-max-size-of-upload-file we can tune it like this

spring.servlet.multipart.max-file-size=10MB
spring.servlet.multipart.max-request-size=10MB

apparently this does not catch all domains in nginx.conf

 # match is case insensitive
    if ($host ~* ${SERVER_NAME_PATTERN}) {
      return 301 https://$host$request_uri;
    } # managed by Certbot
    listen       80 ;

See https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates#package-ecosystem

Add badge? dependabot/dependabot-core#1912

• Improve File Display (icon + tab), truncat long filenames, extend column
• Hide native "Durchsuchen" Button button with styled version, trigger upload on select, see angular-image-upload-made-easy
• Allow overwrite name for uploaded files (currently only for URL Pull), see also truncate-string-with-ellipsis
• Support "Set as primary image" link action per file, so managed file becomes the "Title" image

Source: https://en.wikipedia.org/wiki/List_of_adjectival_and_demonymic_forms_for_countries_and_nations
Converter: https://wikitable2csv.ggor.de/
select 'UPDATE AREA SET adjectival = ''' ||area.adjectival ||''' WHERE CODE='''||code ||''';'
from area where adjectival is not null

https://www.npmjs.com/package/ngx-moment

npm install --save moment ngx-moment

Feature
Currently imagine sends a 307 to the actual presigned URL, which is regenerated every time (i.e. also on browser refresh) even when the URL is still valid, i.e. not expired. This creates lots of HTTP request especially ob overview pages that uses presigned image URL for avatar items

URL References

• https://stackoverflow.com/questions/53205295/how-to-make-browser-cache-identical-image-with-different-aws-s3-presigned-url
• https://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html

warning on deploy task
WARNING! Using --password via the CLI is insecure. Use --password-stdin.

see provide-a-password-using-stdin
cat ~/my_password.txt | docker login --username foo --password-stdin

Feature
See Commits to PR #416

URL References

• https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide
• https://www.jetbrains.com/idea/guide/tutorials/migrating-javax-jakarta/use-migration-tool/
• Spring Boot 3.0 trailing slash alternative no longer works use /tree instead of /tree/ see discussion spring-projects/spring-framework#28552
• Greenmail Jakarta Mail issues issues greenmail-mail-test/greenmail#513
• wiremock javax.servlet issues https://groups.google.com/g/wiremock-user/c/knTaDyBY70Q
• modernize security filter chain see https://spring.io/blog/2022/02/21/spring-security-without-the-websecurityconfigureradapter

Feature
Map should show centers of countries so dishes can deeplink into a MapLocation based on its (iso-)code

URL References

• Mapbox GL Show Cluster with Counter and different colors and Geo Locations
• iso country codes with coordinates
• ngx drag-a-point component
• Kitten Placeholder Images e.g. https://placekitten.com/200/300
• custom marker icons background image css
• icon cats in ngx mapbox (remove slash from images to avoid http redirect

// add markers to map
geojson.features.forEach(function (marker) {
// create a DOM element for the marker
var el = document.createElement('div');
el.className = 'marker';
el.style.backgroundImage =
'url(https://placekitten.com/g/' +
marker.properties.iconSize.join('/') +
'/)';
el.style.width = marker.properties.iconSize[0] + 'px';
el.style.height = marker.properties.iconSize[1] + 'px';
el.style.backgroundSize = '100%';

Support increasingly common https://en.wikipedia.org/wiki/WebP image Format for resizing, or at least do not append ?large suffix in preview urls (since it will point to a none existing location)

• disintegration/imaging#97 (comment) check out github.com/chai2010/webp

Feature
It's about time

URL References

• https://stevenmortimer.com/5-steps-to-change-github-default-branch-from-master-to-main/

• git branch -m master main
• git push -u origin main
• git branch -a
• • main
• (...)
• : https://docs.github.com/en/github/administering-a-repository/setting-the-default-branch.
• Settings -> Branches -> Default Branch -> Switch to another branch
• Also adapt Branch protection rules
• .github/workflows/*.yml change rules from master to main

Last todo:

git push origin --delete master

Is your feature request related to a problem? Please describe.
we need to habe protected areas in the webapp that enforce authentication

Describe the solution you'd like
we'd like to integrate with AWS Cognito and support social identities

Describe alternatives you've considered
using basic auth in nginx as a starter

Additional context
check out sso-spring-security-oauth2

kotlin: /config/DateTimeFormatConfiguration.kt

https://github.com/jhipster/jhipster-sample-app-ng2/blob/master/src/main/java/io/github/jhipster/sample/config/DateTimeFormatConfiguration.java

should make jsonformat annotations obsolete for dates

Better now than later

ALTER TABLE app_user alter id type uuid USING id::uuid

https://stackoverflow.com/a/51052624/4292075

reaplce uuid for system user with 00000000-0000-0000-0000-000000000001

• https://stackoverflow.com/questions/49950249/cognito-logout-does-not-work-as-documented
• https://docs.aws.amazon.com/cognito/latest/developerguide/logout-endpoint.html
• https://bobtomlin-70659.medium.com/signing-out-of-an-alb-web-application-e464723ac6d8
• Logout handling in jhipster https://github.com/tillkuhn/letsgo2/blob/master/src/main/kotlin/net/timafe/letsgo2/web/rest/LogoutResource.kt

Feature
When navigating from the map to the details of a place, we should provide a <- navigate back action (probably top right corner) to fly back to the back to the place's coordinates on the map. We already have this link in the coordinates, but it's a bit hard to reach

URL References

• https://docs.mapbox.com/mapbox-gl-js/example/flyto/

Project Management

• @schwatzbaer

Describe the bug
-15.2646156,-145.1163131.
error 500

Additional context
Add any other context about the problem here.

023-02-01 20:17:49Z DEBUG n.t.angkor.service.PlaceService : AreaCode pf or GeoAddress null empty, lookup geoPoint for [-145.1163131, -15.2646156]
2023-02-01 20:17:49Z  INFO n.t.angkor.service.GeoService   : Downloading geo info for Coordinates(lon=-145.1163131, lat=-15.2646156) from https://nominatim.openstreetmap.org status=200
2023-02-01 20:17:49Z  INFO n.t.angkor.service.GeoService   : Json: {"error":"Unable to geocode"}
2023-02-01 20:17:49Z ERROR .c.c.C.[.[.[.[dispatcherServlet]: Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed: org.json.JSONException: JSONObject["address"] not found.] with root cause

org.json.JSONException: JSONObject["address"] not found.
	at org.json.JSONObject.get(JSONObject.java:471) ~[json-20160212.jar!/:na]
	at org.json.JSONObject.getJSONObject(JSONObject.java:636) ~[json-20160212.jar!/:na]
	at net.timafe.angkor.service.GeoService.mapToOSMPlaceSummary(GeoService.kt:101) ~[classes!/:na]
	at net.timafe.angkor.service.GeoService.reverseLookup(GeoService.kt:94) ~[classes!/:na]
	at net.timafe.angkor.service.GeoService.reverseLookupWithRateLimit(GeoService.kt:60) ~[classes!/:na]
	at net.timafe.angkor.service.AbstractLocationService.save(AbstractLocationService.kt:24) ~[classes!/:na]
	at net.timafe.angkor.service.PlaceService.save(PlaceService.kt:40) ~[classes!/:na]

Feature
stop using console.log

URL References

• https://onthecode.co.uk/angular-logging-made-easy-with-ngx-logger/

Feature
simple angular wrapper around the embed YouTube player API.

URL References

• https://github.com/angular/components/tree/master/src/youtube-player#readme
• https://dev.to/phenomnominal/the-new-angular-youtube-player-component-2cn6
• https://stackblitz.com/edit/youtube-player-demo?file=src/app/cdk-clipboard-overview-example.ts (good)

check Laab, should derive extension from mimetype if not present in filename / URL

2020/12/20 22:30:11 Convert /tmp/Laab-Tofu temporary thumbnail /tmp/Laab-Tofu_150 qual 80
2020/12/20 22:30:11 ERROR failed to create resize image /tmp/Laab-Tofu_150: imaging: unsupported image format, skipping

Also suffixes after the url cause issues e.g.
https://www.bla.com/kritharaki-tomaten-sauce.jpg?v=1-0, maybe RawQuery in pkg/net/url/ helps

a%2F960x960%2F00%kritharaki-in-tomaten-sauce.jpg%3Fv%3D1-0&Size=102485
2020/12/21 18:57:50 ERROR: cannot upload  imagine/dishes/9d46fc74-ac3d-48f2-a352-60400fde35de/kritharaki-in-tomaten-sauce.jpg?v=1-0: InvalidTag: The TagValue you have provided is invalid

Feature
We already have it in the model, so it's time to display some nice stars

URL References

• https://github.com/BioPhoton/angular-star-rating

• Unauth access should only display public notes in overview
• Authscope should be editable per note

Feature
Places / links which point to Kommoot tours could support a preview of the tour and/or auto-download a preview of the tour as image.

<a href="https://www.komoot.de/tour/281323266?ref=wtd" target="_blank" rel="nofollow noopener noreferrer">
<img src="https://www.komoot.de/tour/281323266/embed?image=1&hm=true&profile=1&width=640&height=680" width="640" height="680"/>
</a>

URL References

• https://www.komoot.de/tour/275482510
• https://www.komoot.de/tour/275482510/embed?image=1&hm=true&profile=1&width=640&height=680

Sample Flow

• Request https://www.komoot.de/tour/{id}/embed?image=1&profile=1
• If it has not been created yet, wait a couple of seconds
• Get 302 redirect to https://s3-eu-west-1.amazonaws.com/screenshots-eu-komoot/tour_embed_screenshots/{some-uuid}.png
• Repeated calls return same s3 url ... at least for some time
• Public Tour Download: https://www.komoot.de/api/v007/tours/.gpx
• API https://static.komoot.de/doc/external-api/v007/index.html#General-information

All Views with Notes area: Support markdown (https://jfcere.github.io/ngx-markdown/get-started) or at least linkify

• https://www.xspdf.com/resolution/52088848.html, https://stackoverflow.com/questions/39276617/angular2-way-of-converting-plain-text-to-url-anchor-links
• https://github.com/dzonatan/ngx-linky/blob/master/projects/ngx-linky/src/lib/linky.pipe.ts which uses https://www.npmjs.com/package/autolinker

currently only for JPEG, but is supported according to https://github.com/disintegration/imaging#example-code

Cognito App Cient now supports configuration of access and refresh token duration, see https://stackoverflow.com/a/63533330/4292075

Apparently it's not yet fully supported by tf, but there's a PR:
hashicorp/terraform-provider-aws#14919

Feature
check out world-flags-sprite as potential replacement (single

<ul class="f32">
  <li class="flag ar">Argentina</li>
  <li class="flag au">Australia</li>
  <li class="flag at">Austria</li>
  ...
</ul>

URL References

• https://github.com/lafeber/world-flags-sprite
• //github.com/downloads/lafeber/world-flags-sprite/flags32.css"
• https://github.com/lafeber/world-flags-sprite/tree/master/images

Feature

• https://500px.com//rss
• https://xxxx.wordpress.com/feed/

Feature
Places and Dish details should provice the possibility to add a particular item to the User's (to be introduced) List of Favorites.
Storage: Either server side, or use ngx-web-storage

URL References

• https://stackblitz.com/edit/form-favorite-button

@schwatzbaer fyi

URL References

• Lady Leet (from RxJS demo with Ben) https://github.com/ladyleet/rxjs-test/blob/master/src/app/speech.service.ts
• Module ready https://github.com/kamiazya/ngx-speech-recognition

Mission

See changes #419

Describe the bug

Run distributhor/workflow-webhook@v3
(....)
"/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/angkor/angkor":"/github/workspace" ghcr.io/distributhor/workflow-webhook-container:v3.0.2
Error: Unable to process file command 'output' successfully.
Error: Invalid format '  "result" : true'

new tags show in UI, but are not persisted

Resources

• https://github.com/Flaconi/terraform-aws-iam-ses-user/blob/master/variables.tf
• https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/ses-example-send-email.html
• https://github.com/Flaconi/terraform-aws-iam-ses-user
• https://docs.aws.amazon.com/ses/latest/DeveloperGuide/send-email-smtp-client-command-line.html
• https://console.aws.amazon.com/support/contacts?#/rdns-limits (remove limits)
• https://serverfault.com/questions/462664/remove-via-from-emails-sent-to-gmail-from-amazon-ses

Solution Design:

separate go service should poll notes with pending reminder dates via rest from API, using API keys (as it's server side only), then deliver to the note's owner via AWS SES (simple mail service). Resources for SMTP Auth to be created via Terraform

Icons

• bike trip
• restaurant

Feature
Video Pois should show the youtube preview image(s) which have predictable URLs

URL References
https://stackoverflow.com/a/2068371

Example: https://img.youtube.com/vi//maxresdefault.jpg

and 0.jpg -> 4.jpg
The first one in the list is a full size image and others are thumbnail images. The default thumbnail image (i.e., one of 1.jpg, 2.jpg, 3.jpg) is:

• https://github.com/joanllenas/ngx-date-fns
• https://medium.com/javascript-in-plain-english/removing-moment-js-locales-from-your-angular-app-js-bundles-2abfec434109
• https://terodox.tech/migrating-away-from-momentjs-part1/#:~:text=MomentJs%20recently%20announced%20that%20the,core%20library%20at%20my%20company.
• https://blog.date-fns.org/post/we-cut-date-fns-v2-minimal-build-size-down-to-300-bytes-and-now-its-the-smallest-date-library-18f2nvh2z0yal/
• https://dev.to/imben1109/date-handling-in-angular-application-part-2-angular-http-client-and-ngx-datepicker-3fna

Feature

https://www.cloudkarafka.com/ is great and reliable, but Confluent's Terraform Provider is equally tempting, let's set it up in parallel using a Basic cluster with zero or minimal costs

URL References

• https://registry.terraform.io/providers/confluentinc/confluent/latest/docs/guides/sample-project
• https://docs.confluent.io/cloud/current/billing/ccloud-aws-payg.html

• Support [skip ci] out of box with github actions
• Workaround: https://github.community/t/github-actions-does-not-respect-skip-ci/17325
• Marketplace: https://github.com/marketplace/actions/ci-skip-action

name: my CI github action

on:
  push:
    branches:
      - master

jobs:
  build:
    if: "!contains(github.event.head_commit.message, 'skip ci')"
    runs-on: ubuntu-latest

• https://stackblitz.com/edit/ngx-web-storage

• https://stackoverflow.com/questions/50675401/angular-5-redirect-the-previous-page-after-sign-in

• https://www.baeldung.com/spring-security-5-oauth2-login#2-custom-authentication-success-and-failure-behavior

• https://stackoverflow.com/questions/20349594/adding-additional-details-to-principal-object-stored-in-spring-security-context

Feature
Apps that access user data must provide a way for users to request that their data be deleted. Your app can satisfy this requirement in one of two ways:

URL References

• https://developers.facebook.com/docs/development/create-an-app/app-dashboard/data-deletion-callback
• https://docs.aws.amazon.com/ses/latest/dg/send-using-smtp-programmatically.html
• https://www.baeldung.com/java-email
• https://www.baeldung.com/spring-email
• https://memorynotfound.com/spring-mail-integration-testing-junit-greenmail-example/
• http://dolszewski.com/spring/sending-html-mail-with-spring-boot-and-thymeleaf/ also with greenmail example code

Feature
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#ignore

Example

# Use `ignore` to specify dependencies that should not be updated

version: 2
updates:
  - package-ecosystem: "npm"
    directory: "/"
    schedule:
      interval: "weekly"
    ignore:
      - dependency-name: "express"
        # For Express, ignore all updates for version 4 and 5
        versions: ["4.x", "5.x"]
        # For Lodash, ignore all updates
      - dependency-name: "lodash"
        # For AWS SDK, ignore all patch updates
      - dependency-name: "aws-sdk"
        update-types: ["version-update:semver-patch"]

https://www.archunit.org/userguide/html/000_Index.html

setup nightly or weekly job as described in renewing-certificates

make use of hooks to temporarily "free" port 80 from nginx (we used standalone mode for obtaining) e.g.

certbot renew --pre-hook "docker-compose stop angkor-ui" --post-hook "docker-compose start angkor-ui"

github.com/hadolint/hadolint
Maybe use existing marketplace action, or do it yourself e.g.

$curl -sS -L https://github.com/hadolint/hadolint/releases/download/v1.19.0/hadolint-Linux-x86_64 \
--output /tmp/hadolint && chmod u+x /tmp/hadolint

$ /tmp/hadolint Dockerfile && echo "Dockerfile OK"
Dockerfile:27 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments

Sample output:

Dockerfile:27 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments

Feature
Update from 0.x to 1.x (tried once, but apparently code changes are required)

URL References

• https://github.com/TNG/ArchUnit/releases/tag/v1.0.0-rc1

2015
https://stackoverflow.com/a/15952652/4292075

JSON itself does not specify how dates should be represented, but JavaScript does.

You should use the format emitted by Date's toJSON method:

2012-04-23T18:25:43.511Z

Here's why:

It's human readable but also succinct
It sorts correctly
It includes fractional seconds, which can help re-establish chronology
It conforms to ISO 8601
ISO 8601 has been well-established internationally for more than a decade
ISO 8601 is endorsed by W3C, RFC3339, and XKCD