tikivn / android-template Goto Github PK

View Code? Open in Web Editor NEW

17.0 17.0 8.0 7.38 MB

Template for android development at Tiki

License: Apache License 2.0

Shell 2.43% Java 88.15% JavaScript 1.83% Kotlin 7.60%

android dagger2 dependency-injection mvp mvp-android mvp-architecture rxjava2

android-template's People

Contributors

Stargazers

Watchers

Forkers

hoangduchuu cuongloveit alg520 sabufung nezne1k4 ris269 nguyenthe0107 maxv-lttvinh

android-template's Issues

CollectionView sample crashes

Logcat

 Process: vn.tiki.sample.dev, PID: 6357
                                                                  java.lang.IllegalArgumentException: unknown class java.lang.String
                                                                      at viewholders.TypeFactoryImpl.typeOf(TypeFactoryImpl.java:34)
                                                                      at vn.tiki.noadapter2.OnlyAdapter.getItemViewType(OnlyAdapter.java:103)
                                                                      at android.support.v7.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:5657)
                                                                      at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:5589)
                                                                      at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:5585)
                                                                      at android.support.v7.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2231)
                                                                      at android.support.v7.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1558)
                                                                      at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1518)
                                                                      at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:610)
                                                                      at android.support.v7.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:3719)
                                                                      at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3436)
                                                                      at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3988)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.support.v4.widget.SwipeRefreshLayout.onLayout(SwipeRefreshLayout.java:611)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
                                                                      at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.support.constraint.ConstraintLayout.onLayout(ConstraintLayout.java:1197)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
                                                                      at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.support.v7.widget.ActionBarOverlayLayout.onLayout(ActionBarOverlayLayout.java:443)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
                                                                      at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1741)
                                                                      at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1585)
                                                                      at android.widget.LinearLayout.onLayout(LinearLayout.java:1494)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
                                                                      at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
                                                                      at com.android.internal.policy.DecorView.onLayout(DecorView.java:726)
                                                                      at android.view.View.layout(View.java:17637)
                                                                      at android.view.ViewGroup.layout(ViewGroup.java:5575)
                                                                      at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2346)
                                                                      at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2068)
                                                                      at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1254)
                                                                      at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6337)
                                                                      at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874)
                                                                      at android.view.Choreographer.doCallbacks(Choreographer.java:686)
                                                                      at android.view.Choreographer.doFrame(Choreographer.java:621)
                                                                      at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860)
                                                                      at android.os.Handler.handleCallback(Handler.java:751)
                                                                      at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                      at android.os.Looper.loop(Looper.java:154)
                                                                      at android.app.ActivityThread.main(ActivityThread.java:6119)
                                                                      at java.lang.reflect.Method.invoke(Native Method)
11-03 23:08:53.385 6357-6357/vn.tiki.sample.dev E/AndroidRuntime:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
                                                                      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

Maintenance

Hi tiki team,

Is this project in active development and used in production? if so, I'd love to join you guys

Overview feedback

Overall, it looks really great. However, there are some issues we could improve on

Better way to dispose .

if (disposable != null) {
      disposable.dispose();
 }

is repeated all over the place.
Using https://github.com/uber/AutoDispose to reduce.

LoginPresenter. java
A lot of bindings between Views and Presenter happening in the constructor looks like MVVM on iOS. It seems pretty hard to test!!!! Am I right? Need more unit test examples.
MainActivity.java line:39
I don't know which activity will be started. It's very subtle. I got it after navigating the project. Need a better name for this like Intent.makeInjectionActivity().name()...
Could you compare your dagger to google-architecture project? My only concern on your dagger is that you're using reflection in onCreate. it may slow down start-up process.
I really like CollectionView. It solves most of LCE problem.
I still prefer MVVM, Redux, MVI to MVP. How do you survive config change in MVP because the the view is detachedonDestroy? How about state management? for example if the button is liked, press to dislike and vice versa?
Navigation? References iOS:
https://medium.com/@giovannyorozco24/mvvm-and-coordinator-pattern-together-8920fc0f1f55
https://github.com/AndreyPanov/ApplicationCoordinator
https://will.townsend.io/2016/an-ios-coordinator-pattern

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.