tighten / tlint Goto Github PK

Tighten linter for Laravel conventions.

License: MIT License

PHP 100.00%

laravel php linter conventions code-style

tlint's Issues

Not catching leading slash imports (factory files)

$factory->define(App\SavedVehicle::class, function (Faker\Generator $faker) {
    return [
        'user_id' => factory(App\User::class),
        'version_id' => factory(\App\JATO\Version::class),
    ];
});

Document PhpStorm Plugin

remove dependencies

No need to be dependant on these:

symfony/console
symfony/proces

Enable `UseConfigOverEnv` + ensure no false positives from actual config files

Undefined method from NoParensEmptyInstantiations lint

Using PHP 7.1.11

If you need any other info, let me know. This is a great package, will look to send you some PRs soon!

PHP Fatal error:  Uncaught Error: Call to undefined method PhpParser\Node\Expr\Variable::toString() in /Users/macbook/.composer/vendor/loganhenson/tlint/src/Linters/NoParensEmptyInstantiations.php:24
Stack trace:
#0 /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeVisitor/FindingVisitor.php(41): Tighten\Linters\NoParensEmptyInstantiations->Tighten\Linters\{closure}(Object(PhpParser\Node\Expr\New_))
#1 /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(115): PhpParser\NodeVisitor\FindingVisitor->enterNode(Object(PhpParser\Node\Expr\New_))
#2 /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(197): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\Return_))
#3 /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(108): PhpParser\NodeTraverser->traverseArray(Array)
#4 /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(197): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node in /Users/macbook/.composer/vendor/loganhenson/tlint/src/Linters/NoParensEmptyInstantiations.php on line 24

Fatal error: Uncaught Error: Call to undefined method PhpParser\Node\Expr\Variable::toString() in /Users/macbook/.composer/vendor/loganhenson/tlint/src/Linters/NoParensEmptyInstantiations.php on line 24

Error: Call to undefined method PhpParser\Node\Expr\Variable::toString() in /Users/macbook/.composer/vendor/loganhenson/tlint/src/Linters/NoParensEmptyInstantiations.php on line 24

Call Stack:
    0.0003     357824   1. {main}() /Users/macbook/.composer/vendor/loganhenson/tlint/bin/tlint:0
    0.0315    1606216   2. Symfony\Component\Console\Application->run() /Users/macbook/.composer/vendor/loganhenson/tlint/bin/tlint:34
    0.0511    1855152   3. Symfony\Component\Console\Application->doRun() /Users/macbook/.composer/vendor/symfony/console/Application.php:148
    0.0515    1857944   4. Symfony\Component\Console\Application->doRunCommand() /Users/macbook/.composer/vendor/symfony/console/Application.php:240
    0.0515    1857944   5. Tighten\Commands\LintCommand->run() /Users/macbook/.composer/vendor/symfony/console/Application.php:938
    0.0517    1859352   6. Tighten\Commands\LintCommand->execute() /Users/macbook/.composer/vendor/symfony/console/Command/Command.php:252
   12.7301    9493792   7. Tighten\Commands\LintCommand->lintFile() /Users/macbook/.composer/vendor/loganhenson/tlint/src/Commands/LintCommand.php:203
   12.7699   10092120   8. Tighten\TLint->lint() /Users/macbook/.composer/vendor/loganhenson/tlint/src/Commands/LintCommand.php:89
   12.7699   10092816   9. Tighten\Linters\NoParensEmptyInstantiations->lint() /Users/macbook/.composer/vendor/loganhenson/tlint/src/TLint.php:27
   12.7730   10085784  10. PhpParser\NodeTraverser->traverse() /Users/macbook/.composer/vendor/loganhenson/tlint/src/Linters/NoParensEmptyInstantiations.php:30
   12.7730   10085784  11. PhpParser\NodeTraverser->traverseArray() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:85
   12.7730   10086208  12. PhpParser\NodeTraverser->traverseNode() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:197
   12.7730   10086304  13. PhpParser\NodeTraverser->traverseArray() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:108
   12.7731   10087784  14. PhpParser\NodeTraverser->traverseNode() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:197
   12.7732   10087984  15. PhpParser\NodeTraverser->traverseArray() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:108
   12.7732   10088408  16. PhpParser\NodeTraverser->traverseNode() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:197
   12.7732   10088792  17. PhpParser\NodeTraverser->traverseArray() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:108
   12.7734   10090496  18. PhpParser\NodeTraverser->traverseNode() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:197
   12.7734   10090520  19. PhpParser\NodeVisitor\FindingVisitor->enterNode() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:115
   12.7734   10090520  20. Tighten\Linters\NoParensEmptyInstantiations->Tighten\Linters\{closure}() /Users/macbook/.composer/vendor/nikic/php-parser/lib/PhpParser/NodeVisitor/FindingVisitor.php:41

Output all linters that are run on execution

handle `use` aliasing

use Illuminate\Foundation\Support\Providers\RouteServiceProvider as ServiceProvider;

Convert `NoLeadingSlashesOnRoutePaths` to use the 40% method

false positive unused import when used in a typehint

Need a branding image for the readme

Ensure 1 line separation between visibility differing class members

Before

class Purchase extends Model
{
    public const CASH = 'cash';
    public const FINANCE = 'finance';
    public const LEASE = 'lease';
    protected $guarded = [
        'id',
    ];

After

class Purchase extends Model
{
    public const CASH = 'cash';
    public const FINANCE = 'finance';
    public const LEASE = 'lease';

    protected $guarded = [
        'id',
    ];

NoStringInterpolationWithoutBraces does not trigger for object properties

Working as intended (triggers lint)

echo "$a";

Not working as intended (does not trigger lint)

echo "$object->prop";

Lint for proper method of passing json data to blade

See: tighten/novapackages#117

Is it possible to specify rules to check for?

Is it possible to specify rules to check for (via config file or parameters, like other lint tools do)?

Always have braces around variables when embedding in double quoted string

.env out of sync with used `config` values in codebase lint

values missing or unused

cli option to only run on changed files (git)

ignore `server.php` and `bootstrap/*` lints

False Positive `SpacesAroundBladeRenderContent`

{{-- This comment will not be present in the rendered HTML --}}

False positive on request helper lint

No `dd` lint

`request()->validate(...)` over `$this-validate(...)` in controllers lint

False Negative: NoStringInterpolationWithoutBraces

If embedded in a string and is not the first part of a string sequence, the lint is not triggered.

Review: ! You should not mix restful and non-restful methods in a controller

Should have another rule to limit actions to <= 4 for non-restful (restful is limited to 7 by REST method count)

Update TLint Plugin for latest version of PhpStorm

No spaces around function arguments in function calls lint

Setup github integration for running on PRs + tlint passing badge

Disable `ImportFacades` if file is not namespaced

route files

Don't use `compact()` in controllers lint

unused import false positive default Laravel User class

string interpolation

general default is (but this is not hard and fast rules)

use concatenation when it’s not inline. “User: ” . $user->name()
Use interpolation with braces when it’s simple and inline: “You’ve subscribe to the {$plan} plan.”
Use sprintf for everything else.

Definite rule of “never use interpolation without braces”

The argument against interpolation without braces being that it’s just not very clear.

Change the convention from ViewWithOverArrayParameters to ArrayParametersOverViewWith

ignore public/* stuff

example: /public/mix-manifest.json

No method visibility in tests lint

ignore deleted files when using --diff commend

git diff --name-only --diff-filter=ACMRTUXB

Add lint for spaces-around-concatenators

Needs opinion:

$thing = '';
        
echo "a $thing";
echo "a " . $thing;
echo "a {$thing}";

ensure newlines at end of files

remove version from composer.json and add .gitattributes to remove tests

https://blog.madewithlove.be/post/gitattributes/

[bug] ClassThingsOrder.php line 79: Unknown statement

The linter throws the following exception when running:

PS D:\Users\projects\abc> tlint

In ClassThingsOrder.php line 79:

  Unknown statement


lint [--diff] [--json] [--] [<file or directory>]

PS D:\Users\Shantanu\projects\abc>

Tailwind css class ordering linter

https://github.com/tailwindcss/tailwindcss/releases/v1.0.0-beta.1

https://github.com/tightenco/handbook#tailwind-style-ordering

Ask Keith

No spaces around content in blade directive parenthesis lint

1 space between render braces and their content

{{ $x }}
{!! $x !!}

False Positive: `implements X` "There should be no unused imports."

Convert Helpers to String And Array Classes

PHP Fatal error: Uncaught Error: Call to undefined function Tighten\Linters\str_contains() in /Users/jose/.composer/vendor/tightenco/tlint/src/Linters/NoStringInterpolationWithoutBraces.php:26

https://laravel.com/docs/5.8/upgrade#string-and-array-helpers

Ignore setUp and tearDown in tests for method visibility

False Positive `PureRestControllers`

You should not mix restful and non-restful methods in a controller

<?php

namespace App\Http\Controllers;

use App\Data\Models\Profession;

class ProfessionController extends Controller
{
    public function show($slug)
    {
        return view('professions.show')
            ->with('profession', Profession::where('slug', $slug)->firstOrFail())
            ->with('professions', Profession::all());
    }
}

Cache::has("{$this->user_id}.accessed.{$slug}");

tighten / tlint Goto Github PK

tlint's Issues

Before

After

Recommend Projects

Recommend Topics

Recommend Org