thyyppa / fluent-fm Goto Github PK

This is a great package I have used in several projects. Thank you for making it available. I have an issue in one of my projects related to search criteria across multiple uses. As far as I can tell in the documentation, there is no way to clear existing search criteria in a persistent connection. I am using a singleton model where I instantiate the connection in the constructor and use the same instance across several queries and updates throughout my job. The problem is when I try to search for the same foreign key in two different fields. In this use case, I have actual parent with child records. The data model has two foreign key fields, one for the father and one for the mother. I do not always have a 'gender' to use as a qualifier for the search. So I am using a standard try catch to first check for child records where the parent is in the mother fk field. Then do the same for the father fk field position. What I see in the logs is that the search criteria value is persisted from the mother search when the father search is executed. So I never get a correct return from my attempts to search for the father because it is searching for records that have a parent pk in both the father fk and mother fk fields. This breaks down in many other places later on, but in all cases it is related to search criteria persisting after execution. If I am somehow using this incorrectly, please let me know.

As this prevents anyone from removing data from a column or setting a column NULL.

Doing on delete with anything but the id as conditions will throw a 400 Bad Request when the conditions don't match any record.

This is due to $this->find($layout)->get() L:265 returning nothing.
https://github.com/thyyppa/fluent-fm/blob/master/src/Connection/FluentFMRepository.php#L245

 public function delete(string $layout, int $recordId = null): FluentFM
    {
        $this->callback = function () use ($layout, $recordId) {
            $recordIds = $recordId ? [$recordId] : array_keys($this->find($layout)->get());

            foreach ($recordIds as $id) {
               // ...
            }
        };
    }

And $recordIds ending up as an empty array.
Then attempting to DELETE /layout/ without specifying an id which triggers a legitimate 400 from Filemaker.

I'll submit a PR.

The auto_id field of the FluentFMRepository should be public or have a setter method so it can be set to false

In my use case the responsibility of setting the id lies with the database, so we do not want to set the id when creating a new dataset.

Is it possible to run a script on its own (outside of a find) and have the script results returned?

Whenever the "where" function is used, it returns an error indicating that it does not find the field. Could you tell me how to fix it please?