thwjason / hyf-javascript3 Goto Github PK

Hi Jason, here is my feedback on your homework.

1. The constructor of StaffMember takes a date as it third parameter, named dateOfBirth. You could do that like this:

   .addStar(new StaffMember("Ethan Hawke", "actor", new Date('6-11-1970'));

   The getAge() method should return an age in years. This could be done as follows:

   getAge() {
       const now = new Date();
       return now.getFullYear() - this.dateOfBirth.getFullYear();
   }

2. The getDirector() method doesn't take a parameter. It doesn't set the director (otherwise it would have been called setDirector().
3. Then you tried to call addRating() by chaining it to getDirector(). But that doesn't work because getDirector doesn't return the movie object itself (it doesn't return this). Anyway, what you are attempting to pass as an argument to addRating(), viz. this.rating = 64, isn't a rating at all (a movie rating is a number (of stars) between 0 and 10.

10/II/18 - 22:25

After a bit of a struggle, noding my thing yields the following code:

Movie {
  title: 'Gattaca',
  director: 'Andrew Niccol',
  stars: [],
  writers: [],
  rating: [] }
[ 'Ethan Hawke Age: 48',
  'Uma Thurman Age: 48',
  'Jude Law Age: 46' ]
Director: Andrew Niccol

I have tried to do the following within the code, and some variations thereto (and these are still left in the code):

//.addRating(this.rating = 64)
//.addWriter(new StaffMember("Andrew Niccol", "writer", Age: ${n - 1964}))

But whatever I do, I can't seem to push into the arrays. I am somehow not managing to either do a callback (which probably means my understanding here is deficient) to integrate the addStaff class into the Movie Class.

Any help at all would be appreciated.