Comments (8)
Thank you for addressing this. The goal is to make three.dart as idiomatic as possible so we should strive to follow the style guide as much as possible.
As you guessed most of the incoherences come from the three.js
styling but since we have dartfmt
we should follow its rules (but with --line-length 120
at least... I've stopped programming on VTs some years ago :P)
Regarding the for
=> forEach
I'm all for it (map
, filter
, reduce
whenever you can ;))
One thing to keep in mind is that we'll have to arrange for these change to be merged only after closing relevant PR otherwise we'll find ourselves in rebasing/merging hell.
from three.dart.
@nelsonsilva The only PR left is yours, but it looks like there's only a minor modification to one file.
I'd like to move forward with this, but I'd like to know whether I should try to break it up into smaller commits, or just go for it all at once.
Thoughts?
from three.dart.
@beatgammit We can move forward without merging my PR. It's WIP and the PR is there just for tracking and discussion. GLTF is a moving target.
from three.dart.
@nelsonsilva - Should I break it up into smaller commits, or just do it all at once?
from three.dart.
I think this should be done all at once as breaking it up doesn't add any value to the history.
What do you guys think about using --line-length 120
? @financecoding @robsilv @johsin18
from three.dart.
I'm in favor of line length 120.
from three.dart.
+1 for 120
Also, i'm looking forward to this update. I had to turn off "formatting on save" in Dart editor to make my last pull request not include a bunch of formatting changes. It will be nice when all of the code in three.dart is properly formatted and changing settings in dart editor is no longer necessary.
from three.dart.
Ok, I have a pull-request ready, but it should probably wait until all pull-requests that don't just add files are resolved.
from three.dart.
Related Issues (20)
- All demos broken when attempting to run them in Dartium HOT 1
- Dart can't find OBJLoader. HOT 3
- More type annotations or type documentation please HOT 3
- CanvasRenderingContext2D.createPattern used for images
- Texture repeat: natural dimensions HOT 2
- Particles in WebGLRenderer? HOT 1
- Postprocessing HOT 3
- Rendering WebGLRenderTargets and the Renderer interface HOT 3
- Hemisphere light broken HOT 4
- BoundingBox does not have the same function then the three.js
- Add contributer's guide HOT 1
- Implement clone() and dispose() per threejs
- Status of this project HOT 1
- Creating a PlaneGeometry with too many height/width units crashes dartium.
- How should I use the newest three.dart HOT 4
- The method getChildByName from object3d don't work HOT 2
- Instancing HOT 3
- orbit_controls.dart is broken due to browser changes HOT 2
- Alive? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from three.dart.