Not working properly with Zeus about ember-cli-rails HOT 5 CLOSED

So, when should this happen? Typically we're trying to kill the ember process when you quit the "main" rails process. Apparently Zeus keeps the process running in the background and at_exit hook doesn't fire. I'm not sure how we could detect server running under Zeus and start/kill processes appropriately in this scenario.

from ember-cli-rails.

Oh well.. the hook runs. If you set a debugger/binding.pry statement there the hook runs. The problem is that the kill uses a signal 2. I don't know exactly why but a signal 2 is something equivalent to a keyboard interrupt and within zeus, the rails process is not a top process but a child of the zeus process, and when the signal 2 happens (the INT signal) the spawned ember processes keeps running as orphans. The solution that worked is just to kill the process tree of the ember process (the ember process generates a child) instead of sending a signal 2. The code that should change is this method:

def stop
  Process.kill "INT", pid if pid
  @pid = nil
end

to this:

def stop
  # This pkill uses TERM instead of INT and kill the entire tree because ember creates a child process.
  exec("pkill -TERM -P #{pid}")
  @pid = nil
end

The problem is that i'm not sure of the disponibility of pkill in all unix-like environments or how this behaves under windows.

from ember-cli-rails.

Why sending TERM instead of INT? How does that makes any difference?

from ember-cli-rails.

We're sending this INT to the ember process, and it shouldn't matter whose child this ember process it.

Also, could you check if sending HUP works?

from ember-cli-rails.

@juliogarciag ping

from ember-cli-rails.