Git Product home page Git Product logo

Comments (6)

Samsinite avatar Samsinite commented on May 25, 2024 1

Or, if we should just warn regardless when in development, we could add a method that does the check and warn if true, then call it in

Seems like it could still be useful to warn, even if the build is successful.

from ember-cli-rails.

Samsinite avatar Samsinite commented on May 25, 2024

If interested, I would be more than happy to work on a PR, it would be a feature that could likely save our team time in the future.

from ember-cli-rails.

seanpdoyle avatar seanpdoyle commented on May 25, 2024

@Samsinite I like this idea!

How would we structure the communication of how the application is configured?

ember-cli outputs a block of dependencies and version numbers at the start of commands like ember serve and ember test, were you thinking of something similar?

from ember-cli-rails.

Samsinite avatar Samsinite commented on May 25, 2024

Honestly, I haven't put a lot of thought into the structure of the log message. What would you prefer the log message to look like or say?

from ember-cli-rails.

seanpdoyle avatar seanpdoyle commented on May 25, 2024

Honestly, I haven't put a lot of thought into the structure of the log message. What would you prefer the log message to look like or say?

I'm less focussed on the structure of the log message, and more thinking about when and how it should be communicated.

Just ran into an issue where a co-worker accidentally had SKIP_EMBER=true in development, and it took us 20 minutes to track down.

At what point in the process would some indication that SKIP_EMBER=true be most helpful?

from ember-cli-rails.

Samsinite avatar Samsinite commented on May 25, 2024

What about adding a check for app.development? and app.skip? here:

def check_for_error_and_raise!

Thoughts? Unless I am mistaken, the current gem structure should make this feature fairly straight forward.

from ember-cli-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.