Git Product home page Git Product logo

Comments (4)

thomaspoignant avatar thomaspoignant commented on May 25, 2024 1

Hello @bearrito let me try to answer your questions.

  1. I see that the other exporters all take a featureEvents []exporter.FeatureEvent. This needs to be converted into a trace. I need to learn more about Features and Evaluations. But would each FeatureEvent correspond to a span within the trace?

Yes, you can emit 1 span for each featureEvent, but since this can be a synchronous exporter I recommend to set the IsBulk function at false (like in the example below), this will ensure that you will never have more than 1 event in the array for each call.

func (f *Exporter) IsBulk() bool {
return false
}

  1. OpenTelemetry itself supports exporters. I assume you want support for all these? Is there one to prioritize?

Since this is meant to be used by anyone, I would say that we should export to OTLP so the users can decide on their side which one to use.

  1. Do I need to worry about context propagation? (I don't think so)

No, we can start without that for now.

  1. Do you want resources (metadata) included. ( I think so)

Yes, ideally we should have them.

from go-feature-flag.

bearrito avatar bearrito commented on May 25, 2024

I haven't contributed before, I can grab this if thats okay.

from go-feature-flag.

thomaspoignant avatar thomaspoignant commented on May 25, 2024

Hey @bearrito feel free to take it.

from go-feature-flag.

bearrito avatar bearrito commented on May 25, 2024

Just so I can confirm scope

  1. I see that the other exporters all take a featureEvents []exporter.FeatureEvent. This needs to be converted into a trace. I need to learn more about Features and Evaluations. But would each FeatureEvent correspond to a span within the trace?
  2. OpenTelemetry itself supports exporters. I assume you want support for all these? Is there one to prioritize?
  3. Do I need to worry about context propagation? (I don't think so)
  4. Do you want resources (metadata) included. ( I think so)

Edit:
I'm not familiar with the relay proxy so I'll deal with that when I encounter it, I'll get to what I think is an 80% solution with unit-tests first.

from go-feature-flag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.