(bug) AwsConfig ignored as of s3Retrieverv2 refactoring about go-feature-flag HOT 3 CLOSED

@david-alza thanks for raising this issue.

I will check in the next few days the issue and I will try to provide a fix.

from go-feature-flag.

Thanks @thomaspoignant! The more I look at it, the more I think we're just missing this block that existed prior to the refactor:

if s.AwsConfig == nil {
	cfg, err := config.LoadDefaultConfig(ctx)
	if err != nil {
		initErr = fmt.Errorf("impossible to init S3 retriever: %v", err)
		return
	}
	s.AwsConfig = &cfg
}

I can put up a PR in a second to take a stab at fixing this.

from go-feature-flag.

Yes, I just looked at it and I think you are right, I've removed that code by mistake.
Feel free to open a PR if you have a bit of time, if not I can take of this tomorrow.

Just do not forget to change the status of the retriever when a error occurred by using

s.status = retriever.RetrieverError

from go-feature-flag.