Git Product home page Git Product logo

ginfinity's Introduction

Hello there

Stats

ginfinity's People

Contributors

benelot avatar thomasardal avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

ginfinity's Issues

DOM Based XSS Vulnerability

I accidentally discovered a security flaw in your extension. When the TreeWalker object takes text from the page and adds it back to the DOM inside span innerHTML, if the text is a script, it is executed. A malicious user could steal cookies from google.com, redirect user's browser to a malicious site, among others things.
Proof:

alert google

Chrome with gInfinity:------------------------------------Chrome without gInfinity:

lmjol4b

As you see, the <.svg onload=alert(1)>, that appears in google index content is executed when i using your extension.

Vulnerable section of code:

chrome.runtime.sendMessage({ method: "getLocalStorage", key: "enable_links" }, function (response) {
       if (response.data == "true" && document.getElementById && document.createTreeWalker && typeof NodeFilter != "undefined") {
           var tw = document.createTreeWalker(document.body, NodeFilter.SHOW_TEXT, null, false);
           var node;
           var rem = [];
           while (node = tw.nextNode()) {
               if (node.nodeValue.match(reg) && node.parentNode.tagName != 'A' && node.parentNode.tagName != 'TEXTAREA' && node.parentNode.tagName != 'STYLE' && node.parentNode.tagName != 'SCRIPT' && node.parentNode.tagName != 'META' && node.parentNode.tagName != 'NOSCRIPT' && node.parentNode.tagName != 'PRE') {
                   var parentElem = node.parentNode;
                   var val = node.nodeValue.replace(reg, '<a href="$1">$1</a>');
                   var aNode = document.createElement("span");
                   aNode.innerHTML = val;
                   parentElem.insertBefore(aNode, node);
                   rem.push(node);
                   continue;
               }
           }
           for (i in rem) {
               rem[i].parentNode.removeChild(rem[i]);
           }
       }
   });

'Enable automatic tab when max length in a input field is reached.' causes problems

'Enable automatic tab when max length in a input field is reached.' in my case leads to constant automatic tabbing in the case of pages like youtube or more local swiss pages like salt.ch. Of course the problem is fixed by turning the feature off. Probably make the feature turned off by default. Or do you think that there is an actual issue to be fixed? Probably you are reacting wrongly to a missing max length tag or one that is changed by a script.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.