As mentioned by @MarkDunneImprobable in another repo, isovist example is broken.

File C:\ProgramData\Miniconda3\lib\site-packages\t4gpd\commons\RayCastingLib.py:175, in RayCastingLib.multipleRayCast2D(masksGdf, masksSIdx, viewPoint, shootingDirs, rayLength)
    173     raise IllegalArgumentTypeException(masksGdf, 'GeoDataFrame')
    174 if not isinstance(masksSIdx, (SpatialIndex, Index)):
--> 175     raise IllegalArgumentTypeException(masksSIdx, 'SpatialIndex or Index')
    176 if not isinstance(viewPoint, Point):
    177     raise IllegalArgumentTypeException(viewPoint, 'Point')

IllegalArgumentTypeException: 
----------------------------------------------------------------------
*** Illegal argument: 
*** Instead of: <geopandas.sindex.PyGEOSSTRTreeIndex object at 0x00000261F3141040>
*** a SpatialIndex or Index was expected!

Unlike @MarkDunneImprobable, I don't know how ti fix this. Any pointers?
Thanks!

Hi Thomas,

Example : Estimation of view factors using ray casting (version 0.4.0+) does not work.

Bug in file MoveSensorsAwayFromSurface.py

n ==> return nan

`
def runWithArgs(self, row):
p = row.geometry
assert isinstance(p, Point), 'sensorsGdf must be a GeoDataFrame of Points'
n = row[self.normalFieldname]
# print(p.x )
# print(self.dist)
# print(n)
# print(type(n))
# import math
#
# if isinstance(n,float) and math.isnan(n):
# n=(0,0,0)

    return { 'geometry': Point([
        p.x + self.dist * n[0],
        p.y + self.dist * n[1],
        p.z + self.dist * n[2],
        ]) }

`

Boris

Dear @thomas-leduc,
I try to use your package in my project. I face an issue while using the t4gpd.isovist.STIsovistField2D function (see below)

Any idea of what I'm doing wrong ?
Regards

Dear @thomas-leduc,
First of all congrats for your work which is highly relevant from my point of view.
I have seen here (https://github.com/CZiang/3D-To-2.5D/blob/main/7_irrad_viz3d.py) that new functions of your projects have been developped such as t4gpd.energy.geoProcesses.
Have you planned to update this GitHub repository soon ?
Best regards
Simon

I think there is a little code malfunction in DirectSolarIrradiation.py
Indeed, whatever the dtStart, dtStop values (ex: datetime(2021, 12, 21, 6), datetime(2021, 12, 21, 12)), the calculation is done for the entire day. I suggest this change

datetimes = DatetimeLib.range(dtStart, dtStop, dtDelta)
import pandas as pd
datetimes = [x.to_pydatetime() for x in pd.date_range(start=dtStart, end=dtStop, freq=freq, tz='Europe/Paris').tolist()]