thk1 / send_wrapper Goto Github PK

Instead of using boxing, the crate could use ManuallyDrop. ManuallyDrop is great!

Hi,

would you mind adding a changelog entry for 0.6, indicating what are the breaking changes. There also is no 0.6.0 release tag on github.

cheers.

If I'm not mistaken, calling takeon the wrapper leaks the thread_id field since it calls std::mem::forget() here.
The value should be moved out of the wrapper so it is managed separately and the rest can be dropped entirely.

What is the reason for storing the value as a pointer instead of keeping it as a box?
The latter avoids most unsafe code.

Also the panic messages should be swapped: