'ScanFromRootFolder' option seems to work incorrectly about modupdater HOT 8 CLOSED

I checked on gta3, it's working both ways for me there. Could you provide your files so I'd be able to reproduce?
Also set output log to file and see what paths it processes there.

from modupdater.

I have not tested this on gta3, but it seems like there is custom code in this module for gta games, so it might be best to test with a non-gta game. I am using Silent Hill 2 for my tests. The OutputLogToFile and AlwaysUpdate are enabled for all my tests.

If you copy the six files from the zip file below into the Silent Hill 2 folder then modupdater is not able to find any updates:

Silent_Hill_2.zip

The log looks like this:

Current directory: D:\Games\Silent Hill 2\

If I simply move the 'modupdater.asi' and 'modupdater.ini' file into the 'scripts' folder then the log looks like this:

Current directory: D:\Games\Silent Hill 2\scripts\
d3d8.dll found.
Update URL: https://github.com/elishacloud/Silent-Hill-2-Enhancements
Connecting to GitHub: https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements/releases?per_page=100
GitHub's response parsed successfully. Page 1.
Nothing is found on GitHub.

sh2-enhce.asi found.
Update URL: https://github.com/elishacloud/Silent-Hill-2-Enhancements/releases
Connecting to GitHub: https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements/releases?per_page=100
GitHub's response parsed successfully. Page 1.
Found sh2-enhce.zip on GitHub.
Download link: https://github.com/elishacloud/Silent-Hill-2-Enhancements/releases/download/v1.0.255.0/sh2-enhce.zip
Remote file updated 215 days ago.
Local file updated 262 days ago.
File size: 19111KB.

Update cancelled.

If I enable ScanFromRootFolder then no log is generated while 'modupdater.asi' and 'modupdater.ini' files are in the 'scripts' folder.

No matter how ScanFromRootFolder is set the log file looks the same as long as the 'modupdater.asi' and 'modupdater.ini' files are in the game's process folder.

In other words, the only way I can get modupdater to detect anything is to have ScanFromRootFolder disabled and to put it in the 'scripts' folder.

from modupdater.

Thanks, I'll check that out.

from modupdater.

So, apparently when you use scan from root folder in SH2, the process looks through all 3000+ files which simply takes a long time, that's why it seems like nothing is happening.
I suppose you want to also update d3d8.dll with that archive and currently it's indeed not possible for files hosted on github. I use this for external files:
https://github.com/ThirteenAG/WidescreenFixesPack/blob/master/data/SplinterCellPandoraTomorrow.WidescreenFix/offline/system/scripts/modupdater.ini#L6

I'll make an update to fix this and let you know when it's ready.

from modupdater.

Ok, that makes sense. I guess I need to be more patient. Thanks for working on this!

from modupdater.

You should be able to update files in root dir just fine now, with PlaceToRoot parameter at least.

from modupdater.

Thanks @ThirteenAG!

from modupdater.

Let me know if there's any issues still, I only updated a few files and downloaded some mods with sample inis for gta, but hopefully everything works properly now.

from modupdater.