thirddegree / hatchitcore Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 1.0 258 KB

License: GNU General Public License v3.0

C++ 99.94% C 0.06%

hatchitcore's People

Contributors

Stargazers

Watchers

Forkers

jamesmarcil

hatchitcore's Issues

GetHandle does not verify the true type of handle returned.

If you request TextureHandle of name "MyName", and then request SamplerHandle of also "MyName", you get back a TextureHandle that is reinterpreted as a SamplerHandle.

Handle should not directly release resource without refcounting

Symptom of issue: thirddegree/HatchitGraphics#36
Cannot fix until that issue is fixed.

File should use streams instead of raw FILE*

Ideally, the File class would use either an std::ifstream or std::ofstream instead of a raw FILE* for IO. This would allow for easy overloading of << and >> for inserting and extracting things from the stream.

HT_DEBUG_PRINTF should log to a file

Since the console can fly by, especially during shutdown we should really have debug statements print to a file so we can review it later. Maybe even have a flag to allow a release build to log to a file in case we have problems in release?

RefCountedResourceManager occasionally crashes on shutdown

Occasionally on shutdown I get an assert in the RefCountedResourceManager's destructor. Line 33 of ht_refcounted_resource_manager.h.

It only happens on some shutdown sequences.

Refcounted should use guids instead of strings

Empty guid cannot be accessed without static function

No idea why the symbols aren't being found for Guid::Empty. Any insight would be helpful.

Documentation and Coding practice conformity

Do a clean through the repo for documentation, conforming to coding standards, etc.

Make use of forthcoming C++17 standard filesystem library

In the upcoming C++17 standard should be officially available across multiple compilers. Currently GCC maintains experimental support for filesystem, and MSVC 2015 also has an implementation (final draft version).

I think starting early on adapting this library change would be good.

Handle's of interface types cause improper destruction

If the last handle to be destructed for a refCounted is not the same type as the refCounted, the refCounted is likely to not be found in the map, and will cause a resource to never be released until another handle of it's type is requested and destructed, or until the program ends.

Use of HT_DEBUG_PRINTF requires namespace inclusion

Any file / block of code that contains HT_DEBUG_PRINTF requires the line using namespace Core. We would ideally like to get rid of that reliance.

Work on Code Review for #45

Look through comments on #45, and make sure we're happy with the results of the PR.

Sortable guid

May be arbitrary, but consistent
For use in std::map as a key

Logging system needs support for registering a callback function to grab the log output.

This functionality is really geared towards development of the editor. It would be nice to be able to register a callback into Hatchit from the editor so I could grab any debug statements that are thrown and can then output them to the GUI

Travis builds failing

They don't seem to be able to find the inline files.