thinkpixellab / bot Goto Github PK

I have an application with a TabControl and several TabItem.

Each TabItem has an AnimatingTilePanel. My ItemTemplate has a thumbnail image.

Even with ~100 max items per tile panel, the performance degrades and out of memory exceptions are occasionally thrown when switching tabs. Swapping out the AnimatingTilePanel for a plain old VirtualizingStackPanel shows a measureable performance increase and is error free.

Is AnimatingTilePanel just not able to handle that many items at that size? Or are there some tricks that I could be employing?

Hi,
I'm planing with the InfoTextBox control and I've noticed and issue.

I picture would say a thousand words, so please take a look:
http://yurysweb.com/tmp/InfoTextBox_bug.jpg

As you can see from the screenshot, the selection doesn't get cropped.

Thanks,
Yury

Fail!

...should mention Add

After run WPF4 demo and choose whatever in menu it shows exception "Must use the rewriter when using Contract.Requies"

When an element is dragged outside the vertical bounds of the listbox, the item that was previously on top (or bottom) will get selected.

A workaround for this is:

        _myListBox.SelectionChanged += delegate
                {
                    if (_myListBox.SelectedIndex != -1)
                        _myListBox.SelectedIndex = -1;
                };

If a ReorderListBox will throw a NullReferenceException when used in a winform hybrid application. the reason is that the DragPreviewAdorner uses Application.Current, but this static property is not assigned when running in a winform application. A solution is to change the following method:

    private static void GetCurrentDPI(out double x, out double y)
    {
        Matrix m = PresentationSource.FromVisual(Application.Current.MainWindow).CompositionTarget.TransformToDevice;
        x = 96 / m.M11;
        y = 96 / m.M22;
    }

to

    private static void GetCurrentDPI(out double x, out double y, FrameworkElement element)
    {
        Matrix m = PresentationSource.FromVisual(element).CompositionTarget.TransformToDevice;
        x = 96 / m.M11;
        y = 96 / m.M22;
    }

and pass the current element in SetPreviewElement:

    public void SetPreviewElement(FrameworkElement element)
    {
        //...
        GetCurrentDPI(out x, out y, element);

Side note: the class NotifyWorker seems to have the same issue in the OnClientException method... haven't looked at how that could be handled. We aren't using that class.

I'm pretty sure that on one of the old versions of the Graph control when I change the size of the window, and by that changing the available size of the Graph control, the children were re-arrange to use the available size.
The new version does not do that, it arrange the children as if it had all the space it require.

Thank you,
Ido.

Since the great file move around, Demo_SL4.sln, Demo_WP7.sln, and Demo_WPF4.sln still have the old folder names in their project references, though Demo_All.sln properly reflects the new structure. The other solutions need to be updated to run in VS straight out of the box. I'd fix it myself and submit a pull, but at the moment I'm on a work computer without git. :(

After run WPF4 demo and choose whatever in menu it shows exception "Must use the rewriter when using Contract.Requies"

It works only on some demos.
These does not work:
Animating Title Panel
Graphs
Org Tree
Set game
Treemap panel
Zap controler

Looks like there's a memory leak when using StoryBoardTransition. I see an ever growing number of DoubleAnimation instances over time.

Looking at the code, this at least looks suspicious:

https://github.com/thinkpixellab/bot/blob/master/Wpf/Transitions/StoryboardTransition.cs#L79

The local "done" variable is used in the event handler here - doesn't make much sense. And the event handler is never unsubscribed.

In wpf.Core.SampleImageHelper......GetDefaultPicturePaths() you might consider changing the literal path as it bombs out if you don't have your Pictures in the default location.

e.g.
change:
return new string[]{@"C:\Users\Public\Pictures\Sample Pictures",
Environment.GetFolderPath(Environment.SpecialFolder.MyPictures)}.ToReadOnlyCollection();
to:
return new string[]{Environment.GetFolderPath(Environment.SpecialFolder.CommonPictures) + @"\Sample Pictures",
Environment.GetFolderPath(Environment.SpecialFolder.MyPictures)}.ToReadOnlyCollection();

Mind you anyone able to use a non-default location could probably figure this out for themselves.

To keep things...you know...interface-y

Reentrancy checks are skipped...which can be very dangerous :-/

Whenever a listbox contains more items than it can handle, by default it will display a scrollviewer.
The reordering will stop to function properly when this happens.

The first thing i notice is that because of the standard virtualisation of the ItemsPanel, Transform item breaks because the item with an index higher than the ones visible will return null at ItemContainerGenerator.ContainerFromIndex(i) as FrameworkElement. This however is easily fixed by declaratively implementing a non virtualized ItemsPanel.

Second, the position of the overlay adorner is not updated when scrolling occurs. The adorner scrolls with the content of the ListBox and thus moves up or down.

The behaviour is easily reproduced by setting a ListBox height to 120 in the demo app.

Any clues on how to fix the second issue/observation?

Regards,
avsomeren

if TransitionPresenter content have Alignment (eg: Center), and have no background. The animation could't get the margin. The animation will cause content stretch.

The following on line 385 in minesweeper.cs causes an exception (something along the lines of 'attempt to throw propertychange event for a property that doesn't exist'):

    public const string StatePropertyName = "StateLeft";

It should read:

    public const string StatePropertyName = "State";

The exception occurs when you win or lose the game.

In addition, the "square_PropertyChanged" method uses a hard-coded string "State" and should reference the const above.

Implementation thoughts:

1. Add a SelectRecursiveAtLevel method that only returns items at a provided depth n
2. For the breadth first version, just call SelectrecursizeAtLevel for 0 -> N (where we stop once an empty level is found)
3. Allows for a breadth first search where one can provide a max level paramater
4. To keep the implementation cheap, this would require multiple iterations of the provided source collection
   • This is probably better than the potentially huge state the method would have to maintain to keep track of where the traversal is

Have a reorder handle of sorts in the data template. Allowing selection + reorder is an important use case to demonstrate.

Right now you can't select items in the list box.

public static T WatchProperty(this T source, Action handler, params string[] propertyNames) where T : INotifyPropertyChanged

• takes 1 (or more?) property names + action to handle one property change
• in debug, checks to make sure the object actually has a property of that name -> great baby sitter that the property exists
• returns the source object to allow chaining...cool!