Git Product home page Git Product logo

creditcard's Introduction

Hi ๐Ÿ‘‹, I'm Adrian Statescu

Full Stack Developer

creditcard's People

Contributors

thinkphp avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

Forkers

jonathan-beebe

creditcard's Issues

problem recognising a mastercard as maestro in IE8

to replicate: use card "5473677027371724" (modded number so remove isValid check)

it will loop through the object and the number above will satisfy both mastercard and maestro but the result will be at random, dependent on browser.

your loop takes cards from the CARDS property BUT as that is an object, there are no guarantees on the order in which they arrive (as per ES this is correct).

it's usually in order of entry but not always - IE8 and Chrome can often loop through a different order.

To fix this, I have reverted this.CARDS to an array and then use this.CARDS.some to only get a singular match,

Can't be bothered with a pull request but here's a gist of what I use now: https://gist.github.com/1002106

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.