Git Product home page Git Product logo

newyorktime's People

Contributors

thiendn160794 avatar

Watchers

 avatar

newyorktime's Issues

Thanks!

Hi @thiendn160794, thank you for submitting assignment 2 .

Overall

  • The apps run fine without any serious crashing.

Great stuffs

  • Nice using RecyclerView for listing items.
  • Nice using Retrofit for accessing New York Time API.
  • Good job on using Glide for images .
  • Great job on keeping things separate in each package, and code looks really clean. I like that

Area to Improve

  • There are a lot of optional stories, you should do it. Because it will make you get better at programming android.
  • You should setAdapter only once and then if there is new data, you just have to notify. So as to improve app performance
  • You should define private for variables. It's a good practice. Here is why
  • You should use Data Binding or ButterKnife for binding views. For an example :
rvArticle = (RecyclerView) findViewById(R.id.rvArticle);
pbLoading = (ProgressBar) findViewById(R.id.pbLoading);
  • UI looks simple you should pay more attention to it. You can take a look at Phong's assignment Link

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.