thiagocrepaldi / homelab-utility-belt Goto Github PK

I receive the following error when running the script on DSM 6.

install_letsencrypt_cert_from_pfsense.sh: line 34: syntax error in conditional expression: unexpected token ;' install_letsencrypt_cert_from_pfsense.sh: line 34: syntax error near ;'
install_letsencrypt_cert_from_pfsense.sh: line 34: `if [[ ${DSM_MAJOR_VERSION} == 6]]; then'

Does the semi colon need to be removed?

Just to let you know I adapted your script to my use.
https://github.com/hilsonp/synology-tk

Thank you very much for sharing your version !

Seems that script doesn't work with SuperServer model, tested on SuperStorage and SuperServer models

Script throws an error
File "/usr/local/bin/ipmi-updater.py", line 412, in
main()
File "/usr/local/bin/ipmi-updater.py", line 380, in main
cert_valid = updater.get_ipmi_cert_valid()
File "/usr/local/bin/ipmi-updater.py", line 187, in get_ipmi_cert_valid
root = etree.fromstring(result.text)
File "src/lxml/etree.pyx", line 3237, in lxml.etree.fromstring
File "src/lxml/parser.pxi", line 1896, in lxml.etree._parseMemoryDocument
File "src/lxml/parser.pxi", line 1777, in lxml.etree._parseDoc
File "src/lxml/parser.pxi", line 1082, in lxml.etree._BaseParser._parseUnicodeDoc
File "src/lxml/parser.pxi", line 615, in lxml.etree._ParserContext._handleParseResultDoc
File "src/lxml/parser.pxi", line 725, in lxml.etree._handleParseResult
File "src/lxml/parser.pxi", line 654, in lxml.etree._raiseParseError
File "", line 10
lxml.etree.XMLSyntaxError: Opening and ending tag mismatch: META line 5 and head, line 10, column 8