thezoq2 / flash Goto Github PK

This needs to be done in file_data_from_file_location for example

Perhaps it could be achieved by querying the file and checking if the data modification date differs from the currently stored file. This might not be more efficient than just refetching the data from the database.

This would probably require some cleanup and I might only want to store the file lists that have been created from paths, not db searches

This most likely originates from thumbnail generation having failed without nulling the db entry thumbnail field.

This should be done by reading the save_result_rx variable from FileSaveRequestResult::NewdatabaseEntry whenever it is stored.

A good system for reporting these errors to the user must be established

Currently the request handlers request data from a separate function which they then serialize. Errors in the serialization are unwraped

When going through pictures, CPU usage spikes to 100% on all cores and it takes a long time for thumbnails to actually be created and displayed in the album

rust-lang/rust#24000
rust-lang/rust#44490

fix_timestamps and create_changes from files will soon be unused (once all prod instances have been synced)

This might cause issues if you search for /home/user/ or something with a lot of depth. Perhaps a max depth could be specified?

Failure is the recommended error handling lib and seems to come with some nice features that are not present in error_chain. Though before switching over it might be better to test it in another project.

Things to test

• Best error structure
• How to add context
• How do backtraces work

This is because it tests http status codes. Perhaps the online test could be replaced with a diy script. Or perhaps this does not need to be tested?

• Reproduce in tests
• Fix

Currently timestamps are set to 0 in FileDatabaseContainer::add_file_to_db()

Looks like it might be related to determining what changes happened before/after syncpoints

These are tags that will be removed from all images that get saved

All functions that add new files or update them always set a timestamp so having it nullable in the database just adds complexity

As it stands, any file on the server file system can be accessed by making a request to file/path. Some sort of whitelist would probably be a good idea.

This also applies to file listings from directories.

Aparently this can be fixed by updating the crates throwing the error

Replace

mount.mount("/list", file_request_handlers::file_list_request_handler);

with

mount.mount("/list", ..)
mount.mount("/list/{id}", ..)
mount.mount("/list/{id}/file/{id}", ..)

This will make it easier to see valid parameters for requests from the code since they would be visible in the handler declaration.