navbar buttons go a little to far down about therealmofthegeek.github.io HOT 17 CLOSED

Heya. 👋 I'll take a look.

from therealmofthegeek.github.io.

Awesome. thanks @chasingSublimity!

from therealmofthegeek.github.io.

So it looks like the issue is actually in your javascript. If you click the about me button more than once, the page behaves as expected after the initial click. lemme do some more digging.

from therealmofthegeek.github.io.

Huh.. checking the site now, it seems to have fixed itself? I guess fixing #21 also fixed this... interesting.. I'm not sure why it'd fix it, but thats the only file we've changed..

from therealmofthegeek.github.io.

I'm still seeing it on my end, but only when I navigate to https://therotg.com/, not https://therotg.com/#about . 🤔

from therealmofthegeek.github.io.

Ah, I'm seeing that as well now too.. this is a strange issue.

from therealmofthegeek.github.io.

I think it has something to do with the affix class that gets applied to the nav bar. Where are you handling that in the code?

from therealmofthegeek.github.io.

I'm getting that from Bootstrap

from therealmofthegeek.github.io.

Ah. What version?

from therealmofthegeek.github.io.

Bootstrap v3.3.7

from therealmofthegeek.github.io.

just for an update, I'm going to head to bed. I'll respond to any questions in the morning when I wake up. Thanks for trying to figure this out, and sorry I need to tap out for the night

from therealmofthegeek.github.io.

Got the problem and it is the intended behaviour. leave a comment if you need more details.

from therealmofthegeek.github.io.

@sagarvd01 is there any way to make it go higher?

from therealmofthegeek.github.io.

For what it's worth, if you replace this line in nav.js:
window.location.hash = hash

With this one:
history.pushState(null, null, hash);

It should work like I think you want it to. Can open a PR if you want, but know someone else is working on this.

from therealmofthegeek.github.io.

Let's see if @chasingSublimity finds a fix first, if he doesn't find a fix by the end of the night, go ahead and make a push request ;)

from therealmofthegeek.github.io.

@kvizdos the # value in url will scroll upto the element with that id. Since you're navbar's position is fixed, it will stay independent to all other elements on that page. So, the page scrolls to make the heading come to top of page but the navbar is hiding that.

from therealmofthegeek.github.io.

Closed by pull request #31

from therealmofthegeek.github.io.