Git Product home page Git Product logo

Comments (24)

Jack-Rouleau avatar Jack-Rouleau commented on June 7, 2024 1

It's the googleads javascript that's failling, either remove the snippet in the header file or fix whatever is making it fail. Your keys might be invalid.

from therealmofthegeek.github.io.

farmerau avatar farmerau commented on June 7, 2024

Could you provide browser information / webpage / screenshots?

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

@farmerau Updated the issue.

from therealmofthegeek.github.io.

Jack-Rouleau avatar Jack-Rouleau commented on June 7, 2024

Got a fix ready to push, don't seem to have permission to push to branch.

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

@Jack-Rouleau I'll check and update permissions now. Thanks for telling me!

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

@Jack-Rouleau can you create a pull request for it?

from therealmofthegeek.github.io.

farmerau avatar farmerau commented on June 7, 2024

Looks like Chrome. Windows user?

Also, what's your screen resolution? Still can't reproduce here.

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

Hmm. I've now tried on my main PC (Windows 10, Chrome), my laptop (Mac OSX Sierra, Safari & Chrome) and my S7 Edge (Chrome). I would say its my computer, but as I've tested it on so many things, I'm not sure whats causing it. Are you able to replicate it?

Mac (Safari):

Mac

S7 Edge (Chrome):

S7 Edge

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

Oh, interesting. Do you want to submit a pull request and remove the Ads code for Hacktoberfest? @Jack-Rouleau

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

And I'm guessing @farmerau, you're using AdBlocker, and that's why you're not seeing the white space?

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

As I suspected, deleting that bit of code with inspect element, it fixes #20

from therealmofthegeek.github.io.

Jack-Rouleau avatar Jack-Rouleau commented on June 7, 2024

Yeah would have pushed something earlier but I keep getting an error for some reason

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

And what about a pull request? Unauthorized users can't push, but they can open pull requests @Jack-Rouleau

from therealmofthegeek.github.io.

Jack-Rouleau avatar Jack-Rouleau commented on June 7, 2024

I'd need to be able to push to a branch to be able to create a pull request :P

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

Any error code? Screenshot?

from therealmofthegeek.github.io.

farmerau avatar farmerau commented on June 7, 2024

Ah, that makes sense. Sorry about that.

from therealmofthegeek.github.io.

Jack-Rouleau avatar Jack-Rouleau commented on June 7, 2024

image

If others are able to push their branches I probably just screwed up my SSH configs on this computer at some point haha

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

@Jack-Rouleau Did you set the remote and everything?

from therealmofthegeek.github.io.

gmemstr avatar gmemstr commented on June 7, 2024

@Jack-Rouleau You need to fork this repository, then change the remote as described here. You currently have it pointing to this repository, which you are not allowed to push to. Once you have pushed changes to your own repository, you will see a button to create a new pull request.

from therealmofthegeek.github.io.

Jack-Rouleau avatar Jack-Rouleau commented on June 7, 2024

@gmemstr Thanks! Never worked with repositories I didn't have push permission to.

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

Oh, thanks @gmemstr for the quick how-to! I have yet to do a pull request, so I didn't know how to do it, thanks for telling us!

from therealmofthegeek.github.io.

gmemstr avatar gmemstr commented on June 7, 2024

I should mention the pull request button will be branch rollout beneath the repository stats (commits etc) on your own repository.

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

Good to know

from therealmofthegeek.github.io.

kvizdos avatar kvizdos commented on June 7, 2024

You doing good, @Jack-Rouleau?

from therealmofthegeek.github.io.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.