Git Product home page Git Product logo

Comments (2)

juzerali avatar juzerali commented on August 14, 2024

Also it will be better if the fluent API to build the pipeline is shifted to the builder. As per Single Responsibility Principle, responsibility to build an object with complex graph should be outside the object itself, i.e. in a builder.

So building the pipeline will look like this:

$pipeline = (new PipelineBuilder)
    ->pipe(new TimeTwoStage)
    ->fork(function($payload) {
            if($payload < 0) return "-";
            if($payload >= 0) return "+";
        })
        ->disjoin("-", $negativeNumberProcessingPipeline)
        ->disjoin("+", $positiveNumberOrZeroProcessingPipeline)
        ->join()
    ->pipe(new DivideByFiveStage)
    ->build();

from pipeline.

shadowhand avatar shadowhand commented on August 14, 2024

I think this would be better solved by using something like php-fp-either, where every stage returns a Right or Left:

use PhpFp\Either\Either;

$pipeline = new Pipeline();
$pipeline = $pipeline->pipe(function (Either $a) {
    return $a->chain(function ($x) {
        return $x * 2;
    };
});

$output = $pipeline->process(Either::of(2))->either(
    function ($left) {
        return 'failed';
    },
    function ($right) {
        return $right;
    }
);

assert($output === 4);

from pipeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.