Git Product home page Git Product logo

Comments (3)

frankdejonge avatar frankdejonge commented on July 16, 2024

@GreatOwl sorry for the (very) late response. First of all, thank you for the comments. I've thought quite some time how such a component should be named. I went with "fingers crossed" mostly because Monolog has a similar handler type, which I thought was kind of funny. I also like the fact that you almost feel like you should think about what happens when things don't go according to plan, like a try/catch block around the execution. However, I am totally open to suggestions. Names like DefaultProcessor don't really cover the load because it doesn't describe what that kind of processor does. With "fingers crossed" you can assume there's no error handling or checks involved, which is something I like about that name.

from pipeline.

GreatOwl avatar GreatOwl commented on July 16, 2024

I think that is a fair assessment of your decision.

From my position I see the opportunity for being able to apply a functional pattern with this library, modifying state as each stage completes. The original implementation was wonderful in my opinion because of its use of top level functions instead of a foreach during execution.

The usage of the foreach is logical however for those dealing with a traditional stack, and gathers no opposition.

so I will willingly close this, and request your continued attention to:
#24

Thanks @frankdejonge

from pipeline.

frankdejonge avatar frankdejonge commented on July 16, 2024

@GreatOwl converting the array_reduce into a foreach was unfortunate, but PHP's handling of exceptions was nipping it in the butt. When an exception is thrown it's unrecoverable unless handled inside the stage, which is not always desired. This made me have to "downgrade" the actual implementation, I share your grief.

from pipeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.