[PHP 8] Warning on EncodesUrl about oauth1-client HOT 17 CLOSED

I anticipate that I’ll have 1.9.0 out within a day or two. Thank you for your patience.

from oauth1-client.

Any idea when a new release is going to be issued? Laravel Socialite is using this library and currently the Twitter Login is broken on PHP 8 because of this bug. :(

from oauth1-client.

@bencorlett: Could you please create a new version since this bug is in the current released version 1.8.2 which is not usable due to this bug. That would be great.

from oauth1-client.

Thanks Matt! I’ll take a look 👍

from oauth1-client.

Submitted #129 to not only get rid of the exception, but actually make the code do what it was supposed to do - that is, normalize keys and values. First time doing a pull request, so I hope I didn't do any mistakes. 😅

from oauth1-client.

from oauth1-client.

@mattkingshott thanks for your interest, and patience in the project mate :) I haven't been committing too much time to OSS over the past couple of weeks but rather spending quality time away from the computer with my family.

There's a few moving parts to getting the next release out. Firstly, we need to get this PR to build so that we can merge it in. There's a few prerequisites for that, namely working around php-cs-fixer's lack of PHP 8 support and also hacking past PHPStan's errors regarding OpenSSL changes in PHP 8, such as this and this.

Given the large user base of this library, both directly and through Laravel packages, it's imperative that the release goes smoothly. The additional checks and balances performed by analysis tooling are there to pick up potential issues, so any workaround for their support for PHP 8 must be carefully considered.

I'm currently camping with limited internet access however I'm prioritising getting this PR to build so I can merge and release it.

@smares' suggestion is something I regularly do as well - you can read more on that here :)

Thanks!

from oauth1-client.

Submitted PR #128 to fix this.

from oauth1-client.

Great. Thanks!

from oauth1-client.

@bencorlett would you mind taking a look? Thanks!

from oauth1-client.

Sounds great, thx a lot

from oauth1-client.

@bencorlett any update on getting 1.9.0 out the door? Sorry to be a nuisance. Thanks!

from oauth1-client.

@bencorlett really sorry to be a nuisance buddy, but is there any chance of 1.9.0 getting tagged this week as I'm hoping to push a major new app version next week that uses this library with PHP 8?

from oauth1-client.

Because of issues like this in the past, we ended up creating a GitHub organization account where we fork all repositories we use in our projects. You can then decide whether to always use the own fork or only use the fork when a fix is taking too long in upstream. Pretty easy to do in composer.json with the repositories section.

from oauth1-client.

@bencorlett no worries mate. I've made a fork for now.

Enjoy time off with the family :)

from oauth1-client.

namely working around php-cs-fixer's lack of PHP 8 support

you can use PHP CS Fixer 2.18+ for PHP 8

from oauth1-client.

namely working around php-cs-fixer's lack of PHP 8 support

you can use PHP CS Fixer 2.18+ for PHP 8

Wonderful! I saw they released this a couple of days back. I've got a workaround in place and I have published v1.9.0, but I'll look to upgrade this at some point.

from oauth1-client.