Comments (11)
bencorlett
commented on July 20, 2024
1
@bencorlett Just tested with our Laravel app using socialite, all working perfectly!
Great! Thank you. This was a big oversight on my part and I really wanted to resolve this quickly. I've done some more testing on my end and I'm pretty comfortable it's looking good.
I'll be pushing v1.8.1 shortly with this in it :)
from oauth1-client.
bencorlett
commented on July 20, 2024
Interesting. The public api always indicated Via docblocks that an instance of OAuth1\Client\User should be returned so to not follow that would be mutually exclusive to expecting no breakages.
Having said that, I think if we are type declaring on other methods and that’s breaking inheritance, I will revert this change for now and it’ll just come with the new version (see PRs).
Thanks for the report!
…Sent from my iPhone
On 4 Sep 2020, at 6:15 pm, tobytwigger ***@***.***> wrote:
Hi all! I'm not sure what's considered the public API of this package, but the most recent update has broken the socialiteproviders/providers package which allows social logins in Laravel. It'll also have broken any custom OAuth providers which extend the League\OAuth1\Client\Server\Server class, due to the typehinting of the methods.
In this particular case, it's made more problematic by the fact that Laravel socialite defines its own user to return, so the typehintinh for getUserDetails cannot be met without changes in several repositories.
Was this release meant as a minor release, or should it be upgraded to a major to stop any existing extensions being broken?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
from oauth1-client.
tobytwigger
commented on July 20, 2024
Thank you! I think the reasoning was that the user model is used for OAuth2 too. Either way, a major version change will give time to fix this before upgrading - thanks! :)
from oauth1-client.
bencorlett
commented on July 20, 2024
@tobytwigger would you be able to help test this for me? If so, could you add:
"league/oauth1-client": "dev-fix/revert-public-api"To your composer.json and run composer update?
from oauth1-client.
bencorlett
commented on July 20, 2024
Here's a comparison between 1.7 and the fix branch. I think it all looks good, it's passing unit tests, linting and static analysis. A real world test would be great though and I will push out 1.8.1 with this.
from oauth1-client.
tobytwigger
commented on July 20, 2024
@bencorlett Just tested with our Laravel app using socialite, all working perfectly!
from oauth1-client.
tobytwigger
commented on July 20, 2024
Thanks a lot!
from oauth1-client.
bencorlett
commented on July 20, 2024
You're welcome. Thanks for pointing the issue out and helping resolve it :)
I'm just waiting on builds to pass then I'll tag up v1.8.1.
from oauth1-client.
shehi
commented on July 20, 2024
That's why it shouldn't have been 1.8 release but 2.0 release, to avoid BC implications 🤦 Now all that work done towards PHP 7.1-7.2 was undone, and twice at that.
from oauth1-client.
bencorlett
commented on July 20, 2024
That's why it shouldn't have been 1.8 release but 2.0 release, to avoid BC implications 🤦 Now all that work done towards PHP 7.1-7.2 was undone, and twice at that.
🤦♂️🤣👍👍
v2.0 (develop) is a rewrite. It took about 25 minutes to add php 7.1+ Language features to v1.8 and less to revert it, so I’m not too worried.
I am not interested in releasing 2.0, then 3.0 a few days later, I think this would not be worth the overhead.
from oauth1-client.
bencorlett
commented on July 20, 2024
@shehi i should add - do let me know your thoughts on v2 - I’d appreciate that.
I will be documenting it shortly and polishing it up!
from oauth1-client.
Related Issues (20)
- Twitter could not authenticate temporary credentials HOT 2
- Class 'Symfony\Component\EventDispatcher\Event' not found HOT 3
- Problem with league/oauth1-client version 1.6.2 upgrading to 1.7 HOT 3
- Guzzle HTTP Client configuration HOT 1
- Composer deprecation notices
- Composer psr-4 autoloading HOT 1
- baseString composition fails when port is specified in URI HOT 2
- [PHP 8] Warning on EncodesUrl HOT 17
- Options for authorization URL HOT 3
- Avoid "functions" from dependencies HOT 3
- Trello "An unknown application" HOT 2
- Last release is broken HOT 2
- SignatureInterface is not correctly imported after recent Twitter server changes
- Invalid oauth_verifier parameter
- PHP 8.1 support
- Not sure how to configure signature element
- Magento provider no longer works (outdated hash algorithm)
- Invalid auth/bad request Etsy
- Don't support proxy? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oauth1-client.