theos / headers Goto Github PK

View Code? Open in Web Editor NEW

323.0 323.0 92.0 1.22 MB

Headers. Not for documents. Not the opposite of footers.

License: Other

Objective-C 42.26% C 54.52% C++ 3.22%

objective-c

headers's Introduction

Theos

A cross-platform build system for creating iOS,
macOS, Linux, and Windows programs.

Home – Installation – Documentation – Get Help – @[email protected] – @theosdev – Discord

Contributors

Thanks to the following people for contributing to Theos in the past: Aehmlo, akemin-dayo, ARM64Darwin1820, ArtikusHG, benrosen78, brendonjkding, conradev, coolstar, DavidSkrundz, DGh0st, Diatrus, dlevi309, DuIslingr, elihwyma, eswick, evelyneee, hirakujira, inoahdev, kemmis, lechium, leptos-null, liuxuan30, mstg, Naville, neoighodaro, nin9tyfour, NSExceptional, opa334, PoomSmart, quiprr, r-plus, Rand01ph, ryannair05, sbingner, Shade-Zepheri, supermamon, theiostream, Tyilo, vsnrain

License

See LICENSE.md for licensing information.

headers's People

Contributors

Stargazers

Watchers

Forkers

ancool i11 xueshiqiao tenfar carlosjimenez dani0l djhartley dademurphy0742 hglabview cvan41890 caophuocthanh yi-gei ansani hvbird rand01ph lgq2015 ajbaabf happyholic1203 kensla pwn2w1n changeyourdestiny z8927623 crazypoo mail2chensh linsion xiehugo zzjconcent cgm616 imokhles andrewwiik mody199610 faku99 cracklee007 anglezhou xiaoleiwei shade-zepheri packetfahrer nightoftwelve sliverblackkm karajanyp ylcode3 michealminchan shrimantnikate snyxhd leptos-null lechium ohyeah521 kenkieo doc22940 4ch12dy corxit jannikcrack letsunlockiphone sbingner poomsmart ownermz effytax brendonjkding hirakujira nsexceptional korschen cashtony r3n3r0 maxomet l1ghtmann lacertosusrepo asterisch mwpcheung vonnkee13 zhaozhongke xxtouchng mostm 5l1v3r1 summer1988 neodouglas gamedevsajib apibug opa334 dlevi309 xvhuanlin-work a-sk233 strogo zgamant roothide arichornlover asdlei99 profiles duckdeve hikari-ahead

headers's Issues

Spam

(Objective-)C++ External linkage issues for global constants in PSSpecifier.h

Importing the PSSpecifier.h in (Objective-)c++ context gives the following errors:

...
==> Compiling api/HSWidgetCombinedAdditionalOptionsAndPreferencesViewController.mm (arm64)…
In file included from api/HSWidgetCombinedAdditionalOptionsAndPreferencesViewController.mm:1:
In file included from api/HSWidgetCombinedAdditionalOptionsAndPreferencesViewController.h:3:
In file included from api/HSWidgetPreferencesListController.h:5:
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:6:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSAccessoryKey; // @"accessory"
                ^
                               = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:7:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSActionKey; // @"action"
                ^
                            = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:8:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSAdjustFontSizeToFitWidthKey; // @"adjustFontSizeToFitWidth"
                ^
                                              = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:9:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSAlignmentKey; // @"alignment"
                ^
                               = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:10:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSAppGroupBundleIDKey; // @"appGroupBundleID"
                ^
                                      = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:11:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSAutoCapsKey; // @"autoCaps"
                ^
                              = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:12:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSAutoCorrectionKey; // @"autoCorrection"
                ^
                                    = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:13:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBestGuesserKey; // @"bestGuess"
                ^
                                 = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:14:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBundleCustomIconPathKey; // @"icon2"
                ^
                                          = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:15:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBundleHasBundleIconKey; // @"hasBundleIcon"
                ^
                                         = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:16:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBundleHasIconKey; // @"hasIcon"
                ^
                                   = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:17:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBundleIconPathKey; // @"icon"
                ^
                                    = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:18:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBundleIsControllerKey; // @"isController"
                ^
                                        = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:19:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBundleOverridePrincipalClassKey; // @"overridePrincipalClass"
                ^
                                                  = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:20:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBundlePathKey; // @"bundle"
                ^
                                = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:21:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSBundleTintedIconPathKey; // @"tintedIcon"
                ^
                                          = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:22:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSButtonActionKey; // @"buttonAction"
                ^
                                  = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:23:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSCancelKey; // @"cancel"
                ^
                            = 0
/home/dgh0st/theos/vendor/include/Preferences/PSSpecifier.h:24:17: error: default initialization of an object of const type 'NSString *const'
NSString *const PSCellClassKey; // @"cellClass"
                ^
                               = 0
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[3]: *** [/home/dgh0st/theos/makefiles/instance/rules.mk:201: /mnt/c/cygwin64/home/DGh0st/HSWidgets/.theos/obj/debug/arm64/api/HSWidgetCombinedAdditionalOptionsAndPreferencesViewController.mm.770ee366.o] Error 1
...

Notes:
For reference, the errors shown above are while compiling HSWidgets with latest Theos. But the issue is also reproduceable when creating a new empty preference subproject and including PSSpecifier.h in a Objective-c++ file (.mm).

Potential Root Cause:
I think the issue is the way these global constants are defined in PSSpecifier.h.

For C, following is the output after the pre-processor:

...
NSString *const PSAccessoryKey; // @"accessory"
NSString *const PSActionKey; // @"action"
NSString *const PSAdjustFontSizeToFitWidthKey; // @"adjustFontSizeToFitWidth"
...

By default C compiler provides external linkage for all non-static global variables so this works as expected.

For c++ global constants have internal linkage by default so we need the extern "C", which is what the __BEGIN_DECLS is responsible for. However c++ treats extern "C" blocks slightly differently when it comes to variables. According to the c++ standard, this is the difference that it has:

extern "C" int a; // declaration

extern "C" {
    int b; // definition
}

First is considered as declaration only, but second block statement is considered as a definition so the compiler needs to make sure memory will be created for b. If this were a const then it would require a default value. Which is the case for the PSSpecifier.h.

The way to make it not create space for the current translation unit, and ultimately not complain about the initialization, would be to either use:

extern "C" {
    extern int b; //  declaration
}

extern "C" int b; // declaration

(both of which are equivalent according to c++ standards)

Update openssl

Update openssl headers, they are quite old.

UITableViewHeaderFooterView.h prevents use of original header

Can't use UITableViewHeaderFooterView on iOS6 and up. Should add something like:

ifdef __IPHONE_6_0

include_next

...

Ambiguous expansion of macro

I'm getting a lot of Macro errors in GraphicsService.h when compiling my tweak, here is the full make troubleshoot https://ghostbin.com/paste/f34om

Data type issue

I don't think brightness level is stored and set as CGFloat. It should be just float. This might be a culprit of BrightVol (https://github.com/hbang/BrightVol) issues with arm64.

You can check out my fork here: https://github.com/PoomSmart/BrightVol

_Prefix/NullabilityCompat.h file is missing so compile fails

> Making all for tweak Hooker…
==> Preprocessing Tweak.xm…
==> Compiling Tweak.xm (armv7)…
In file included from <built-in>:184:
In file included from <command line>:5:
/opt/kirb/theos/Prefix.pch:6:10: fatal error: '_Prefix/NullabilityCompat.h' file not found
    #import <_Prefix/NullabilityCompat.h>
            ^
1 error generated.
make[3]: *** [.theos/obj/debug/armv7/Tweak.xm.a3e1ec91.o] Error 1
make[2]: *** [.theos/obj/debug/armv7/Hooker.dylib] Error 2
make[1]: *** [internal-library-all_] Error 2
make: *** [Hooker.all.tweak.variables] Error 2`

Spam

Substrate needs to be updated to the new version(included with unc0ver).

substrate.h doesn't include the new Function MSHookMemory.

nvm read this theos/lib#5

[Suggestion] Standardize .modulemap vendor location

What are the steps to reproduce this issue?

N/A

What happens?

N/A

What were you expecting to happen?

N/A

Any logs, error output, etc?

Any other comments?

Note: I am not well versed on clang modules/module maps.

Following the merge of the Orion theos/lib pr, half of the module maps provided by Theos will be located in the lib vendor directory while the other half, listed below, will be present in this repo. I believe the libraries corresponding to the various maps in this repo, save for Preferences, are vended by Theos, so it may be worth moving all module maps to the respective directories here or the respective directories in theos/lib for consistency.

./libundirect/module.modulemap
./Preferences/module.modulemap
./libactivator/module.modulemap
./AppList/module.modulemap
./libhooker/module.modulemap
./Flipswitch/module.modulemap
./rocketbootstrap/module.modulemap
./libprefs/module.modulemap

What versions of software are you using?

Operating System: …

Toolchain Version: …

SDK Version: …

Code Style

Per README:

Follow the existing coding style

There are many different styles throughout the headers, even ignoring vendor headers (e.g. openssl).

I believe there should be a more unified, and explicit style.

Examples of different existing styles

Availability attribution:
- SpringBoard/SBApplication.h uses NS_AVAILABLE_IOS, and NS_DEPRECATED_IOS
- BatteryCenter/BCBatteryDevice.h uses API_AVAILABLE (I don't see instances of the equivalent API_DEPRECATED in this repo)
External declarations:
- Preferences/PSSpecifier.h uses __BEGIN_DECLS
- GraphicsServices/GSCapability.h uses the #if __cplusplus \\ extern "C" { \\ #endif idiom (mostly equivalent to __BEGIN_DECLS)
- Flipswitch/FSSwitchState.h uses extern, without any C++ linkage indicator.
- I didn't see any instances of it, but Apple's SDKs also use OBJC_EXTERN and FOUNDATION_EXTERN
Property attributes (ObjCSpaceAfterProperty):
- BaseBoard/BSProcessHandle.h uses @property (attributes) type;
- SpringBoard/SBAppSwitcherPeopleDataSource.h uses @property(attributes) type

Style discussions are sometimes criticized, because developers have different opinions on how code should be formatted, however I mention these three because I've seen issues arise in due to these in particular.

Availability attributions are important, especially for projects such as this one, where private system APIs are sometimes documented. Deciding on an attribution system allows developers to contribute more easily and effectively.

External declarations must be accurate when using C++, to avoid linking errors. Theos used to create ObjC++ source files by default. A unified extern marking system would avoid issues such as FSSwitchState.h missing a C++ linker hint.

Property attributes are very strongly a style choice, but I mention it due to #21 changing these property declarations. It could be bothersome, if someone felt compelled to change them back, or if new changes are made with no property trailing space, and someone else goes to change those.

update AppList

update https://github.com/rpetrich/AppList header ad lib

theos / headers Goto Github PK

headers's Introduction

Contributors

License

headers's People

Contributors

Stargazers

Watchers

Forkers

headers's Issues

ifdef __IPHONE_6_0

include_next

What are the steps to reproduce this issue?

What happens?

What were you expecting to happen?

Any logs, error output, etc?

Any other comments?

What versions of software are you using?

Examples of different existing styles

Recommend Projects

Recommend Topics

Recommend Org