theopolisme / jquery-fullscreen Goto Github PK

From comment at 050b6bf#commitcomment-4791918

The more involved version is to have enterFullscreen retrun a promise, and only resolve it successfully if after ~100ms there was no error event. That would also take care of the WebKit Element.ALLOW_KEYBOARD_INPUT mess and failures to go fullscreen when you issue the command at the wrong moment.

Most browsers have a "manual" fullscreen mode, which can be initiated with F11, and looks identically to the fullscreen mode initiated via the Fullscreen API, but is completely different on an API level (no event, no document.fullscreenElement, the :fullscreen selector does not match etc). I'm wondering if it made sense for the plugin to detect those and issue a fullscreen event (or maybe a separate fake fullscreen event).

There is no clean way to detect the manual fullscreen, but allegedly listening for resize and then comparing screen width and viewport width does the trick.

Since this is now upstream instead of downstream in MediaWiki, please take care of linting on this side.

The easiest way to do this is probably via npm (locally) and Travis (publicly for GitHub).

MMV is licensed under the GPLv2. By distributing a derivative work under the MIT license, you are violating section 2, subsection b of the GPL. Please license this library under the GPLv2 license.

Thanks!

EDIT: Changed title - it might not be a violation, but it's certainly a complication, and I'd like to avoid that if possible.