thenkei / underthelimits Goto Github PK

Add a sound when a new message arrive in the chat

Copy game URL to clipboard on party

I might have done something wrong here
https://github.com/Thenkei/UnderTheLimits/blob/master/client/src/reducers/chat.js

Will check tomorrow

Made a little plantUML basic card game workflow.

@startuml

title Basic card game workflow

start

:onCreateGame();
while (isGameReady()) is (false)
    :onWaitingPlayers();
endwhile (true)
:onGameReady();
:onGameStart();
while (isGameOver()) is (false)
    :onRoundStart();
    while (isRoundOver()) is (false)
        :onTurnStart();
        :onPlayingTurn();
        :onTurnEnd();
    endwhile (true)
    :onRoundEnd();
endwhile (true)
:onGameOver();
:onGameEnd();

stop

@enduml

Could give some kind of abstraction on client side, and would be way easier to add any kind of card game

Made this on to define once and for all a basic and extensible protocol for UTL related stuff

I prefixed all the "message" with an identifier, so redux code will be easier to segment.

• ON - connection : (client)

• ON - disconnect : EMIT - lobby/update && if connected to channel channel/update && (if don't reconnected => disconnect from game after 45 s)

• ON - init/createPlayer : ({player})

  • EMIT - INITIATOR ONLY - init/playerCreated : () => ({player}) # Send created user
  • JOIN IO ROOM -> LOBBY # Since user exist, add it to lobby
  • EMIT - `lobby/update

• ON - channel/create : ({channel})

  • EMIT - lobby/update # Update lobby with new channel
  • EMIT - INITIATOR ONLY - channel/created
  • EMIT - channel/update # Contains info to redirect the user to the correct page

• ON - channel/join : ({channelId})

  • EMIT - lobby/update : () => ({lobby}) # Update lobby, without initiator
  • JOIN IO ROOM -> UTL_GAME_ROOM(channelId) # Since user exist, add it to lobby
  • EMIT - channel/update: # Update current channel for all player # contains info to redirect the user to the correct page

• ON - utl/nextRound : ()

  • EMIT - channel/update # Update current channel for all player

• ON - utl/selectedAnswers : ({answers})

  • EMIT - channel/update: # Update current channel for all player

• ON - utl/selectedJudgment : ({judgment})

  • EMIT - channel/update: # Update current channel for all player

We should also strictly define and serialize response message sent from the server in order to avoid ppl looking trough js code to find opponents card

EMIT - lobby/update

{
  $id: 'lobby',
    type: 'object',
    properties: {
      lobbyUsers: { type: 'User', default: '' },
      channels: {
       name: {type: 'string', default: '' },
       id: {type: 'integer', default: '' },
    },
  };

EMIT - channel/update (UTLGame & UTLPlus (protocol)

{
  $id: 'channel',
    type: 'object',
    properties: {
      id: {type: 'integer', default: '' },
      name: {type: 'string', default: '' },
      admin: {type: PLAYER (NEED TO BE CHANGED)},
      players: {
       id: {type: 'integer', default: '' },
       name: {type: 'string', default: '' },
       score: {type: 'integer', default: '0' },
       hand: {type: Answer, default: '' },
       answers: {type: Array[type: 'integer'], default: '0' },
       isGameMaster: {type: 'boolean', default: '0' },
      },
      currentStatus: {type: 'string', default: 'IDLE' },
      timer: {type: 'integer', default: '0' },
      deckQuestion: {type: 'string', default: '' },
    },
  };

This is the UTL games definition of a channel.

EMIT/ON/EMIT - INITIATOR ONLY : BROADCAST/ON NEW REQ RECEIVED/SEND RES ONLY TO THE SPECIFIC CLIENT

Change to npm run build

MUI - Typo on text when user win

Use home made serializer in order to reduce data during channel class updates through socket, don't send deckAnswers and deckQuestions anymore !

• 404
• Legals ? ( Service-public )
• SEO ? robot.txt ?
• Add github link for github related features (Issues, stars, ...)?

MUI - Cant use enter to send message

Add max length on Questions/Answers model text property (Mainly for style purposes)

We need to change Socket server side API in order to make the following wssFunctionType work.

Reducer

Another implementation:

export function wssCreatePlayer(wsCreatePlayerReq) { 
   return (dispatch) => { 
     dispatch(createPlayerRequest()); 
     createPlayer(wsCreatePlayerReq, (err, wsCreatePlayerRes) => { 
       if (wsCreatePlayerRes) {
         // eslint-disable-next-line prefer-destructuring 
         id = wsCreatePlayerRes.id; 
         dispatch(createPlayerSucess(wsCreatePlayerRes)); 
         retrurn;
       }
       dispatch(createPlayerFailure(error));
     }); 
   }; 
 } 

Client API

Changes:

 function createPlayer(playerName, cb) { 
   global.socket.emit('createPlayer', playerName); 
   global.socket.on('playerCreated', lobbyResponse => cb(lobbyResponse.error, lobbyResponse.player)); 
 } 

Server API

Becomes:

client.emit('playerCreated', { error: err.message });

So, we need to talk about this and also about the RESQUEST -> FAILLURE | SUCCESS system.

CSS rule to see UI hints when picking cards

For now, "development" mode is used to build qa. We should only use "production" style kind of build, since it improve performances and security

Click on logo should bring back to home page, with a modal asking if player is sure he want to quit the game

Allow admin to kick player ?

Modal is not working after updating to react-bootstrap 1.0.0-beta5

Missing room name validation

Regex for room name should be the same as username

Need to update the channel socket

io.to(channel.id).emit('updateChannel', channel.serialize());

PS: Look further at direct disconnection versus dangling disconnection

We could really use a simple bot to run game on dev env

The model do have the information now.

White text on white background on Select component

Remove question card when everyone is waiting

Since we do only 2 calls on app start, Mysql might be a little bit too much 🤣
docker-compose-dev.yml should start way faster

Client side - Socket reception & display component
Sever side - Socket emit to channel & Timer management

Message on game are pretty strange. "A toi de jouer" is displayed for all players, even if it's not their turn to vote

A new column is here to qualify the answer gramma. Value definition as following :

0 = NounsMale
1 = NounsFemale
2 = NounsPlural
3 = Verbs
4 = ProperNoun

This will be use for statistics and for gammar automation.

Snackbar animation is missing when snackbar disappear

Deployment should fully delete the pod. We should use classic k8s flow to reduce downtime between deployments

We should more timer (On winner vote, on admin next round, ...)

BUG : range start value > to end value

As a Player, I want to be able to share "private" url so I can play with friends.

Channel id shouldn't be sequential, and we should generate semi random channel id. Adding private room feature would be easy since we can handle this on client only

We're missing style for private messages and system messages

Current dev deploy is not working correctly on CircleCI

A player got disconnected just before this call and server crashed.

utl-server    | channel Salon4Jardin next round starting...
utl-server    | Player Sigmund  got disconnected from lobby
utl-server    | Player removed from channel
utl-server    | /server/index.js:181
utl-server    |         currentPlayer.answers = answers;
utl-server    |                               ^
utl-server    |
utl-server    | TypeError: Cannot set property 'answers' of undefined
utl-server    |     at Socket.client.on (/server/index.js:181:31)
utl-server    |     at Socket.emit (events.js:182:13)
utl-server    |     at /server/node_modules/socket.io/lib/socket.js:528:12
utl-server    |     at process._tickCallback (internal/process/next_tick.js:61:11)
utl-server    | [nodemon] app crashed - waiting for file changes before starting...

In a channel, when the admin start a game, the game will automatically run until it ends or channel don't have enough players to pursue.

Simple tchat implementation.

Will be then used in lobby and channels.

Remove Cards display when not needed

Bring Legals and github link back to life, even if for now, they doesn't contains a lot of things

The value state is unused. Can the component not render if I remove the setState (link below) ?

Adding an UTL_PORT process env for both client and server should do it for now

When creating the game, the salon creator can choose several parameters:

• number of points to accumulate to win the game
• maximum number of players and spectators in the game (example: min 3, max 8)
• Play the Vanilla version or the "UTL PLUS" version
• the deck he wants to use (for "UTL PLUS" versions)
• change the method of allocation of points, indicate to the creator of the show that he must provide
  a higher point limit and explain the difference (for "UTL PLUS" versions)

Global revamp for react components and CSS

Missing cursor pointer on UTL logo :/

Rel. to #97