Git Product home page Git Product logo

combustivefishing's People

Contributors

combohrenovke avatar eslym avatar theillusivec4 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

combustivefishing's Issues

Cant Make The Rod

Versions 1.12.2 Combustive Fishing:

  • Forge: 1.12.2-14.2.3.5.2825

Observed Behavior: Cant make the blazing rod

Expected Behavior: The blazing rod should be made

Steps to Reproduce:

  1. Combining all the materials in the crafting table gives me nothing

searing sword rebalacing

I was wondering if you could rebalance the searing sword since it has a higher attack speed than most weapons in the vanilla game and does a higher base dmg. I was wondering if you could rebalance it to match vanilla more. If not that is fine but I would rather know why.

[1.12.2] The golden fishing rod does not provide the player in loot context when generating loot

The golden fishing rod does not provide the player in loot context when generating loot, as the vanilla fishing pole does. This causes loot conditions referencing the player's location to automatically fail when they are called in the fishing/junk/treasure loot pools.

For example, as a pack maker I created a script which replaced the fishing loot pool with one that checked the player's biome and allowed different fish to be caught in different biomes using morelootstuff's in_biome condition. This worked great for the vanilla fishing pole, but caused the golden fishing rod to be unable to catch any of those fish.

Thanks!

Using:
Combustive Fishing 1.0.3.2
Minecraft 1.12.2
Forge 2768

Suggestion: Making Items immune to lava

Any items which can be fished out of lava should not burn inside of lava. It doesn't make sense for items that are from lava to burn in lava. (Also, the fact that items burn in lava seem to be the cause of an incompatibility with fishing overhaul[They are incompatible, what I'm guessing is whether or not that is the cause])

Using Dedicated Server, Bobber entity breaks registry then makes client unable to read any packets.

Versions (Be specific, do not write "latest"):

  • Combustive Fishing: 4.0.0.1
  • Forge: 1.16.5-36.2.22

Observed Behavior:

the log shows that the bobber entity provided by this mod breaks during registry trades between dedicated server and client. then the client log spams as it gets a null for every packet received, making the client freeze and unable to connect to server.

Expected Behavior:

this should not occur. I believe the issue is caused by differences in the forge API between 1.16.3 and current.

Steps to Reproduce:

  1. use the mod on a dedicated server
  2. try to connect to the server
    ...

Crash Log: https://pastebin.com/1hXMB9cL

Further info: I just discovered this, I have yet to test for mod collisions, will provide a new log if I eventually get around to testing with minimal mod selection

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.