thefox6 / factory Goto Github PK

The industrial miner and upgraded industrial miner cause a crash almost immediately after placement when areas protection is installed (and probably other protection mods). It crashes regardless of whether or not the miner is in a protected region.

2018-05-24 13:01:14: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback LuaABM::trigger(): Invalid position (expected table got nil).
2018-05-24 13:01:14: ERROR[Main]: stack traceback:
2018-05-24 13:01:14: ERROR[Main]: [C]: in function 'get_areas_for_pos'
2018-05-24 13:01:14: ERROR[Main]: /home/user/.minetest/mods/areas/api.lua:22: in function 'getAreasAtPos'
2018-05-24 13:01:14: ERROR[Main]: /home/user/.minetest/mods/areas/api.lua:76: in function 'canInteract'
2018-05-24 13:01:14: ERROR[Main]: /home/user/.minetest/mods/areas/interact.lua:4: in function 'is_protected'
2018-05-24 13:01:14: ERROR[Main]: /home/user/.minetest/mods/factory/machines/miner.lua:100: in function </home/user/.minetest/mods/factory/machines/miner.lua:88>
2018-05-24 13:01:14: ERROR[Main]: stack traceback:
2018-05-24 13:01:14: ERROR[Main]: [C]: in function 'get_areas_for_pos'
2018-05-24 13:01:14: ERROR[Main]: /home/user/.minetest/mods/areas/api.lua:22: in function 'getAreasAtPos'
2018-05-24 13:01:14: ERROR[Main]: /home/user/.minetest/mods/areas/api.lua:76: in function 'canInteract'
2018-05-24 13:01:14: ERROR[Main]: /home/user/.minetest/mods/areas/interact.lua:4: in function 'is_protected'
2018-05-24 13:01:14: ERROR[Main]: /home/user/.minetest/mods/factory/machines/miner.lua:100: in function </home/user/.minetest/mods/factory/machines/miner.lua:88>

This crash falls a little outside my scope of understanding and I will not be available to attempt to fix this crash for a few days so I just thought I'd open an issue for now.

Is your feature request related to a problem? Please describe.
It is a bit limiting that the only source of power is fuel, also it's rather monotone.

Describe the solution you'd like
It would be nice to have some alternative power sources, like biofuel/biogas, wind, water or solar.

Describe alternatives you've considered
The electricity could also be transformed from other mods electricity.

There could also be a fuel that is generated with different sources, but that would be kind of weird and unintuitive.

Additional context
The idea stems from Nielzie's forum post.

Describe the bug
Starting Miner machine caused minetest to exit with error

To Reproduce
If known, steps to reproduce the behavior:

1. Place miner
2. See error

Expected behavior
The the miner would do its thing and mine

Screenshots
If applicable, add screenshots to help explain your problem.

Log
from error screen on exit:
AsyncErr: Lua: Runtime error from mod 'factory' in callback LuaABM::trigger(): D:\Games\Minetest\bin..\mods\factory/machines/miner.lua:253: attempt to index local 'registered' (a nil value)
stack traceback:
D:\Games\Minetest\bin..\mods\factory/machines/miner.lua:253: in function <D:\Games\Minetest\bin..\mods\factory/machines/miner.lua:228>

from debug.txt:
2023-11-24 13:11:37: ERROR[Main]: stack traceback:
2023-11-24 13:11:37: ERROR[Main]: D:\Games\Minetest\bin..\mods\factory/machines/miner.lua:253: in function <D:\Games\Minetest\bin..\mods\factory/machines/miner.lua:228>
2023-11-24 13:11:37: ACTION[Server]: [doc] Wrote player data into D:\Games\Minetest\bin..\worlds\Mining Town/doc.mt.
2023-11-24 13:11:37: ACTION[Server]: singleplayer leaves game. List of players:
2023-11-24 13:11:38: ACTION[Main]: Server: Shutting down
2023-11-24 13:11:38: ACTION[Main]: [doc] Server shuts down. Player data is about to be saved.
2023-11-24 13:11:38: ACTION[Main]: [doc] Wrote player data into D:\Games\Minetest\bin..\worlds\Mining Town/doc.mt.
2023-11-24 13:11:38: ACTION[Main]: [Tubelib] Store data...
2023-11-24 13:11:38: ACTION[Main]: [Tubelib] Data stored. t=297us

Desktop (please complete the following information):

• Minetest version: 5.7.0
• Other mods activated:
  3d_apple, 3d_armor, ambience, amethyst_new, animalworld, anvil, area_containers, artdeco, auroras, awards, bakedclay, banner, basic_materials, beds, biofuel, biomeinfo, biome_lib, bonemeal, bows, bricks_plus, bucket, bucket_wooden, builtin_item, carpets, castle_farming, castle_gates, castle_lighting, castle_masonry, castle_shields, castle_storage, castle_tapestries, castle_weapons, connected_chests, controls, cottages, cracked_castle, craftguide, darkage, decorations_sea, deepslate, diggicontrol, digilines, digistuff, digtron, display_modpack, doc, doc_basics, doc_encyclopedia, doc_identifier, doc_items, doors, drinks, ebiomes, ethereal, etherium_stuff, everness, factory_bridges, farming, flowerpot, geodes_lib, glass_stained, handle_schematics, hangglider, hopper, illumination, itemframes, item_drop, leads, leather_armor, livingcaves, livingcavesmobs, livingdesert, livingfloatlands, livingjungle, livingnether, loot, lwcomponents, lwscratch, marinara, marinaramobs, mesecons, mesecons_carts, mesecons_x, micupack, minecart, mobkit, mobs, mobs_monster, mobs_skeletons, mobs_sky, mobs_water, mob_horse, modlib, modname_tooltip, modutil, moreblocks, moredecorations, morelights, moreores, moretorches, moretrees, music_modpack, nativevillages, naturalbiomes, nether, new_campfire, obsidianstuff, paintings_gallery, paintings_lib, pipeworks, pipunhole, plantlife_modpack, plaster, powerbanks, redef, regrowing_fruits, rnd, ropes, scaffolding, servercleaner, shallow_ores, signs_lib, simple_furniture, skinsdb, slats, stackslabs, stainedglass, stripped_tree, sugar, swamp, technic_plus, technic_recipes, techpack, tga_encoder, torch_bomb, tpad, ts_furniture, tt, tubelib2, unifieddyes, unified_inventory, variety, visible_sneak, void_chest, we_undo, wilhelminessounds, wine, woodcutting, worldedit, worldedit_hud_helper, xdecor, xmaps, x_enchanting, x_farming, factory

There seems to be a problem with the movers: somehow they either make items become more or they make them become less.
I don't really know what the problem is right now, but I'll try to find out...
please give me a hint if you have got an idea, what might be the problem.

machines/crafting.lua should contain a recipe for factory:stp; it doesn't currently.

This old code is not really handsome, someone ought to fix it up.
Some details what is not up to good coding standards are given in the log of the last luacheck.

The industrial miner crash when starting to work, if the minecart mod is loaded.
2020-09-24 19:00:03: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'factory' in callback LuaABM::trigger(): Invalid position (expected table got nil). 2020-09-24 19:00:03: ERROR[Main]: stack traceback: 2020-09-24 19:00:03: ERROR[Main]: [C]: in function 'get_node' 2020-09-24 19:00:03: ERROR[Main]: /home/user/.minetest/mods/minecart/protection.lua:45: in function 'is_protected' 2020-09-24 19:00:03: ERROR[Main]: /home/user/.minetest/mods/factory/machines/miner.lua:88: in function </home/user/.minetest/mods/factory/machines/miner.lua:78>

I don't know, which of the two should/could fix it.
joe7575/minecart#4 (comment)

Is your feature request related to a problem? Please describe.
Why does the factory:combustion_generator use a ABM (Line 64) rather than a nodetimer?

Describe the solution you'd like
I feel the ABM works but so would using the nodetimer. (Just a dev looking at another persons code)

Describe alternatives you've considered
The only difference between the 2 is all factory:combustion_generators consume fuel and produce energy at the same time, where as the nodetimer would vary the energy as each fire at different times (since it would be almost impossible to place and activate them within a second).

Additional context
This is just a question, not an issue and/or really not even a feature request. (Just a dev looking at another persons code, that's all)

If you remove the smoketube from a burning furnace the fuel consumption is stopped and it stays in the burning animation