theeadie / playerrank Goto Github PK

It should be possible to rank people on a points basis depending on their position. This would allow for ranks in a similar way to how they are calculated for motor racing (e.g. F1)

The method signature of League.GetLeaderboard() implies it returns a new leaderboard each time. Instead it returns the pointer to the passed leaderboard now updated.

It would be better if the passed leaderboard was not mutated as part of the method call.

There should really be xml documentation for all the public API methods

Lowest points strategy should probably be rewritten to specify the number of games to count rather than a complex discard policy. Any games where the player is not competing should count as total players + 1.

In both adding a result and getting information back from the league the concepts of score and rank should be separate.

There should be some documentation for each of the features of the library and some detailed information for each scoring strategy

I'd like a way of getting the change in both Points and Position from the previous result when recording a game for each player.

This is not really needed as the project is always consumed as a nuget package

Since we're calculating them all anyway whenever we ask for the current leader board we might as well throw them in a collection and return it to a consumer.

Should add some helper objects for positions e.g. Position.First or Position.Second