Git Product home page Git Product logo

fem-easybank's People

Contributors

irisdiakoumi avatar thecodercoder avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

fem-easybank's Issues

Mobile menu doesn't close on pressing escape key

@thecodercoder

What
The burger mobile menu doesn't close on pressing escape key

Why
Edge case is not handled either in JS or CSS code

Fix
JavaScript code to close the modal

document.addEventListener("keyup", (event) => {
  if (event.keyCode === 27 && header.classList.contains("open")) {
    header.classList.remove("open");
    body.classList.remove("noscroll");
    fadeElems.forEach(function (element) {
      element.classList.remove("fade-in");
      element.classList.add("fade-out");
  });
  }
});

Also
Moving the code to close the modal into a function to maintain DRY

const closeModal = () => {
  header.classList.remove("open");
  body.classList.remove("noscroll");
  fadeElems.forEach(function (element) {
    element.classList.remove("fade-in");
    element.classList.add("fade-out");
  });
};

document.addEventListener("keyup", (event) => {
  if (event.keyCode == 27 && header.classList.contains("open")) {
    closeModal();
  }
});

Card Title needs to be bigger

Hey Jessica,

I just visited the website and in my opinion I think that the title in the cards seem to be a bit too small. Apart from this everything else seems to be great visually.

Kindly make the necessary changes

Cheers

Burger menu still open after resizing

The burger menu is still open after resizing the window to large displays. I have this suggestion to scripts.js

const btnHamburger = document.querySelector('#btnHamburger');
const body = document.querySelector('body');
const header = document.querySelector('.header');
const fadeElements = document.querySelectorAll('.has-fade');

const closeHamburgerMenu = () => {
  body.classList.remove('no-scroll');
  header.classList.remove('open');
  fadeElements.forEach(function (element) {
    element.classList.remove('fade-in');
    element.classList.add('fade-out');
  });
};

const openHamburgerMenu = () => {
  body.classList.add('no-scroll');
  header.classList.add('open');
  fadeElements.forEach(function (element) {
    element.classList.remove('fade-out');
    element.classList.add('fade-in');
  });
};

const handleResizeWindow = () => {
  if (window.innerWidth > 1023) {
    closeHamburgerMenu();
  }
};

btnHamburger.addEventListener('click', function () {
  if (header.classList.contains('open')) {
    closeHamburgerMenu();
  } else {
    openHamburgerMenu();
  }
});

window.onresize = handleResizeWindow;

settings.json

Dear @thecodercoder you wrote to description of the video, "you can write that snippet
"liveSassCompile.settings.formats": [
{
"format": "expanded",
"extensionName": ".css",
"savePath": "/dist",
"savePathSegmentKeys": null,
"savePathReplaceSegmentsWith": null
}
],
but I get Property savePathSegmentKeys is not allowed.
Property savePathReplaceSegmentsWith is not allowed.
What can I do for dismiss these errors?
thanks for the responding to this issue from now on.

logo.svg

<footer class="footer"> <div class="container"> <a class="footer__logo" href="#"> <img src="/images/logo-dark.svg" /> </a>
we haven't a logo-dark.svg in images file unfortunately. did you see?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.