Forge: 1.12.2-14.23.5.2855
Fishing Made Better: 2.0.1
Thermal Expansion: 5.5.7.1

I tried adding this to my private 1.12 modpack and crashed with the following error:

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Thermal Expansion (thermalexpansion)
Caused by: java.lang.NullPointerException
    at net.theawesomegem.fishingmadebetter.common.recipe.RecipeFishBucket.matches(RecipeFishBucket.java:27)
    at net.minecraft.item.crafting.CraftingManager.findMatchingResult(CraftingManager.java:199)
    at cofh.core.util.helpers.ItemHelper.getCraftingResult(ItemHelper.java:282)
    at cofh.thermalexpansion.util.managers.machine.SawmillManager.initialize(SawmillManager.java:103)
    at cofh.thermalexpansion.ThermalExpansion.initManagers(ThermalExpansion.java:165)
    at cofh.thermalexpansion.ThermalExpansion.postInit(ThermalExpansion.java:109)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at net.minecraftforge.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:637)
    at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
    at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
    at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
    at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
    at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
    at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
    at com.google.common.eventbus.EventBus.post(EventBus.java:217)
    at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219)
    at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
    at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
    at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
    at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
    at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
    at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
    at com.google.common.eventbus.EventBus.post(EventBus.java:217)
    at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136)
    at net.minecraftforge.fml.common.Loader.initializeMods(Loader.java:754)
    at net.minecraftforge.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:336)
    at net.minecraft.client.Minecraft.init(Minecraft.java:535)
    at net.minecraft.client.Minecraft.run(Minecraft.java:3931)
    at net.minecraft.client.main.Main.main(SourceFile:123)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

After scooping around some code, I suspect the following line causing it:
RecipeFishBucket.java#L27

since within the snippet of Thermals erroring code, it passes null as the world argument when generating its recipes for machines:
ThermalExpansion/.../SawmillManager.java#L103

Basically title. I find it unimmersive that you can put void and lava fish in the water bucket without fish dying from cold / suffocating in water.

I was just fishing in RLCraft and this error crashed the game:

java.lang.NullPointerException: Ticking player
at net.theawesomegem.fishingmadebetter.common.event.FishingEventHandler.onPlayerFish(FishingEventHandler.java:167)

Checking the line 167, it has this:
if((ConfigurationManager.server.skipMinigame || fishingData.getFishDistance() >= (fishingData.getFishDeepLevel()-10)) && chunkFishingData.getFishes(world.getTotalWorldTime()).get(fishCaughtData.fishId).getQuantity() > 0)

Could it be that any of these variables became Null and that wasn't checked before this line?

This error happened once in aprox. 5hrs of constant fishing, so I would say is difficult to reproduce.

Attached latest.log and crash report:
latest.log
crash-2024-03-04_15.00.15-server.txt

Charm's Salvage enchant causes the rod to drop itself at 0 uses left, in order for it it be repaired instead of breaking. Attachments that still have durability are meant to be removed from the rod and dropped on the ground when it breaks, however the rod that is dropped by Charm still has these attachments on them, as well as dropping the attachments on the ground.

i'd like it to be in 1.16, but it's ur choice

Hi, I just started playing with friends on an RLcraft private server. When trying to fish, we get the message 'There doesn't seem to be biting anything here.' It's working on non-server. We also set up bait traps and tried putting in raw meat, carrots (as seen on YouTube), but we get a message that it's not a valid bait. We tried toggling flying on and off (left it on). Is there any way to fix this?

Edit: We tried it in rivers, shallows, oceans and it doesn't seem to be working, we tried to dig up 3x3 with baiting box inside which didn't help too. Tried different rods with differend bobbers and still same issue. Combining rod + bait in crafting doesn't work too. Tracker doesn't find anything too.

Hi,
I love your mod so much but in the last time I have hope you add this little think but this is not make. I play many time in normal Worlds and for my Projects of an Advanture Maps etc. build I many times on Flatworld maps. But your minigame in this mod work only in Normal Worlds. I hope you and your team can add the minigame workable in flatworlds in the next update.

MFG
Titoo8899

crash-2022-09-28_09.57.29-server.txt
When a fishing rod from Fishing Made Better is cast into a body of water with fish in it (ex: rivers or oceans, not small lakes), and Entity Purger is installed, the game crashes. It appears to have something to do with Entity matching? Here's the repo for Entity purger.
Fishing Made Better v2.2.4
Entity Purger v1.2.3
Forge 14.23.5.2860
https://www.curseforge.com/minecraft/mc-mods/entity-purger

I originally posted this issue at Wicked7000/EntityPurger#1, but the author seems to be entirely inactive.

I am fishing with:

• Iron Fishing Rod
• Long Cast Reel
• Heavy Bobber
• Shiny Hook

When I am in the minigame, I will have the tension bar over the fish and it is actively reeling in the fish. Suddenly, I get kicked out of the minigame without any indicator telling me why. The distance text colour is green but still kicks me out. It will use up my bait but not my durability. This is not a problem with fish less than 90m away. I've been trying to catch a whale but I am not sure why I keep getting kicked out despite other people being able to catch a whale with the same fishing set up.

Not an issue, but I was wondering if it was possible to disable the fishing minigame and just get the fish like in normal minecraft?

for reasons unknown each time anyone on the modded server wins the fishing minigame it disconnects us with an internal error message

far as I can tell this is the code that displays before the crash

net.minecraft.util.ReportedException: Ticking player
at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:459) ~[oq.class:?]
at net.minecraft.network.NetHandlerPlayServer.func_73660_a(NetHandlerPlayServer.java:173) ~[pa.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:209) ~[NetworkDispatcher$1.class:?]
at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:285) ~[gw.class:?]
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180) [oz.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:790) [MinecraftServer.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) [nz.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_312]
Caused by: java.lang.NoSuchMethodError: levelup2.skills.SkillRegistry.getSkillLevel(Lnet/minecraft/entity/player/EntityPlayer;Ljava/lang/String;)I
at net.theawesomegem.fishingmadebetter.util.LevelUpLoot.getFishingLoot(LevelUpLoot.java:42) ~[LevelUpLoot.class:?]
at net.theawesomegem.fishingmadebetter.util.LevelUpLoot.doLevelUpLoot(LevelUpLoot.java:20) ~[LevelUpLoot.class:?]
at net.theawesomegem.fishingmadebetter.common.event.FishingEventHandler.onPlayerFish(FishingEventHandler.java:225) ~[FishingEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_1581_FishingEventHandler_onPlayerFish_ItemFishedEvent.invoke(.dynamic) ~[?:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) ~[EventBus.class:?]
at net.minecraft.entity.projectile.EntityFishHook.func_146034_e(EntityFishHook.java:522) ~[acf.class:?]
at net.theawesomegem.fishingmadebetter.common.item.fishingrod.ItemBetterFishingRod.func_77659_a(ItemBetterFishingRod.java:73) ~[ItemBetterFishingRod.class:?]
at net.theawesomegem.fishingmadebetter.common.event.FishingEventHandler.onPlayerTick(FishingEventHandler.java:380) ~[FishingEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_1578_FishingEventHandler_onPlayerTick_PlayerTickEvent.invoke(.dynamic) ~[?:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) ~[EventBus.class:?]
at net.minecraftforge.fml.common.FMLCommonHandler.onPlayerPreTick(FMLCommonHandler.java:365) ~[FMLCommonHandler.class:?]
at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:190) ~[aed.class:?]
at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:382) ~[oq.class:?]
... 9 more
[22:58:57] [Server thread/INFO] [minecraft/NetHandlerPlayServer]: LoneWolfGmer lost connection: Internal server error

When I complete the fishing minigame with level up reloaded installed I get a crash here is the report.
crash-2022-07-14_00.43.34-server.txt

So, recently i've been playing RlCraft and i wanted to go fishing with a new diamond rod modified with the fast rell, obsidian bobber and the shiny hook.
When i try to fish with that fishing rod it keeps sinking under water, so the question is
Is there any chance that a new mod update of RlCraft is having issue with fishing-made-better or it's a new mechanic that i don't know?
Hope you find this post useful.
Take care!

Version: 2.2.4
Issue: When crafting Wooden Fishing Rod from an Ancient Fishing Rod, all the enchants on the latter are lost.
Possible solutions:

• Replace Ancient Fishing Rods with Wooden Fishing Rods in drop tables
• Change crafting recipe of Wooden Fishing Rod to Anvil from Workbench

Advanced Fishing 1.12.2-1.3.3 (knife recipes are displayed in the JEI, but do not work)
Aquaculture 1.12.2-1.6.8 (knife recipes are displayed in the JEI, but do not work)
Fishing Made Better 1.12.2-2.2.4
Forge 1.12.2 - 14.23.5.2860

# Replace/remove/override/add AdvancedFishing recipes to work better with this mod? (Does nothing if AdvancedFishing is not installed)
B:"AdvancedFishing Recipe Override"=true
# Replace/remove/override/add Aquaculture recipes to work better with this mod? (Does nothing if Aquaculture is not installed)
B:"Aquaculture Recipe Override"=true

I've tried in my full modpack, as well as a freshly-made instance with just the 3 mods, I can't craft fish fillets/drops from fish using knives. Would like to avoid making recipes in CraftTweaker2 for all of them if I can help it.