theawesomegem / blockdropstweaker Goto Github PK

MC 1.12.2
1.12.2-forge1.12.2-14.23.2.2611 or 2624
BlockDropsTweaker-1.12.2-2.4.jar

Started with empty /config/blockdropstweaker/blockdrops.json
Commands used:
/bd block add ore:logWood *
/bd block tool add minecraft:iron_axe *
/bd block tool add minecraft:diamond_axe *
/bd save
blockdrops.json: https://pastebin.com/w2kjzpT9

Only the first tool in the "tools" list is recognized for the block. The the configuration above, any logWood does not drop itself unless it is harvested with an iron axe. Diamond axe does not produce any drops, as if it is not listed. If I add any other tool to the beginning of the list (i.e. "tools":["minecraft:golden_axe,*","minecraft:iron_axe,*","minecraft:diamond_axe,*"]) , save the file and use /bd reload, only the first tool (golden axe) in the new list is recognized.

I have about 26 tools that need to be able to harvest ore:logWood, as well as other oredict entries.

So call me old school, but trying to get a drop set up with proper NBT tags, and trying to get it to work properly. I'm modifying the dead bush block's drops, and for the most part my drops work, except for one, which needs NBT data assigned to it. The one drop is an Agricraft seed, .. well Agricraft uses a single item but customizes it based on NBT data. In my JSON (This is a partial copy/pasta)

      {
        "id": "agricraft:agri_seed",
        "metadata": 0,
        "toolsBlacklist": true,
        "tools": [],
        "fortunechancemap": {
          "0": 5,
          "1": 5,
          "2": 5,
          "3": 5
        },
        "fortunequantitymap": {
          "0": {
            "minquantity": 1,
            "maxquantity": 1
          },
          "1": {
            "minquantity": 1,
            "maxquantity": 1
          },
          "2": {
            "minquantity": 1,
            "maxquantity": 1
          },
          "3": {
            "minquantity": 1,
            "maxquantity": 1
          }
        },
        "biomeBlacklist": true,
        "biomes": [],
        "minYLevel": 0,
        "maxYLevel": 256,
        "minExp": 0,
        "maxExp": 0,
        "gamestageBlacklist": true,
        "gamestageAll": true,
        "gameStageList": [],
        "modifierBlacklist": true,
        "modifierList": [],
        "traitBlacklist": true,
        "traitList": [],
        "enchantmentBlacklist": true,
        "enchantmentList": [],
        "nbtBlacklist": true,
        "nbtList": [
          "agri_analyzed:0",
          "agri_strength:1",
          "agri_gain:1",
          "agri_seed:carrot_plant",
          "agri_growth:1"
        ],
        "exclusive": true
      }

Is there a specific format that needs to be used for the nbtList section to have BlockDropTweaker assign the proper NBT data? I am getting the agricraft:agri_seed item to drop, but it drops with NO NBT data applied to it.

Crafttweaker format for the item in question: agricraft:agri_seed.withTag({agri_analyzed: 0 as byte, agri_strength: 1 as byte, agri_gain: 1 as byte, agri_seed: "carrot_plant", agri_growth: 1 as byte})

Crash Log
https://gist.github.com/tgstyle/21c047e4adf5a63ea31ace47ec958458

rwtema/Extra-Utilities-2-Source#192

I wanted to force Redstone ore to drop itself rather than dropping dust. I had plans for other methods that would let you refine the ore into dust . . . it looked like the commands worked and it generated a file . . . but when I use an iron pick on a block of Redstone ore I still get the dust.

Here is the generated file's text:

{"minecraft:redstone_ore,*":{"replace":true,"allowsilktouch":true,"dropsilktouchalways":true,"toolsBlacklist":true,"tools":[],"biomeBlacklist":true,"biomes":[],"minYLevel":0,"maxYLevel":256,"minExp":0,"maxExp":0,"gamestageBlacklist":true,"gamestageAll":true,"gameStageList":[],"modifierBlacklist":true,"modifierList":[],"traitBlacklist":true,"traitList":[],"enchantmentBlacklist":true,"enchantmentList":[],"nbtBlacklist":true,"nbtList":[],"fortunechance":{"0":100,"1":100,"2":100,"3":100},"dropdatalist":[{"id":"minecraft:redstone_ore","metadata":0,"toolsBlacklist":true,"tools":[],"fortunechancemap":{"0":100,"1":100,"2":100,"3":100},"fortunequantitymap":{"0":{"minquantity":1,"maxquantity":1},"1":{"minquantity":1,"maxquantity":1},"2":{"minquantity":1,"maxquantity":1},"3":{"minquantity":1,"maxquantity":1}},"biomeBlacklist":true,"biomes":[],"minYLevel":0,"maxYLevel":256,"minExp":0,"maxExp":0,"gamestageBlacklist":true,"gamestageAll":true,"gameStageList":[],"modifierBlacklist":true,"modifierList":[],"traitBlacklist":true,"traitList":[],"enchantmentBlacklist":true,"enchantmentList":[],"nbtBlacklist":true,"nbtList":[],"exclusive":false}]}}

a command "/bd block tool add" dosent support ore dic. i type "/bd block tool add ore:toolShears" and I get a error in chat saying i need to add metadata. when i add it "/bd block tool add ore:toolShears *" another error pops up in chat saying that the item dosent exist. i tried alot of things but it seems the ore dic isint supported. It would be cool if u could make it so it would support it because I have, and im sure some other person will need it to, add 30+ shears for around 50 blocks.

I dont think I need to post the client logs since the clinet dosent crash or anything. The errors say in chat.

Using 1.12.2-2.4 version.

P.s. the ore:toolShears is custom made and it does work. the ore exist on the tool and I can make crafting recipes using that ore dic.

I want to change the item drop for about 50 types of gems in my modpacks, but all those is fortunable... So, Now question to change 1, I have to set the item drop chance for all level of Fortune manually... Already with 3 level, this is a pain to do, for 50 ores, but, I have 10 levels of fortune in my modpack, and I want to have both functioning with each type of gems. By default, minecraft use a calculation for minimum and maximum drop chance for each level of fortune, so you can use a fortune 100 pickaxe and it will drop the right amount, but, using BlockDropsTweaker, this is totally impossible for what I see to do....

So, If you can add a possibility to change the drop, but keeping the same fortune calculation than the block normally have, it should be great and this will give me the possibility to do what I want for my modpack, unless, I have to found another good Java programmer question to write a mod to do that, and this is not easy without good connexions :-(, or totally forget my idea, but this will break a good part of my modpack :-( .

Thank's
Fireztonez

Any chance we could get the ability to define how many of our drop we want to get from a block? Currently there's no way to do this, and I'd like to be able to customize this.

Silk Touch produces custom drops and silk touched block, regardless of whether "dropsilktouchalways":true, is set to true or false.

"allowsilktouch":false, prevents the block from dropping but in turn means silk touch won't have affect on the block.

Basically silk touch either doesn't work or it works and also drops the custom block drops, which isn't ideal.

I want bookshelves to drop their items, and I'm using chisel, so there's like a hundred different bookshelves. I'm using ore:bookshelf to match all of them, but afaik there's no way to replace the existing drops with the block itself. If there is, let me know. Otherwise, this is a feature request.

https://github.com/TheAwesomeGem/BlockDropsTweaker/blob/master/src/main/java/net/theawesomegem/blockdropstweaker/common/blockconfig/ConfigurationHandler.java#L156-L169

This is the way I write JsonObjects to strings in my mod:

private static String getJsonString (final JsonObject json, final String indent) {
	try {
		final StringWriter stringWriter = new StringWriter();
		final JsonWriter jsonWriter = new JsonWriter(stringWriter);
		jsonWriter.setLenient(true);
		jsonWriter.setIndent(indent == null ? "" : indent);
		Streams.write(json, jsonWriter);
		return stringWriter.toString();

	} catch (final IOException e) {
		return null;
	}
}

And then you just provide the method with the string it should indent with. Passing null or an empty string does minified JSON (like it is currently).

I'm trying to get the beds to drop a piece of cotton, and not the bed, but I'm having no luck. It seems I can't even add an extra drop. I tried using * and also tried specify the metadata. No luck.

I just tried editing the chest, too. And I'm realizing the mod is "BlockDrops" not "TileEntities"... So perhaps this is a feature request?

Thanks for an easy to use, awesome mod. And thank you for having such clear documentation!

Could you have your mod register its block drop changes with the Block Drops JEI addon if it is present?