theassemblyarmada / chronoshift Goto Github PK

Example if you have one badger deliver say 5 Tanyas you could get 2 or more badgers delivering badger count * 5 Tanyas. No clue where this is coming from but seems directly related to reinforcement teams not triggers that spawn them.
Another time when another team is triggered is if a existing team is damaged, this happens even if no reinforce when damaged flags are set so something is buggy here.

To be investigated further.

Looking at ThemeControl in ThemeClass i had a idea that we could reuse that logic for movies.
Check which movies are available and show those in the future Movies menu, as well as have a bit for noting if a movie has been seen, thus unlocked, thus selectable to play in the Movies menu, these logics being akin to how movies are unlocked in RA2/YR.

We are missing Theater condition check for the shp loading.

These optimizations make debugging of our code a whole lot harder.
Adding -oc will stop Watcom from optimizing returns into jumps to another identical return.
Adding -ou will make Watcom make every function a unique function.

Likely a buffer size is too small for such quality audio.

This isn't a complete list but it's a rough overview what I saw in YR. TS likely shows even more.
"?" are to be investigated.

Paradrop_Cargo : VOC_CHUTE1 = ChuteSound
AircraftClass::Fire_At : 9 = CameraRange
AircraftClass::Look : ?
AnimClass::AnimClass : ANIM_LZ_SMOKE = DropZoneAnim
AnimClass::AI : ANIM_LZ_SMOKE = DropZoneAnim
BuildingClass::Take_Damage : VOC_KABOOM22 or VOC_CRMBLE2 or VOC_KABOOM1 = BuildingDieSound or BuildingDamageSound, 400 = ShakeScreen
BuildingClass::Repair : VOC_SCOLDY1 = ScoldSound, VOC_RAMENU1 = GenericClick
BuildingClass::Sell_Back : VOC_RAMENU1 = GenericClick
BuildingClass::Mission_Construction : VOC_CONSTRUCTION = Construction
BuildingClass::Mission_Deconstruction : VOC_CASHTURN = SellSound
BuildingClass::Mission_Repair : ?
BuildingClass::Crew_Type : INFANTRY_ENGINEER = Engineer, Technician
BuildingClass::Factory_AI : if ( exitobj_retval <= 1 ): 45 = PlacementDelay
CellClass::Goodie_Check : ?
Wide_Area_Damage : ?
CrateClass::Put_Crate : OVERLAY_WATER_WOOD_CRATE = WaterCrateImg, OVERLAY_WOOD_CRATE = WoodCrateImg
CrateClass::Get_Crate : OVERLAY_WOOD_CRATE = WoodCrateImg, OVERLAY_STEEL_CRATE = CrateImg OVERLAY_WATER_WOOD_CRATE = WaterCrateImg
CreditClass::Graphic_Logic VOC_MONEY_UP and VOC_MONEY_DOWN = CreditTicks[up, down]
FootClass::Mission_Guard_Area : GuardModeStray?
FootClass::Active_Click_With : ANIM_MOVEFLASH = MoveFlash
FootClass::Sell_Back : VOC_CASHTURN = SellSound
HouseClass::AI : HarvesterUnit?
HouseClass::Attacked : VOX_BASER_UNDER_ATTACK = BaseUnderAttackSound
HouseClass::Place_Object : VOC_PLACE_BUILDING = BuildingSlam
HouseClass::Sell_Wall : VOC_CASHTURN = SellSound
HouseClass::Computer_Paranoid : AlliesAllowed?
InfantryClass::Enter_Idle_Mode : IdleActionFrequency?
MessageListClass::Add_Message : VOC_INCOMING_MESSAGE = IncomingMessage
ObjectClass::AI : -3 = ParachuteMaxFallRate, -100 = NoParachuteMaxFallRate
ObjectClass::In_Which_Layer : CruiseHeight?
ObjectClass::Paradrop : ANIM_PARABOMB = BombParachute, ANIM_PARACHUTE = Parachute
OptionsClass::Set_Sound_Volume : VOC_RABEEP1 = GenericBeep
OverlayClass::Mark : OVERLAY_WATER_WOOD_CRATE = WaterCrateImg, OVERLAY_STEEL_CRATE = CrateImg
RadarClass::Radar_Activate : VOC_RADAR_OFF = RadarOff, VOC_RADAR_ON = RadarOn
TeamClass::Coordinate_Move : 256 = CloseEnough
TechnoClass::Time_To_Build : ?
TechnoClass::Fire_At : ?
TechnoClass::Do_Uncloak : CloakingStages? VOC_SUB_SHOW or VOC_IRONCUR9 = CloakSound 
TechnoClass::Do_Cloak : CloakingStages? VOC_SUB_SHOW or VOC_IRONCUR9 = CloakSound 
TechnoClass::Visual_Character : 38 = CloakingStages
TechnoClass::Crew_Type : Crew, Technician
TerrainClass::Catch_Fire : ANIM_BURNMED or ANIM_BURNBIG = TreeFire
UnitClass::Harvesting : HarvesterLoadRate?
UnitClass::Mission_Unload : HarvesterDumpRate?
UnitClass::Mission_Harvest : TiberiumLongScan? TiberiumShortScan? HarvesterTooFarDistance RepairBay? HarvesterLoadRate?
AnimClass::Sort_Y : 0x10000 = YSortAdjust (read as YSortAdjust in RA2 AnimTypeClass Read_INI, passed to AnimClass)
UnitClass::Crew_Type : Crew, Technician
AircraftClass::Take_Damage - INFANTRY_E1 = Pilot
UnitClass::Take_Damage 400 = ShakeScreen
AnimClass::Do_Atom_Damage ? = NukeWarhead
BulletClass::Bullet_Explodes : ? = NukeWarhead
InfantryClass::Get_Image_Data : E1.shp = Disguise, (Type == INFANTRY_SPY) ? = Disguised
UnitClass::Try_To_Deploy : VOC_PLACE_BUILDING = BuildingDrop
BulletClass::AI : ANIM_FIREBALLFADE : ANIM_SMOKE_PUFF = Trailer

If you lose or again a building prerequisites get updated which makes the sidebar reset its scroll position, we should work out some solution that maintains the scrolled location, at least roughly.

If i place a Ranger bellow to the tree and give a move order to the area where the cursor is to the infantry unit placed next to the tree the infantry unit won't move.

Twin Cannon misnamed as "Twin" and most Counterstrike Themes.

If any debug text is on printed on the cells and you scroll around eventually the text is gonna start at the tactical's edges.
Showing the old RA++ project screenshot as it shows best what i mean,

however this issue is present since TD.

This is likely due to incorrect Window dimensions that leave deadzones where no redrawing is done.

when loading a specific save of Sov 2, crashes accessing OccupierPtr at 004EDA18

the strip window is 160x192 at 496:180
Its possible it was intended to cover the powerbar too as it is the sidebar's width which is 160 pixels.
Need to investigate how aligning it back affects drawing, and how fixing the width but keeping the position affects the drawing.

Please do not add such code, it prevents things like ccache, PCH, etc.

Consider using a dedicated file and only setting such options for that one target. See OpenRCT2/OpenRCT2#6538 for inspiration.

When you fill say all your airstrips with Yaks you can't build more until a airstrip is free, in RA you could prebuild the next unit.

When a unit is leaving the map at the edge the visual is likely to stick around until the cell is forced to redraw.

In RA you don't get to see what you sent, this is a enhancement in later games that RA is long overdue for.

Not sure how to debug this but it seems there's a deadzone 1/5th of the way, then half way though it might be max volume already.
The issue is present in RA, Sole and TD

While close, the current implementation apparently doesn't quite match the behaviour of the cloak effect in the original C&C, with the haze being "right leaning" rather than "left leaning". This needs to be investigated and fixed at some point.

This is something we caused
Steps to reproduce it always are
Move the viewport to a water area so that there's water cells behind the sidebar as well, then select a vessel near the sidebar, slide the mouse over to the sidebar, it will remain on the move cursor

When switching to ingame from the editor the resources will grow, switching back to the editor you end up being forced to save the map with the new resources.
We should capture the resource state and restore it upon jumping into the editor. Alternatively we could make the editor load the map again instead of maintaining the existing state to prevent this all together.

trans Icon contains a unidentified tile that isn't used anywhere anymore, it looks strikingly like build range indication art

especially when stacked as seen in this mockup image

and with some color

This would likely be a optional feature not something enabled by default.
From a technical point of view i see this being possible to do in the 8-bit limits by using Fading tables.

We should log it and do a force a Emergency Exit or show a dialog explaining what happened, right now it just crashes without telling you what mix made things go wrong

For example cost, buildability of expansion units and the Ant Queen.

This is a issue we caused, currently unknown how.
To replicate it just play soviet 01 and try to blow up a Jeep with a yak

Not much can read these formats, currently not sure where it goes into nonstandard territory.

This would avoid issues like

WinMain checks for "REDALERT.INI" which is redundant on the Windows version.
Reason for this logic is cause in DOS you HAD to run SETUP before you could start the game cause SETUP set up the sound configuration. This config, while read, isn't actually used by the Windows version.

Removing this check will solve first run freezes as the game gets stuck looking for the ini.
We should write a new ini instead if none exists.

If the Theme pool only has for example 3 songs for example

• Bigfoot
• Face the Enemy 1
• Hell March
  its highly likely the next song will be Bigfoot again even tho there seems to be code in place that should prevent the current Theme from being reused.

When you sell the Prerequisite provider the units/buildings that had that Prerequisite are still available until you lose your conyard.

Besides being extremely loud and annoying this exposes their locations.

Clicking a button and dragging the mouse while the mouse button is still held makes the mouse cursor disappear

At a rare chance a heavy spike in the I/O happens.
It might be when it can't play a theme, couldn't trigger it again to check
Game is still playable only abusive I/O is going on in background.

This issue is also present in C&C95 It always plays track 1 on game start unless scenario specifies otherwise, this was fixed in Sole Survivor and TS.