the-poolz / locked-pools Goto Github PK

maybe: we can make a new pool for the new user, and make the amount 0
or we need to make sure the allowance is reset.

problem:
When we create a new memory array, we must specify its length. But at this stage, we do not know how many elements will be required

Lets slit the Creating to other file

let's find better file names (and the locations of the functions.)

Please list all the commands and how to use them by category (admin, pool owner, user).

we can't pass a value without first initiating

    uint256[] memory ids;
    ids[index] = allIds[i]; // invalid opcode error

    uint256[] memory ids = new uint256[](allIds.length);
    ids[index] = allIds[i];

we need the owner to be part of the topic:

like in the transfer / allow

Seems like wrong logic

should be: pool.StartAmount - pool.DebitedAmount > 0

• add description to all functions
• change TransferPoolOwnership to PoolTransfer description, testnet event

This is a Version update for a locked deal, in this version we will perform:

• #10
• #11

1. 0% unlock before the first-timer
2. 100% after the second-timer
3. 50% in the middle, and so on... calculate by the second

• #12

and format repo files.

update visibility of variables.

not changing the debited amount, the user can withdraw tokens, then split pool, to double spend

Potential problem:
Using the CreateNewPool function could potentially lead to a hack. When we pass a fake token that overwrites the transfer logic or other functions.

Solution:
If Token is bad for our contract we can create a whitelist of tokens that can be only used to create a pool. This feature is disabled by default.

after withdrawing tokens, if the pool got 0
remove the id from the user list.

add a new view function that can get an input list of addresses, that will return only pools id that the token address is matching.

this will help the front to faster fetch all id's for a specific token

We already have a public Allowance variable that returns the allocation amount.
Allowance function signature: Allowance(uint256 _PoolId, address _Address) public view returns(uint256)

GetMyPoolDataByToken will looks like:

GetMyPoolDataByToken(address[] memory _tokens) 
{
 return GetPoolsData(GetMyPoolsIdByToken(_tokens));
}

• add payment system - price per lock and.
• free price list (using whitelist contract)- this address, don't pay.

If the pool has started and the debit amount is still zero, the owner can split the pool.

It will take an array of Id's and return all the data

this function can be used as libery

in current version, splitting after withdraw can lose tokens

Instead, use the _UserAddress input parameter.

instead use Focal linux distribution

If the pool is created and the debit amount is still zero, the owner can call the PoolTransfer function. In other cases, no.

• #64
• #58
• #59
• #67
• #61