Create a "actionCreatorFactory" function about deox HOT 8 CLOSED

My workaround would be passing an object with all the string literals like so:

//Over Simplified Version

// We have a "Factory" where we declare the shape of our ActionCreators
type Factory = {
  a: (name: string) => /** ActionCreator */ ()=> { type: name };
  b: (name: string) => /** ActionCreator */ ()=> { type: name };
};

// We have a object with the same keys as the factory where we pass the ActionTypes
type Names = {
  a: "A";
  b: "B";
};

// We have produce an object with the correct ActionCreators
type Result = {
  a: () =>{ type: "A" };
  b: () =>{ type: "B" };
};

// The shape of the function
function(factory): (names) => result

It introduces some boilerplate, but the types that it produces will have the correct literals.

from deox.

Sorry for being away. September was a busy month.

I will do a rewrite with the approach that you suggested soon as I get some time.

from deox.

Looks related to #66 (not exactly similar).
The main issue is string interpolation which generalizes the string literal type to string type. Do you find any solution for it?

from deox.

There are some workarounds for string literal type operators in microsoft/TypeScript#12940 and microsoft/TypeScript#6579.

from deox.

I think we could tweak createActionCreator to return a cleaner type, but I don't know if this would be a breaking change.

Should I experiment with it in that same branch or create a separate branch?

I think that ithe ActionCreator type should have the following signature:

interface ActionCreator<
  TAction extends string,
  TCallable extends (...args: any) => any = (...args: any) => any,
  TPayload = undefined,
  TMeta = undefined
> {
  (...args: Parameters<TCallable>): Action<TAction, TPayload, TMeta>;
  type: TAction;
  toString(): TAction;
}

from deox.

Hello. Maybe it is possible to implement this using Template Literal Types from Typescript 4.1+

from deox.

@Spaubleit Yes. At the time there was no recursive types nor template types on Typescript. I think implementing this should be quite easy at the current state. Thanks for bringing this issue to my attention

Right now I am using @reduxjs/toolkit slices, but a more strong typed alternative would be quite good

from deox.

I am closing this because I see no more benefit in implementing this. As much as the action type information looks nice in the linter, its often wrong (I say from experience because I implemented this in a separate fork). Also, see https://phryneas.de/redux-typescript-no-discriminating-union

from deox.