Git Product home page Git Product logo

Comments (5)

DCzajkowski avatar DCzajkowski commented on September 23, 2024 1

The problem we are having at this point, is that we don't have tree-shaking implemented and it seems like deox is pulling in rxjs and redux-starter-kit. So from my perspective, removing it from the core would be a good choice 😅

from deox.

the-dr-lazy avatar the-dr-lazy commented on September 23, 2024

Thank you for reaching.
If I be right, that huge size is due to dependency of configureStore to the redux-starter-kit library. If you don't use it, it will be able to tree shake and you will not gain any size from that.

As you can see in the screenshot, the actual functionality of the library is not that huge.

Screen Shot 2020-09-04 at 11 11 29 PM

from deox.

TNikolai avatar TNikolai commented on September 23, 2024

Yes, as I can see it is used in examples.
If it is only the place where configure store is needed, maybe it is an option to have 2 separate build steps one for examples with connfigureStore and another just for the deox lib without additional libs. Probably tsconfig includes line should be updated and one more build step added for package.json scripts.

from deox.

the-dr-lazy avatar the-dr-lazy commented on September 23, 2024

Why we should care about usage of configureStore? If any user of package doesn't use it, it should tree shake.
I didn't decided yet but maybe I'll go for a breaking change to remove configureStore. Anyone wants to use it then can simply install redux-starter-kit and go on.

How does includes TSC option affect bundle size? It's strange, did you tested it?

from deox.

TNikolai avatar TNikolai commented on September 23, 2024

--How does includes TSC option affect bundle size? It's strange, did you tested it?
No, I didn't test it, I thought TSC.includes an option used for the build but that is wrong it is used only for TS compilation.

from deox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.