tfarcenim / metalbarrels Goto Github PK

Metal Barrels 3.1
Minecraft 1.16.1

I think the screenshot shows the issue well. Copper, Wood, and Iron seem okay. Have not tested others yet.

Thought I should test the others and found this - the Crystal barrel does not render transparent.

Using a wooden to iron barrel upgrade to convert a chest to an iron chest duplicated the first 3 rows of a double chest into the upgraded chest.

The right side of a double chest with the latch facing east (placing the chest facing west) was upgraded

Forge: 31.2.36
Iron Chests: 10.0.3
Metal Barrels: 2.1
Minecraft: 1.15.2

Having to break a full obsidian barrel to upgrade it is kind of a pain. Any chance at a new upgrade?

There is a sorting function in quark (using 3.2 538) that can be used with a keybind or a GUI element, pictured above. It used to work in previous versions but in 1.18.2, and I assume onwards, this has dissappeared and doesn't work. Have not tested with other mods that have a sorting function.

metalbarrels-3.3.jar
Tested on Forge 33.0.37 (modpack: ATM 6 1.0.6) - multiplayer server.
Also tested on Forge 33.0.61 with no other mods installed - singleplayer.

Upgrading from a vanilla barrel causes contents to be deleted. Also tested iron to gold, and gold to diamond, and contents also get deleted.

Latest/debug logs show no new entries after I upgrade and view empty barrel inventory. Let me know if you need any other info. Thanks!

Not sure if it means much, but noticed this error during server boot...

Using:

• Forge 1.20.1 - 47.2.20
• metalbarrels-1.20.1-1

Error:

[28Jan2024 12:00:13.200] [main/ERROR] [net.minecraft.world.item.crafting.RecipeManager/]: Parsing error loading recipe metalbarrels:barrels/obsidian_to_netherite_barrel
com.google.gson.JsonSyntaxException: Invalid or unsupported recipe type 'minecraft:smithing'
at net.minecraft.world.item.crafting.RecipeManager.m_220253_(RecipeManager.java:170) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
at net.minecraft.world.item.crafting.RecipeManager.fromJson(RecipeManager.java:169) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at net.minecraft.world.item.crafting.RecipeManager.m_5787_(RecipeManager.java:67) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at net.minecraft.world.item.crafting.RecipeManager.m_5787_(RecipeManager.java:34) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at net.minecraft.server.packs.resources.SimplePreparableReloadListener.m_10789_(SimplePreparableReloadListener.java:13) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?]
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
at net.minecraft.server.packs.resources.SimpleReloadInstance.m_143940_(SimpleReloadInstance.java:69) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at net.minecraft.Util.m_214652_(Util.java:783) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at net.minecraft.Util.m_214679_(Util.java:772) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at net.minecraft.server.Main.main(Main.java:166) ~[server-1.20.1-20230612.114412-srg.jar%23519!/:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.2.20.jar%2369!/:?]
at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.serverService(CommonLaunchHandler.java:103) ~[fmlloader-1.20.1-47.2.20.jar%2369!/:?]
at net.minecraftforge.fml.loading.targets.CommonServerLaunchHandler.lambda$makeService$0(CommonServerLaunchHandler.java:27) ~[fmlloader-1.20.1-47.2.20.jar%2369!/:?]
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar%2355!/:?]
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar%2355!/:?]
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar%2355!/:?]
at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar%2355!/:?]
at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar%2355!/:?]
at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar%2355!/:?]
at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar%2355!/:?]
at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?]

latest.log
i think you fixed on 1.18 and forgot to fix on 1.19 to

Can't ctrl+k inside of the barrels either.

(I'm sure you're aware that the quark features aren't present either (sorting button or filter button)

when the barrel is destroyed, objects drop out

forge：1.20.1-1
forge：47.2.17

Obsidian barrels can't be put into the forge to be upgraded to alloy barrels

Any other container when closing the gui if you have a item in your mouse curser (picked up) drops it or adds it to the player inventory. Yours just keeps it in the Curser.
The curser is not saved that means it can accidentally void items.

Using this mod in 1.16.1, I've come across a minor graphical glitch as viewed below:

This only appears to occur on the Silver Barrel, no matter the GUI zoom.
I'm very much enjoying working with this mod and look forward to what you bring to the table in the future!
Thank you!

Aeroneously

I crashed when trying to load the mod up.

https://paste.gg/p/anonymous/cab3a32603e1418dab97f5114081ba6f

Hi,

i use this mod on MC 1.15.2, but item rendering for Crystal Barrels is buggy, items are "stacked" north-west for idk wich reason, and is not affected by the Barrel orientation. xD

screenshot : https://image.noelshack.com/fichiers/2020/13/2/1585068333-2020-03-24-17-39-09.jpg

The barrels are tagged as minecraft:mineable_with_pickaxe while the correct tag is minecraft:mineable/pickaxe, causing the blocks to break slowly even with pickaxe efficiency 5.

I fixed it via KubeJS for my server. Just reporting it so it might get fixed for other players.

https://github.com/svenhjol/Charm/issues/320

Why?

Just to link the two together so folks will know why they can't make basic wooden barrels to upgrade to metal barrels if CHARM is installed too.

Hi o/ !
I've added your mod in its lastest version in my modpack and I've come with weird bugs.
In order to check if it's not my pack the problem, I've created a new instance on forge 40.1.76 with only jei-1.18.2-9.7.1.255 and your mod metalbarrels-1.18.2-4.2 and even asked to a friend to check to be sure and we still both have the same problem.

So, with a 2 scale GUI (or any other scale) Diamond, Silver, Gold and Crystal barrels GUI is completely broken (slots appears off grid too)

Iron, Obsidian, Copper and Netherite barrels all have only a double chest inventory

I've no idea where it came from, and I'm honestly surprised that in a mod with nearly 10 millions dl noone I've reported that before so I'm really unsure if it's me or your mod the problem.

Thanks for making this.
I'm trying to release a pack through Curse/Twitch, but it wont let me see/add mods without an exact version compatibility match. I've been using this mod in 1.16.4 without issue for a while through MultiMC, this is just a Curse metadata issue.

I wouldn't bother you except I'm using your upgrades as quest rewards.

mekanism/Mekanism#7285

https://gist.github.com/ProsperCraft/dbd9a418ee77c02921c52c7d84c30733

Console stacktrace-
https://gist.github.com/ProsperCraft/9dd41920119d5f82c7abf832db1f9811

metalbarrels-1.1a

It may not matter, but the barrel was obtained through a chance globe.

(MC 1.16.1, MetalBarrels 3.2b)

There seems to be a duplication exploit where when an almost full double chest is upgraded to an Iron Chests iron chest using a Wood To Iron Barrel Upgrade (which is intended functionality from what I can tell?), the "right" half of the chest retains all of the original chest's contents rather than just the "lower half" of items. The "left" half of the chest will still contain whatever was in the "upper half" of the original double chest, effectively duplicating that half of the original items.

https://github.com/Yamahari/ILikeWood
making metalbarrels without converting to universal barrel

https://gist.github.com/ProsperCraft/eb9391b9a4421cf88bb27967a6cc9965

metalbarrels-1.3